[AMD Official Use Only - AMD Internal Distribution Only] Hi Kevin, LGTM! Thanks & Regards, Sivaprasad ________________________________ From: Kevin Traynor Sent: Friday, October 31, 2025 8:03 PM To: Tummala, Sivaprasad Cc: Anatoly Burakov ; dpdk stable Subject: patch 'eal/x86: enable timeout in AMD power monitor' has been queued to stable release 24.11.4 Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4e309113126d8cf44cf2e50362ae590a176e07ac Thanks. Kevin --- From 4e309113126d8cf44cf2e50362ae590a176e07ac Mon Sep 17 00:00:00 2001 From: Sivaprasad Tummala Date: Mon, 13 Oct 2025 05:51:57 +0000 Subject: [PATCH] eal/x86: enable timeout in AMD power monitor [ upstream commit 1213a8895be3bf883f10b3ba60ee84099b5ff75a ] Previously, the AMD power monitor implementation did not enable the timeout, causing the lcore to remain in a wait state until an external monitoring event occurred or an interrupt was received. This patch enables the timeout-based exit condition, allowing the lcore to automatically wake up after the specified period. The maximum supported timeout value is 2^32 - 1. Fixes: c7ed1ce04704 ("eal/x86: add power intrinsics for AMD") Signed-off-by: Sivaprasad Tummala Acked-by: Anatoly Burakov --- lib/eal/x86/rte_power_intrinsics.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_intrinsics.c index f7d558153e..b46e8c2aba 100644 --- a/lib/eal/x86/rte_power_intrinsics.c +++ b/lib/eal/x86/rte_power_intrinsics.c @@ -88,12 +88,12 @@ static void amd_monitorx(volatile void *addr) static void amd_mwaitx(const uint64_t timeout) { - RTE_SET_USED(timeout); #if defined(RTE_TOOLCHAIN_MSVC) || defined(__MWAITX__) - _mm_mwaitx(0, 0, 0); + _mm_mwaitx(2, 0, (uint32_t)timeout); #else asm volatile(".byte 0x0f, 0x01, 0xfb;" : /* ignore rflags */ : "a"(0), /* enter C1 */ - "c"(0)); /* no time-out */ + "b"((uint32_t)timeout), + "c"(2)); /* enable time-out */ #endif } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:54.355466019 +0000 +++ 0069-eal-x86-enable-timeout-in-AMD-power-monitor.patch 2025-10-31 13:53:52.173523796 +0000 @@ -1 +1 @@ -From 1213a8895be3bf883f10b3ba60ee84099b5ff75a Mon Sep 17 00:00:00 2001 +From 4e309113126d8cf44cf2e50362ae590a176e07ac Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1213a8895be3bf883f10b3ba60ee84099b5ff75a ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 489ad3983f..8a5f222aea 100644 +index f7d558153e..b46e8c2aba 100644 @@ -27 +28 @@ -@@ -90,12 +90,12 @@ static void amd_monitorx(volatile void *addr) +@@ -88,12 +88,12 @@ static void amd_monitorx(volatile void *addr)