Hi David, ________________________________ > From: David Marchand > Sent: Tuesday, November 12, 2024 5:02 PM > To: Xueming Li > Cc: Stephen Hemminger ; Chengwen Feng ; dpdk stable > Subject: Re: patch 'log: add a per line log helper' has been queued to stable release 23.11.3 > > Hello Xueming, > > On Mon, Nov 11, 2024 at 7:30 AM Xueming Li wrote: > > > > Hi, > > > > FYI, your patch has been queued to stable release 23.11.3 > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > > It will be pushed if I get no objections before 11/30/24. So please > > shout if anyone has objections. > > > > Also note that after the patch there's a diff of the upstream commit vs the > > patch applied to the branch. This will indicate if there was any rebasing > > needed to apply to the stable branch. If there were code changes for rebasing > > (ie: not only metadata diffs), please double check that the rebase was > > correctly done. > > > > Queued patches are on a temporary branch at: > > https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging > > > > This queued commit can be viewed at: > > https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b6d04ef865b12f884aaf475adc454184cefae753 > > > > Thanks. > > > > Xueming Li > > > > --- > > From b6d04ef865b12f884aaf475adc454184cefae753 Mon Sep 17 00:00:00 2001 > > From: David Marchand > > Date: Fri, 17 Nov 2023 14:18:23 +0100 > > Subject: [PATCH] log: add a per line log helper > > Cc: Xueming Li > > > > [upstream commit ab550c1d6a0893f00198017a3a0e7cd402a667fd] > > > > gcc builtin __builtin_strchr can be used as a static assertion to check > > whether passed format strings contain a \n. > > This can be useful to detect double \n in log messages. > > > > Signed-off-by: David Marchand > > Acked-by: Stephen Hemminger > > Acked-by: Chengwen Feng > > Why do we want this change backported? It's a dependency of below patch to backport, any suggestion? - f665790a5d drivers: remove redundant newline from logs -- David Marchand