From: "Gupta, Nipun" <Nipun.Gupta@amd.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Agarwal, Nikhil" <nikhil.agarwal@amd.com>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v1 2/2] bus/cdx: fix incorrect device release on error
Date: Mon, 3 Nov 2025 04:30:27 +0000 [thread overview]
Message-ID: <CH3PR12MB91931D8D32CC4638AA789089E8C7A@CH3PR12MB9193.namprd12.prod.outlook.com> (raw)
In-Reply-To: <05ecc81aefbbe2073416c0e78aed926ec9ad54b5.1761299581.git.anatoly.burakov@intel.com>
[AMD Official Use Only - AMD Internal Distribution Only]
> -----Original Message-----
> From: Anatoly Burakov <anatoly.burakov@intel.com>
> Sent: Friday, October 24, 2025 3:23 PM
> To: dev@dpdk.org; Gupta, Nipun <Nipun.Gupta@amd.com>; Agarwal, Nikhil
> <nikhil.agarwal@amd.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Cc: stable@dpdk.org
> Subject: [PATCH v1 2/2] bus/cdx: fix incorrect device release on error
>
> The variable cdx_addr is a stack-allocated zero-initialized char array, but
> it is never used anywhere except in an error handler to stand it as a
> device bus address for a VFIO device release call. This is incorrect, as it
> should have been actual device address, so fix the code to reflect that.
>
> Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
> Cc: nipun.gupta@amd.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Nipun Gupta <nipun.gupta@amd.com>
next prev parent reply other threads:[~2025-11-03 4:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 9:53 [PATCH v1 1/2] bus/cdx: fix empty device string in error message Anatoly Burakov
2025-10-24 9:53 ` [PATCH v1 2/2] bus/cdx: fix incorrect device release on error Anatoly Burakov
2025-10-30 8:54 ` David Marchand
2025-11-03 4:30 ` Gupta, Nipun [this message]
2025-11-04 10:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR12MB91931D8D32CC4638AA789089E8C7A@CH3PR12MB9193.namprd12.prod.outlook.com \
--to=nipun.gupta@amd.com \
--cc=Ferruh.Yigit@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.agarwal@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).