From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3] test/hash: fix buffer overflow
Date: Wed, 20 Oct 2021 20:49:47 +0000 [thread overview]
Message-ID: <CO1PR11MB5172FD551174D99473DE2CC2C3BE9@CO1PR11MB5172.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8woJZZN3q6sTx1XGGqqOO-UAv-g9p925ZhhEg+oOUxxuA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, October 20, 2021 12:54 PM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh
> <sameh.gobriel@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Cc: dev <dev@dpdk.org>; dpdk stable <stable@dpdk.org>; Medvedkin,
> Vladimir <vladimir.medvedkin@intel.com>
> Subject: Re: [PATCH v3] test/hash: fix buffer overflow
>
> On Tue, Oct 19, 2021 at 5:58 PM Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com> wrote:
> > > I am not against the fix, but it seems to test something different
> > > than what an application using the hash library would do.
> > > Or if an application directly calls this hash function, maybe the
> > > unit test should not test it via rte_hash_create (which seems to
> > > defeat the abstraction).
> > >
> >
> > I'd say that user should not use this hash function with rte_hash.
> > Yipeng, Sameh, Bruce,
> > what do you think?
>
> Guys, can we conclude?
> Thanks.
>
>
> --
> David Marchand
[Wang, Yipeng]
Vladimir, Bruce and I discussed a bit offline and I think we agreed on this fix.
But we should be more clear in the comment of rte_hash_create about what hash function the API expected (I.e. key length is byte count).
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
next prev parent reply other threads:[~2021-10-20 20:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 21:28 [dpdk-stable] [PATCH] " Vladimir Medvedkin
2021-10-11 11:03 ` David Marchand
2021-10-13 19:26 ` Medvedkin, Vladimir
2021-10-14 7:04 ` David Marchand
2021-10-14 17:46 ` Medvedkin, Vladimir
2021-10-13 19:27 ` [dpdk-stable] [PATCH v2] " Vladimir Medvedkin
2021-10-14 8:34 ` David Marchand
2021-10-14 17:47 ` Medvedkin, Vladimir
2021-10-14 17:48 ` [dpdk-stable] [PATCH v3] " Vladimir Medvedkin
2021-10-15 9:33 ` David Marchand
2021-10-15 13:02 ` Medvedkin, Vladimir
2021-10-19 7:02 ` David Marchand
2021-10-19 15:57 ` Medvedkin, Vladimir
2021-10-20 19:54 ` David Marchand
2021-10-20 20:49 ` Wang, Yipeng1 [this message]
2021-10-21 7:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5172FD551174D99473DE2CC2C3BE9@CO1PR11MB5172.namprd11.prod.outlook.com \
--to=yipeng1.wang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).