RE: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12

[Ankur Dwivedi <adwivedi@marvell.com>]

Hi David,

>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Friday, June 17, 2022 5:38 PM
>To: Ankur Dwivedi <adwivedi@marvell.com>
>Cc: dev <dev@dpdk.org>; Anoob Joseph <anoobj@marvell.com>; Akhil Goyal
><gakhil@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Jerin
>Jacob Kollanukkaran <jerinj@marvell.com>; dpdk stable <stable@dpdk.org>
>Subject: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12
>
>External Email
>
>----------------------------------------------------------------------
>On Fri, Jun 17, 2022 at 8:15 AM Ankur Dwivedi <adwivedi@marvell.com>
>wrote:
>>
>> The following warning is observed with GCC 12 compilation:
>>
>> In function ‘fill_sg_comp_from_iov’,
>>     inlined from ‘cpt_zuc_snow3g_enc_prep’ at
>>         ../drivers/common/cpt/cpt_ucode.h:1672:9,
>>     inlined from ‘cpt_fc_enc_hmac_prep’ at
>>         ../drivers/common/cpt/cpt_ucode.h:2472:3,
>>     inlined from ‘fill_digest_params’ at
>>         ../drivers/common/cpt/cpt_ucode.h:3548:14,
>>     inlined from ‘otx_cpt_enq_single_sym’ at
>>         ../drivers/crypto/octeontx/otx_cryptodev_ops.c:541:9,
>>     inlined from ‘otx_cpt_enq_single_sym_sessless’ at
>>         ../drivers/crypto/octeontx/otx_cryptodev_ops.c:584:8,
>>     inlined from ‘otx_cpt_enq_single’ at
>>         ../drivers/crypto/octeontx/otx_cryptodev_ops.c:611:11,
>>     inlined from ‘otx_cpt_pkt_enqueue’ at
>>         ../drivers/crypto/octeontx/otx_cryptodev_ops.c:643:9,
>>     inlined from ‘otx_cpt_enqueue_sym’ at
>>         ../drivers/crypto/octeontx/otx_cryptodev_ops.c:668:9:
>> ../drivers/common/cpt/cpt_ucode.h:415:36: warning: array subscript 0
>> is outside array bounds of ‘buf_ptr_t[0]’ {aka ‘struct buf_ptr[]’}
>> [-Warray-bounds]
>>   415 |                         e_dma_addr = bufs[j].dma_addr;
>>       |                         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
>> ../drivers/common/cpt/cpt_ucode.h:416:48: warning: array subscript 0
>> is outside array bounds of ‘buf_ptr_t[0]’ {aka ‘struct buf_ptr[]’}
>> [-Warray-bounds]
>>   416 |                         e_len = (size > bufs[j].size) ?
>>       |                                         ~~~~~~~^~~~~
>>
>> This patch resolves the warning.
>>
>
>Bugzilla ID: 861
>> Fixes: 9be415daf469 ("common/cpt: add common defines for microcode")
>> Fixes: b74652f3a91f ("common/cpt: add microcode interface for
>> encryption")
>Nit: No need for this blank line.
Thanks for the review. Will send a v2 with the changes.
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> Reviewed-by: Anoob Joseph <anoobj@marvell.com>
>> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
>
>
>--
>David Marchand

Regards,
Ankur