From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Zhou, YidingX" <yidingx.zhou@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Harman Kalra <hkalra@marvell.com>
Subject: RE: [PATCH v6] lib/eal: fix segfaults in exiting
Date: Wed, 19 Oct 2022 01:51:21 +0000 [thread overview]
Message-ID: <CO6PR11MB5602294EBFE3217457AE2F98F12B9@CO6PR11MB5602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221011070402.76c709e0@hermes.local>
Hi Stephen, thanks for your comments.
The original goal of this patch is to close the 'eal-intr-thread' to fix segfaults
caught by Asan. But it breaks the debug_autotest unit test.
So the flag is added to fix the unit test.
Hi @David Marchand, what's your suggestions?
BR
Zhichao
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, October 11, 2022 10:04 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Zhou, YidingX
> <yidingx.zhou@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Harman Kalra <hkalra@marvell.com>
> Subject: Re: [PATCH v6] lib/eal: fix segfaults in exiting
>
> On Tue, 11 Oct 2022 13:25:14 +0800
> Zhichao Zeng <zhichaox.zeng@intel.com> wrote:
>
> > This patch closes the 'eal-intr-thread' before memory cleanup in
> > 'rte_eal_cleanup' to avoid segfaults, and adds a flag to avoid
> > executing 'rte_eal_cleanup' in the child process which is forked to
> > execute some test cases(e.g. debug_autotest of dpdk-test
>
> This is a test bug, not an DPDK bug. I don't think DPDK should account for
> misuse of API in this way.
prev parent reply other threads:[~2022-10-19 1:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220523111642.10406-1-zhichaox.zeng@intel.com>
2022-05-30 13:47 ` [PATCH v3] lib/eal: fix segfaults due to thread exit order zhichaox.zeng
2022-05-30 16:26 ` Stephen Hemminger
2022-05-30 16:28 ` Stephen Hemminger
2022-06-02 8:21 ` Zeng, ZhichaoX
2022-06-07 10:14 ` Zeng, ZhichaoX
2022-06-15 6:01 ` [PATCH v4] " zhichaox.zeng
2022-06-24 1:42 ` Zeng, ZhichaoX
2022-06-24 7:50 ` David Marchand
2022-06-30 10:38 ` Zeng, ZhichaoX
2022-06-30 12:24 ` Bruce Richardson
2022-09-06 2:51 ` [PATCH v5] lib/eal: fix segfaults in exiting Zhichao Zeng
2022-09-06 15:03 ` Stephen Hemminger
2022-09-07 8:53 ` Zeng, ZhichaoX
2022-10-11 5:25 ` [PATCH v6] " Zhichao Zeng
2022-10-11 14:04 ` Stephen Hemminger
2022-10-19 1:51 ` Zeng, ZhichaoX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR11MB5602294EBFE3217457AE2F98F12B9@CO6PR11MB5602.namprd11.prod.outlook.com \
--to=zhichaox.zeng@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).