From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D53F1A0572 for <public@inbox.dpdk.org>; Wed, 19 Oct 2022 03:51:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0435C410FC; Wed, 19 Oct 2022 03:51:35 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id A0FFC40041; Wed, 19 Oct 2022 03:51:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666144291; x=1697680291; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EWA+ljHGDzQdbPB9MVx4BUPvU6a9hHHo1hnHaBoFf7A=; b=D+fudLwgNWnSjLBwLBRkbBvQEXGGNfFBqpD34mPZ5cEydcj6xRIFsXS/ hZM5ZEkhYwCXHcSOcbGJCZtT23l1DvZ7j7x1BzQbwCwk/Vhv+Z2QbfwSX DVNt63iKV8q6TiKCkfG8yFvhki8oB0t0em0/MgFtihQLzdq+h4MpwLl0Z Kut1pCZpoGxML+ML8QzXgumrGoAjGii8YMWo+xoqADVpFhhylbWzH3Fha JuuhaLmhoJzH79+rL7zvEnrglOuXQCtiecy1FfcWULcPZimjPBom7FlvN ahWJfL6Xeqh1Z1WYZybgpTZVKZHYSEa38K7bIlaG+kSBye4byClKhoQgY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="303897572" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208";a="303897572" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 18:51:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="660095829" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208";a="660095829" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 18 Oct 2022 18:51:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 18:51:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 18:51:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 18:51:26 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 18:51:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q4oyYvzN6apw+kqsInW2rBTqMBWkohZFdBjW847cewzYd655et2mAkzi9NswluUII38aGM7bahsVwOVUkOxp7FmBQbr9QSOFkm9eTMUXPqWN7Xv3puCtrlTvX/E+Dl+jxUz6qGveFpEBq8uLm3Sx7rbbankHKQiiqeLx029WOth3g5yS00iZ2qip3DO4lrOfLDTuua1WuvvkeOun4Xs8xH0en1KHwpFj0FC+aCMB5Qiw8rAXFLFWVwFNUaaR7cBWk3U2d+BpmzcGdvfwDQ0t48Qkl0lb9T+6Fuoo33T4q0DmcO6vME9x/n25FAablPIDSqzDclN4fWsTwOTOXVpI1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EWA+ljHGDzQdbPB9MVx4BUPvU6a9hHHo1hnHaBoFf7A=; b=CusKZgjufjpLzVAmS1faCeZIWkSMJfUcT3wb17IIOps1aKgL/FDr41/mtAvy10LfbxfWr5fvEfuzO5ybSDG9l1tzd9XE5IfeNfi8izUNmG7hhVO4CDmGvtPOqdw0NnjQJDfvqjZB2CnTRQ55Lpqtsr7Svh/cev8zZPXUZ7+4n7elG5OU6HUZr2bKmXSumwn2JogE9CICFT9XYjY6V7eUvWPsIqWYDEWQi1Xh1G2vPeYT+NW5KIfLhzT50g71C5QMx+gVwKwK/5VInt+Du6h3ihVU1KOIha739hw6NEt5+4EwfluJ6h/Atvhbaq+7InE2SqaU8Np/9Hay7QMz0073Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH0PR11MB4776.namprd11.prod.outlook.com (2603:10b6:510:30::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Wed, 19 Oct 2022 01:51:21 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::623b:7365:46b:36fc]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::623b:7365:46b:36fc%7]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 01:51:21 +0000 From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com> To: Stephen Hemminger <stephen@networkplumber.org>, David Marchand <david.marchand@redhat.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>, "Zhou, YidingX" <yidingx.zhou@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, Harman Kalra <hkalra@marvell.com> Subject: RE: [PATCH v6] lib/eal: fix segfaults in exiting Thread-Topic: [PATCH v6] lib/eal: fix segfaults in exiting Thread-Index: AQHY3TGnv6ITdMz40UmrB94fs4oNHK4JOj4AgAqWLPA= Date: Wed, 19 Oct 2022 01:51:21 +0000 Message-ID: <CO6PR11MB5602294EBFE3217457AE2F98F12B9@CO6PR11MB5602.namprd11.prod.outlook.com> References: <20220906025132.160801-1-zhichaox.zeng@intel.com> <20221011052514.1430015-1-zhichaox.zeng@intel.com> <20221011070402.76c709e0@hermes.local> In-Reply-To: <20221011070402.76c709e0@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-Mentions: david.marchand@redhat.com X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5602:EE_|PH0PR11MB4776:EE_ x-ms-office365-filtering-correlation-id: 0fd15cf3-d0b6-4a05-47c5-08dab1746c19 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: duEbl7aYnaTLNKp8qPxnuTaK0m1EV+LCnfXslLa6BegQWpDbqlbAT/urb93J+XwHB7khQwH2plzbK1idByl4oLEYIoGbDVLgamXRIMSB4pUgUB+lOuPHKl69fKjytvK0zDMoBAIHzXC5HLdX3a9kDaMTugWVyWGr4gChhyECpJx1bfa5vRxQnBzUq2fJHtpnND2UY087vDbw1GSB8O53wLGaKUGBmKTcJNuyDk5bp7suU8EwkbGlqgFQDir87GkIKxuMVAzv7UIN2U8UXp3lqNPqQsJ8NZVPshwrZSWlqVYG5810UvVoYTkLk0kP67yU2mKPFq3CSOvPFpzBa4p07rEUSdJo7U00AP7EJyZQjGQHpSitjsJv8nvqPkaI3T93yKWLvODJ//FGRaI+xGA5iCuIxUMKY3YOHEdcxGZIahT46cnjJRVn9M3iP8GWO5xj6XW6NQUWt93WmuRh8ozAeof5G83F+6q/i2rNhNltMVxC2hrhsMiiZGm06PW9uGGTYpev7EJWRYotS8bBrbeLNwhhXSGjaAXqUOuz/2+Fk/O9UsUCvzvAJ+LXtyNUSI2+9t6HlDYYaM61mSP7/EMFGUNpRMAJpjPLYvLSdWK1/f2XdpoFO2wHwyKQ+O/JP3QeSR8Ru+3HW8Jitc3glFODLva3xemcvIE6jfGJbgpND6+How9lXHyfmFl3EKc/i72G4CF9Nc78e8wiCCR1lqpGghjxZ4qLaQfl7BUXBXumYJ3h3boyavYRJkjl7h76cTAmZzUNI8XBlaam982BkI4rlw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5602.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199015)(83380400001)(33656002)(38070700005)(86362001)(38100700002)(82960400001)(4744005)(122000001)(5660300002)(52536014)(8936002)(110136005)(4326008)(76116006)(41300700001)(66446008)(66946007)(66556008)(7696005)(53546011)(2906002)(66476007)(186003)(64756008)(54906003)(316002)(8676002)(6506007)(9686003)(55016003)(71200400001)(26005)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sbYqr9VszMDjBdP6/6vBFnMvJm/YGHgDrtgkVWADMlWEyn4CJKmNbShUxEBH?= =?us-ascii?Q?uxfdJ07Ra2Q2jVoCSicwA1gjw34+DjiDaisb7sApYHZ1Qx3ZLcKBxx81j29D?= =?us-ascii?Q?mkTrnpO/YQWTJLqipxAp+2klD+zVb0VjWJTinwCeCQwLcfvmAZe4VvV29pAO?= =?us-ascii?Q?WEf4IJs1zvnWpbvfwn7iXYsxdarQrVuJT5d3byreiLnE6nH7VWNKWRnExLc8?= =?us-ascii?Q?GOBRLGpbxgOj7cJkl025uCGMiwxraWyM3ofeJHU/d9DpJvSv5CDsBjZiUioo?= =?us-ascii?Q?hqM6s307mjmIGwgpBZ7PmKxqo38s1zT1Q2W8D5A8VS1Ey6n5HL71kv5M4l6m?= =?us-ascii?Q?Nbpo7K8eOYwdpCJmYRG/FP//ZXLDMpaRlT41AqLOheDuu9FJGjens4ag0ULw?= =?us-ascii?Q?TOr+QPG2bnWuhjkXdgZBB/GEN04EjmRY6z5Y74FnEnVWw+ZbLoOrAbaRVuse?= =?us-ascii?Q?dlGW3AktV7XPNL/j2ED4lL8mQpxsG0w9ExAmehabjj4v9eG6yTmyYs4NenE0?= =?us-ascii?Q?plvPuyB3nrmtv3Z4u3XiXH89JHeJA/MIBuAYsIWXDmqZi4O655J8FqKfD3LP?= =?us-ascii?Q?QMyJOP5itmBC+++conjepGRTmb8A9Uzd4ClSPUL++EecMPkf0XN4E1mxOq9f?= =?us-ascii?Q?sA0Pdiw1h4UnVUYwT8qYmDQJEnSctoXeEkvLuktCeoWdBCPQCA+4jmZE2oYY?= =?us-ascii?Q?3gacbr8+AbLmsPppm2LswwTMSCviQekpUHWHI5do1imZwugDdwB8sxd8fYbw?= =?us-ascii?Q?33Ou6s1ewo8Il6UlAlEbGrqfbudxfpZfUgdaSwDMCG/10zEBX0MpANASVSDI?= =?us-ascii?Q?HzR3Cck/YS6aIcupJTQkSUuWZVJYvRYbgFNvd5TR29rihslUbQh9q7SjbCKE?= =?us-ascii?Q?Km0glXOEt+OUJc6Ul8Mhi8kbUBekgaMZ4NGtP0Kc6K4OWvChLKIfsao0aAON?= =?us-ascii?Q?AnpzcfQExb9zwWOT2Yt02PBvjBpbGsGojdJ10ge8Zk1iWrjNRlJ2QxH9z4pw?= =?us-ascii?Q?5peBIDvhebaiz+F3d47WLU8/q+je4rZnJo8igMar0d/boh4O9aQcN82bL81S?= =?us-ascii?Q?cdTLh0BHz62eGtX//eU3yPAMPX/6RKpjgrN5r/2E2kZzY8KX1qeV8B4VsN43?= =?us-ascii?Q?1l7VbaXhzfk2k4Dl2GiZzrmAIBNtHUyKzAa3dV2Ic4O3LTLufolSTpXVGwJ6?= =?us-ascii?Q?QzxK32inspxFGV63DLZxm5DliuY3y+RUGPfDfXMlD5nuNNPMqJUivykP7QS+?= =?us-ascii?Q?0RDhY3HMAO79AfY6eILpQpF0EuztDc1ybnqKjV3NsE6GVjnbjhWYXx9clhAy?= =?us-ascii?Q?FPch/MXDQHLByZF/+N3fN6fTgSXefB3eUHSrWAW66qf44s+5fua4Svrm+elX?= =?us-ascii?Q?BhuCJuivb6pMH9SpwGsbxO3Q1py7s8VATqbaM49EJpbDOKTE6bN9Nl1ayNtV?= =?us-ascii?Q?entz387mpDbODKEug8JdhSkz901oH3+9lWj+vRpK/0ioUDpEPZgJtwG+akkD?= =?us-ascii?Q?LH+ALMnKZBi1JwXqr4PhyNl7pqGiLbqIkZD4Ct/ZPRf05udSXg0bkSmurnjk?= =?us-ascii?Q?V0Uif3pikhwSHTZDMilJLU8tzJrVL1jW+fe1oRlt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fd15cf3-d0b6-4a05-47c5-08dab1746c19 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 01:51:21.3953 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5uezlS6Z5MrwEObw/eYhhkyDCYd4Qx5uDj4hzmC6Yxlj/nXifXRNzd6j0o/D+tP4s6C8NEiDD8QDyVkkf4RO/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4776 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Hi Stephen, thanks for your comments.=20 The original goal of this patch is to close the 'eal-intr-thread' to fix se= gfaults caught by Asan. But it breaks the debug_autotest unit test. So the flag is added to fix the unit test. Hi @David Marchand, what's your suggestions? BR Zhichao > -----Original Message----- > From: Stephen Hemminger <stephen@networkplumber.org> > Sent: Tuesday, October 11, 2022 10:04 PM > To: Zeng, ZhichaoX <zhichaox.zeng@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org; Zhou, YidingX > <yidingx.zhou@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com>; Harman Kalra <hkalra@marvell.com> > Subject: Re: [PATCH v6] lib/eal: fix segfaults in exiting >=20 > On Tue, 11 Oct 2022 13:25:14 +0800 > Zhichao Zeng <zhichaox.zeng@intel.com> wrote: >=20 > > This patch closes the 'eal-intr-thread' before memory cleanup in > > 'rte_eal_cleanup' to avoid segfaults, and adds a flag to avoid > > executing 'rte_eal_cleanup' in the child process which is forked to > > execute some test cases(e.g. debug_autotest of dpdk-test >=20 > This is a test bug, not an DPDK bug. I don't think DPDK should account fo= r > misuse of API in this way.