From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>,
"hkalra@marvell.com" <hkalra@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "aconole@redhat.com" <aconole@redhat.com>,
"Matz, Olivier" <olivier.matz@6wind.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Subject: RE: [PATCH v3] lib/eal: fix segfaults due to thread exit order
Date: Tue, 7 Jun 2022 10:14:42 +0000 [thread overview]
Message-ID: <CO6PR11MB5602A3D83761108111B6C023F1A59@CO6PR11MB5602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220530134738.488602-1-zhichaox.zeng@intel.com>
Hi David, Harman
Please review this patch at your convenience. Thanks!
In addition, I tried to figure out the reason for the failure of the CI test. There is a saying that
this is a problem with Asan when cancelling a thread that is waiting on epoll. After adding the
'-fstack-protector-all' parameter, there will be no exception. But I don't know the software
environment for automated testing, so I can't verify this statement.
Regards
> Subject: [PATCH v3] lib/eal: fix segfaults due to thread exit order
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
> The eal-intr-thread is not closed before memory cleanup in the process of exiting. There is a small probability that when the eal-intr-thread is about to use some pointers, the memory were just cleaned, which cause the segment fault error caught by ASan.
> This patch close the eal-intr-thread before memory cleanup when exiting to avoid segment fault.
> ---
> v2: add the same API for FreeBSD
> ---
> v3: fix rte_eal_cleanup crash in debug_autotest
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
next prev parent reply other threads:[~2022-06-07 10:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220523111642.10406-1-zhichaox.zeng@intel.com>
2022-05-30 13:47 ` zhichaox.zeng
2022-05-30 16:26 ` Stephen Hemminger
2022-05-30 16:28 ` Stephen Hemminger
2022-06-02 8:21 ` Zeng, ZhichaoX
2022-06-07 10:14 ` Zeng, ZhichaoX [this message]
2022-06-15 6:01 ` [PATCH v4] " zhichaox.zeng
2022-06-24 1:42 ` Zeng, ZhichaoX
2022-06-24 7:50 ` David Marchand
2022-06-30 10:38 ` Zeng, ZhichaoX
2022-06-30 12:24 ` Bruce Richardson
2022-09-06 2:51 ` [PATCH v5] lib/eal: fix segfaults in exiting Zhichao Zeng
2022-09-06 15:03 ` Stephen Hemminger
2022-09-07 8:53 ` Zeng, ZhichaoX
2022-10-11 5:25 ` [PATCH v6] " Zhichao Zeng
2022-10-11 14:04 ` Stephen Hemminger
2022-10-19 1:51 ` Zeng, ZhichaoX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR11MB5602A3D83761108111B6C023F1A59@CO6PR11MB5602.namprd11.prod.outlook.com \
--to=zhichaox.zeng@intel.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).