From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18FF9A0554 for ; Thu, 20 Oct 2022 18:15:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EAF942670; Thu, 20 Oct 2022 18:15:30 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id CC5D740FAE; Thu, 20 Oct 2022 18:15:26 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29K6QwqM010421; Thu, 20 Oct 2022 09:15:26 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kb125a2gf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 09:15:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NpAx9qRcTd3hLGLnY5SdUsJqZuiSIEvk44IjhNxnbNhUpo6QUkhVG+85CkW79y7T/N5sAyY5FBU4vRAUIn3CWvHmN6BRj1ZEw2izx2sz+NDkl0mo6JG0swjrTZKcwbxPelfrRghn82hPvJQ0wRxb18qq5cVgngZT/AF7YPZDm+rVolP2Ff4Gb5AOPXdMmPqqLqd34PfXkZF5OcWY1EjoHLPLpxMlVIU6IwHfIo/hRZUBqwNel2jBK24p9zwK55uJoG9GYgD8o/RziTiwIsmrGcqh++PD7XA7dwcHFC49+nYpKa3XNm/85POZrFgytQpCout9eDT6JUVznMtU7iHLAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6eeaUdQu/loR7iwj5Gl3PDUXDxuh3lQW1nMfIEc31EE=; b=gTuW3jXk/fVog4NrnyQOfFZk7T2qXm25Z0kzcBf0RKC46po6i7meFtiA9HjQ0osQT0JVqNP77IL3GqoHAIvq2zFIBrRN+EnvQFFnuKAsLNh135nJiG9UEmDio0ltQkDkpDI7N+WpowWEcwg0UBTztOq9Pgw11N3RB72dijYPnOy21x/BvsyH370bf8d6U+5CE/wNzXtTpgpGLx5cLl/YAnTt2VGxEVT2e6AY8ATKDqtVVksOFUEv13+RQ+yUjmubD2sp0VDcldXYeD1r5VkkNnEeRU+whNCRP1QAixhDe+wibq8VIg5l157EI0tcInjcl/1MkWBWpN+J5KQhMBsJrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6eeaUdQu/loR7iwj5Gl3PDUXDxuh3lQW1nMfIEc31EE=; b=gFiIB9WAjNvUY/mLIpg83tV7oi67b3xQ8jJQEh1PgqeHhm0BwZGn+PwFq5V7LiVmPsujTPe9oYABA0p0ORlMmSQAsRK8MhDTQbctgDgSvnH1WivnF/TvmrGKOuCkq/41j1Hd4XBNbYuEgtIXwV3fk502LiUteIQqfR0LP/Akyds= Received: from CO6PR18MB4084.namprd18.prod.outlook.com (2603:10b6:5:349::18) by PH0PR18MB4842.namprd18.prod.outlook.com (2603:10b6:510:111::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct 2022 16:15:22 +0000 Received: from CO6PR18MB4084.namprd18.prod.outlook.com ([fe80::6af3:4b91:3290:f358]) by CO6PR18MB4084.namprd18.prod.outlook.com ([fe80::6af3:4b91:3290:f358%7]) with mapi id 15.20.5723.029; Thu, 20 Oct 2022 16:15:22 +0000 From: Pavan Nikhilesh Bhagavatula To: Shijith Thotton , Jerin Jacob Kollanukkaran , David Christensen CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [EXT] [PATCH v5 1/5] examples/l3fwd: fix port group mask generation Thread-Topic: [EXT] [PATCH v5 1/5] examples/l3fwd: fix port group mask generation Thread-Index: AQHY3VnwiNaG+7vaKE2aZFeuE+s5/q4ShuOAgAT8kYA= Date: Thu, 20 Oct 2022 16:15:22 +0000 Message-ID: References: <20221011090805.3602-1-pbhagavatula@marvell.com> <20221011101207.4489-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4084:EE_|PH0PR18MB4842:EE_ x-ms-office365-filtering-correlation-id: c9fc52e1-99ad-4447-5ebe-08dab2b64a35 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dRBnDS5/YmHlBQeRrHUqOFhShMp+TKwWsDMOzGSMlicfNZpQkLlbcYZrJ5Qk9y6m5/SpqERFPk7Z0b7779aNMRC/RSA9qGjZcQsPiuyZJHYqs0Yq5k8OW2i0DFUKsFdYfttqviuDzM5EFz0v6H7kSzxL2zzAwq8YTkruGFryMdmGym6a/+sZI7pIoGLxs8O6rhVdf1aYIHFw6dosbaRyLi1CIpdUFFXah6SdoZ/2+HF0yO8dOAtlu/a4Ojo5nu948VCa06Fq/NcH7XPnZFtiM4Hxx1tO52taP3OTszXnqFUx9VUEFmt2TXcg5rgHTknSvy4hr7GWNk25rtw7WRC/VUpWr+UMQe9jLyMtvHoMqbHxIupS7KBYeYghFmDn8vuOPTwKcnqZ7I5L6YJ3qeC9fNnoJpo0V5YrgDLGiv4Tvt8aGRxyZr45GZi8cwcc6Aw1rqfh6vzzdz9fghXiXtx2xukWDaerwtJGO43O+xLOUm5TTs3e2KJFBLkwCIltSwA1zIRGQ0xyA6Pc2p16xmj7Tpf6IE4mg6/Ee+4yjm5s62ThAxj5ogDJPT7/Wez9v/T1ygvxoK/92sBQ5SI0rfEgYwCAhxk8toLVZgZamZB9X7Lvy+/DUMC0WV9H21uuoLkZVP34fUlYAJgjCxiByQhqdCB4BykxNJokEL5jWapd8ezjIiPhoZSgdrLguWn2BUnblz8E76Mza157VW5hNkxCQbd23ZeSSr9fNdLlQ8p++QhviVVPn+LJvTXjgG/KLOX5jyush5w7E8CvuLvbQrC4kg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4084.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(451199015)(54906003)(110136005)(86362001)(66946007)(66556008)(66476007)(66446008)(76116006)(4326008)(64756008)(8676002)(53546011)(26005)(9686003)(6506007)(83380400001)(41300700001)(5660300002)(7696005)(55016003)(316002)(8936002)(52536014)(71200400001)(186003)(2906002)(33656002)(38100700002)(122000001)(478600001)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/y7brvL8HMBKI4AHotTlR7Aktd3WM99iKfeXNtS4mRJn2GhP4PHkTLXiHvRB?= =?us-ascii?Q?JX8ONJLthAQ8gRvKZEx530Bduwt/UOROEyWHdQIgei3LelOx4XIexmhB5XxO?= =?us-ascii?Q?w9DeEG9PUSKhrfFz0MqQ5TXyMcHxNZYfbWPxBF5ywk45kXw9ICo8dDy6Yebd?= =?us-ascii?Q?3Gl3cWBbnzuJkzgrWg/5x8Z0tkU+hXCpCm8n9BA5SFWmJRx4fW0wO8X89nwl?= =?us-ascii?Q?dLdfRbn5rY9cDrUzpACDD01qjqFzg467D+CShGBchQwEEv4O7B+yE7ySVx73?= =?us-ascii?Q?Baa5Xw47nIs5BphxZkKh5cxlZA7M5oh8Uvtotjm+Seuk81ihyUfEVAyDFeWK?= =?us-ascii?Q?5crZHOhCZAju+sRD9nwx8wID2oLWUjIMe3tEUfB2ubUkLPhrAZ246VX6gXFa?= =?us-ascii?Q?J9kXaKTWDxLcUg0D2wSCDEppXGTAImhsE5BHZyiLo2D9OrKMab/2s5YNoqCR?= =?us-ascii?Q?DpY3b0NF0CNCBtznDWT900+s8umSGxuTMw8TxcHoLtANEjaePrfEwdi/IYl+?= =?us-ascii?Q?i821SuTn/4gbl/hquD9IQgD4Spgle9AH2cjXNHqYkxjvwjC2kMixqi5I1Sgg?= =?us-ascii?Q?6Z4XP0t45EZ3nVVI+p+TZuU6Z/XYiAK3yFfSPymtDpZVwuXYUOW8kIm/dvzu?= =?us-ascii?Q?QblEOA5qqfNh7CE7bDkwcgeXT1mgwqJL2ZUmDa4nTWS2xn2VTO83FOZyY14g?= =?us-ascii?Q?yjS0xk0jbx5QS/1b1GEw+VgpKssLOFapM45jaqTc0nxdm0YaPPdVG/qCL/xU?= =?us-ascii?Q?AWGohdE3TctFINy64qzJlCzi7Z2Y8orFFBcboWlHULP78d3WtvprTS6RRIPB?= =?us-ascii?Q?cu6GtJmrkx1u9X0dgnrlu8W9Dp/nerdIFXOLXlijo+NnhGwQP0jKF4mec/9j?= =?us-ascii?Q?TfL/7k+BAR8OSZt/FrBefiAeZp3X52JOl8oI5Ox6wgli8Y1GfOACcm5Q1hgB?= =?us-ascii?Q?f+wMld1lrU6OLDiRcJDTHMgujfklduZx82qmHcaF9xNA1/Y9WCkYhck/p0Fh?= =?us-ascii?Q?+JFH5sKXLs5rimEWUpxj4pctKF8pNuyPgm7ceu9yKvglAX6Wsub4xrmAiKDg?= =?us-ascii?Q?4zS9exb72C5Cc3py4mV5diSxQjLfXTRhBMC9WnAbVKzlkTRp/td4Yal+xZuI?= =?us-ascii?Q?RmBO96tulfQzKApvLvJIXl2MJKXkRaOSprzYYIe79sJ4bKUwKfArEVMfEJbc?= =?us-ascii?Q?l1Azeltm8REbAZb2kQsR7X0Y2bRNvmIWDO3o7y971seB8C/B/m9RrXMLirDD?= =?us-ascii?Q?VTe+t3JgY/os2wTQzeVFrhK7WC1QlirrLJKjEhOhbAh6rgVCxPzgxvjaETl9?= =?us-ascii?Q?CNp5rIfdKx+3Fl+uePugjsuvo+v78XooUfSxNXCBs4KahWlYKPaImw34d+Qf?= =?us-ascii?Q?ASKNr6BolWJiH4hMB82ivOlzAKlFbe2yHze/hE0lqyiKlpNWSxjs0BHrsO6i?= =?us-ascii?Q?bFLDkW9K4UCS5IuTdLpujH3btIIRAtSsif8Z/Up0l4MqCaq4mEDP9kWtoK4G?= =?us-ascii?Q?NtjAcxBg7lJ3XTKOc9VHwhc+X+MLr/M3ymGlhipFAInIY7svdUKsYLzUTedC?= =?us-ascii?Q?apWF7vinnvvf0OAsdnEUH/ORpoEDkBx4VZ4/x839?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4084.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9fc52e1-99ad-4447-5ebe-08dab2b64a35 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 16:15:22.4837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9X9rq1NTCeZthQSg0T7TRoPumrcOmikhi6GKirw3McD2LurAiZGIrSmsMrzwgpeOkmCIeAGqlSeuA1JKHbmTrgker/RAt8nGMOwQiZaIIsc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4842 X-Proofpoint-GUID: vSKy1rYbSRVbchdjb0qjfeNx6SOPU6k- X-Proofpoint-ORIG-GUID: vSKy1rYbSRVbchdjb0qjfeNx6SOPU6k- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-20_07,2022-10-20_01,2022-06-22_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Shijith Thotton > Sent: Monday, October 17, 2022 5:36 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; David Christensen > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; stable@dpdk.org > Subject: RE: [EXT] [PATCH v5 1/5] examples/l3fwd: fix port group mask > generation >=20 > > > >Fix port group mask generation in altivec, vec_any_eq returns > >0 or 1 while port_groupx4 expects comparison mask result. > > > >Fixes: 2193b7467f7a ("examples/l3fwd: optimize packet processing on > powerpc") > >Cc: stable@dpdk.org > > > >Signed-off-by: Pavan Nikhilesh >=20 > Acked-by: Shijith Thotton >=20 Thomas,=20 Will this series make it into 22.11 release? > >--- > > v5 Changes: > > - Fix compilation errors. > > > > v4 Changes: > > - Fix missing `rte_free`. > > > > v3 Changes: > > - PPC optimize port mask generation. > > - Fix aarch32 compilation. > > > > v2 Changes: > > - Fix PPC, RISC-V, aarch32 compilation. > > > > examples/common/altivec/port_group.h | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > >diff --git a/examples/common/altivec/port_group.h > >b/examples/common/altivec/port_group.h > >index 5e209b02fa..1c05bc025a 100644 > >--- a/examples/common/altivec/port_group.h > >+++ b/examples/common/altivec/port_group.h > >@@ -26,12 +26,17 @@ port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t > *lp, > > uint16_t u16[FWDSTEP + 1]; > > uint64_t u64; > > } *pnum =3D (void *)pn; > >- > >+ __vector unsigned long long result; > >+ const __vector unsigned int perm_mask =3D {0x00204060, 0x80808080, > >+ 0x80808080, 0x80808080}; > > int32_t v; > > > >- v =3D vec_any_eq(dp1, dp2); > >- > >+ dp1 =3D (__vector unsigned short)vec_cmpeq(dp1, dp2); > >+ dp1 =3D vec_mergeh(dp1, dp1); > >+ result =3D (__vector unsigned long long)vec_vbpermq( > >+ (__vector unsigned char)dp1, (__vector unsigned > >char)perm_mask); > > > >+ v =3D result[1]; > > /* update last port counter. */ > > lp[0] +=3D gptbl[v].lpv; > > > >-- > >2.25.1