From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9885A034E for ; Thu, 17 Feb 2022 19:22:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D1AF4113F; Thu, 17 Feb 2022 19:22:12 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2D40740150; Thu, 17 Feb 2022 19:22:10 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21HFRgFc025670; Thu, 17 Feb 2022 10:22:09 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e9kktt6ps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Feb 2022 10:22:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ntu2vNA3oYoRtZAsOsQvk9TNYEP3rezQpnQfcoqbVtOIdjiwU0KPXRdok/k8jLfDivxFolYj7/qs1suP4OMc21ZarMkXPhfcJ8ny36dqvbmrhZZjDeImdDY0DPNBXripPq14+W9zfYeVUfU2HzipoutRF4q9bpdFNx5VuJ3bbzCDyxp9lySHe71jlXoEbHqoZl7WNmFVSPtbgGnSSy8OvzT020tcrmbvnqtMhr63dA9yZiXgVVTzJiFtpameAafbW9vyTOgP7AOhJ1o6vYVOcmOH9FfFAje4zMhCLsccO9gENmUSTBOLN6YG5En+Gs0/J8ah93pLqZqMRhXonvjixw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gXWW/vCYgZa6TNhpG2GKoMOIJ5+Zy3Suf7YGzNq1XKY=; b=M6J1baWxDvBONknHeW8IGbQiFw/MZ5GHsP/2y63RC6L+42D0qEyLLolX1DhwBIXYTAWcUK5tX0nO2H8JJprxNIQOD1/VSbZ4a/cbm8VjBlIDZE4GqTSCLuC4ka729Fq5Mmf368zo8AxM2XHCosKAruZbcC8Ee71AroEbW+ZLqDLSx4ibVgRXSQfT8zFcqq/2zpF4XZmxyRrWa8VlhBsxLFzX1PP6dq7BJ0/GHbUKCDFOU4siDxUnksTI8ZFXQSQ9pjjUMc7FhK7k8goqZE+m0Gp7ZD4/s5Esj10tVO1ywy619qhlWP/e3hkMNEgZk6ZClf/P7ZsL02l86Avleb75OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gXWW/vCYgZa6TNhpG2GKoMOIJ5+Zy3Suf7YGzNq1XKY=; b=tyPItGXprGR5P1dZQAYNwlILg+5n1El0IQNn6EzgEJlPyKu1evFjwXJWDesskdGK4pLFcajQ0C8TcqQnY0uFJ6ribHat3L6xjCEgUUCTVrtbpB3fsOkzmSzanmqQ7D4XBDJYZI7yRlmn+8CmPmbESDlxmJQWJBkenhGiGnu2BJE= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM6PR18MB3131.namprd18.prod.outlook.com (2603:10b6:5:1c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 17 Feb 2022 18:22:07 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1c79:10d9:2997:cd79]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1c79:10d9:2997:cd79%7]) with mapi id 15.20.4995.017; Thu, 17 Feb 2022 18:22:07 +0000 From: Akhil Goyal To: Ciara Power , "dev@dpdk.org" CC: "stable@dpdk.org" , "john.mcnamara@intel.com" , "roy.fan.zhang@intel.com" , Pablo de Lara Subject: RE: [EXT] [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code Thread-Topic: [EXT] [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code Thread-Index: AQHYIlxSzeGgm8BOBU+IgWYRiX+OBayYEbwQ Date: Thu, 17 Feb 2022 18:22:07 +0000 Message-ID: References: <20220215110758.149380-1-ciara.power@intel.com> In-Reply-To: <20220215110758.149380-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d37c4408-ef47-4941-d254-08d9f24267bd x-ms-traffictypediagnostic: DM6PR18MB3131:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XXeIaT9OoRwRi8kkjZ03iuMsVhbu4F4cuS/X+scECIFivL0p/+G7E/ROrGJY9873hxewnEHJfmsS8p9T71ElD41jCWOrZ6oHyIs8ochp1me6Ou30v7f/CtQzpD5IrZB1j25IqAHlMXDT7x0zMTUBo4QTJFOwi2+R/Inxp6yw/RsKj4z/Ntbtcl5nX2hT1qoq1V+ac9GS/nMH1yn8LXl0sH7TUhP3yiOFcnx8FulKl4In3KPjkxSBvZFUDVP9zgM0znWvKHD0oPo9vwxvsnCar6MHXxRd7H5xj/WzWOvHPK11hSLCbw04hdCz3hwiJgZL7aYYZjBn6Jbrma83TAKGgNiPUrqUKxarJNk0pNLLcYmXolmjKCPlLs/wZY7vk/AJ0vzRdaclIUMKclFiyqg4Jb05ZmMbuHeTzr9cblO8tsRk2azcuDQmnzWr1MBMWNPX79DTLTBJUK7lSGSQv0SssY+X+lO3bmptLSGe16MqzhR4bADD+Xk5IGl3eqAVh4ZPYVsJwutkW+Oq4fJiwNZb7Vy04ADqL5oLV06OfsnDoQppV5exhhBEuFPwS0m0Q/9pTT1dat2ZR5K8GNVEqBB0gLc7ILU5ZliMzudoWhtsL417pmDtkAQgUJ6RnX7G/jkxxzCoaDdlR9IkP2FlSSaSy/QnJCw7o/Kd+/SnBJ1IiVm/hN2mcTVGnAJUDg0mHIVmPVOzyaANGe4Vh9JJKiTHhw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(316002)(38070700005)(110136005)(54906003)(33656002)(55016003)(38100700002)(26005)(6506007)(7696005)(8936002)(5660300002)(2906002)(186003)(86362001)(52536014)(4744005)(71200400001)(122000001)(66446008)(66556008)(8676002)(66476007)(64756008)(66946007)(55236004)(508600001)(4326008)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ubx3hFEnLd9LLYIXaw2RM7Wxsy7sykl5n73Z7zoNhVg60qjSVXEH+wd3NKYs?= =?us-ascii?Q?BTFolobGzFN2RL8GSDm8oh5y3yqjcn3OYqWRkr+yK8UJJtebOAARS33jRNam?= =?us-ascii?Q?jhEn/yDZzdenqddGhktXNCHpElbhf9hLKZpNMMb9UNJ31DU2dC9ah/8p7Qrq?= =?us-ascii?Q?YIre0vF06KCrMeYffV7oxrz7E27BWLi3VxZByYmKPVcIHc2IB40yZ97LpBnO?= =?us-ascii?Q?JRDlJTgMvL9wfeSStwxGYeEZ+4x0VVZqIRXO5KCCHXrB8b6mCFWVjw0WP2Gs?= =?us-ascii?Q?aHbyQ/sgGmFob4Wqa/erQ3abRfa9XZWyWKO7xpeLpQ64CdvH66CFJDrwDpN0?= =?us-ascii?Q?7XeQuVnmarzOBUNpaLi/0cE/3E0xIE8Oy8fWTJp98Z0l7nVk1lqoElxQBKnn?= =?us-ascii?Q?itdbbxrLINeMOFJ6HNAgtkOuqCzfxaNyva0rswUkiBff61SXTrCQK5I4PY1q?= =?us-ascii?Q?F7RmJpeyjSxat+7It/CZ7LYmXPrxd9N/iMvsPSH4jo0qn6PGZZhO85EnrYf2?= =?us-ascii?Q?MkmPCuZUazs5l1/UmhsWdEWW/f5GY277lAyUsLAFAl5anVlSwAIeq9he78Or?= =?us-ascii?Q?GaZrIlTzFdRBxk2wAzNzCspRgkN9c4vRbzX/Zny/cwnaJS/ePYH92ijpenew?= =?us-ascii?Q?AD2WBM1TwUPmFacnVLC5lQL3qKaCAwIZG66LgSV+boevrjHlWROB7+mg3mJY?= =?us-ascii?Q?X9O3TpVwsFuze4yi8KVVbyaBNFA3V94ibGAyiOJqyzUO2rZjVw3/in0NHxAv?= =?us-ascii?Q?LkbCBjT3iIGw8dmGdPN+ZkH/PYtzqT14B0STSWTFys9qEweZae1Ndxu8nOTo?= =?us-ascii?Q?omqpFk4fXp0xxAzyMRl8Rtde9L7JqtrPm5nTIe7Ja99O1f7L/1kstvNJQwsX?= =?us-ascii?Q?jxG0C9CHvdrggjUURYBzl4gq54ESjKp600hE+tRsxtiygzPfzz9VFma+uBFt?= =?us-ascii?Q?ifzkiVpy03tAnH170D/OjqflODFI1NIMD0yCjsgtOtCYK9lEZ2NuXOVZxT9Y?= =?us-ascii?Q?fybjlTmAFYbEtfmc9Zi2WZn8hHDDVxxwkuQQ4hILNsRmWuYafbpKfvcZjdZu?= =?us-ascii?Q?T0+X9wFLu/GDWnamhdQhTuMqvZ7xPYyWp+uaySpP9QdW3DD6+IUxCOwzvz3N?= =?us-ascii?Q?2t9a1VT2rBBn8zkQf2KvWFejkBM1XI8eMIWR9kGxiBxn9lfvOusbMpq7e0/t?= =?us-ascii?Q?l0s4Z+vXdWRwo/IY7OQjYlhD7adavAZPXyYI8lXtk/yeKNOxf5FJdhq5KQ00?= =?us-ascii?Q?/ai52CNfy0RA8tMS8eRrrj4QbRa/7DhWQMudwBj6omFo+WxwsrzYToO2m4pI?= =?us-ascii?Q?B22hNSr3n/xbjUeC9Q2hzCJfEQDSsT5w0jwEXUYhS5brCc9o7j6GQEHawKKV?= =?us-ascii?Q?6u667L8PvJqYFmG+An0EmCcITDdBNbyZz3p/GsEpgteUyF8/mTzLrfa8uOKl?= =?us-ascii?Q?tGFNUbxAMefb9pfgd8JVCSvPtPcyr6Vvl802Vn3TJOyFlivuOqMD9qWf1R2b?= =?us-ascii?Q?SW+/CAkER5gPeptftjCOfsNPl95Yy9GmNT4ilxbQLEDHP7nDKYhlJOGKiYJp?= =?us-ascii?Q?8t5BvpZNrnMB0OoISLnk6HoYY8NC9nEHkJnxc9/ZkGI3CXIsZYJT0iP3uGyu?= =?us-ascii?Q?TPy3Cc+HujEq8Wa+mE2X4/8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d37c4408-ef47-4941-d254-08d9f24267bd X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 18:22:07.0955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jOhgTGVTMpgXVk9VvPEjxwA7Hz3OKqM9zf5c6cpf2abV25x8kPyqaBsv23GEYIbbLf4KJFIEZOTGHK7rGRILSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3131 X-Proofpoint-ORIG-GUID: tyrqx61aSGzDFQeNkOmzymVDlI0FAsLV X-Proofpoint-GUID: tyrqx61aSGzDFQeNkOmzymVDlI0FAsLV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-17_06,2022-02-17_01,2021-12-02_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > The qp is never NULL when it reaches the qp_setup_cleanup error handling > code. This is due to checks earlier in the function that return an error > if qp is NULL. >=20 > Coverity issue: 375013 > Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer > dereference") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power Applied to dpdk-next-crypto