From: Akhil Goyal <gakhil@marvell.com>
To: Raja Zidane <rzidane@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "matan@nvidia.com" <matan@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXT] [PATCH] examples/l2fwd-crypto: fix stats refresh rate
Date: Fri, 29 Apr 2022 10:04:45 +0000 [thread overview]
Message-ID: <CO6PR18MB448412D0D209D96CE9F69162D8FC9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220407114249.15024-1-rzidane@nvidia.com>
> TIMER_MILLISECOND is defined as the number of cpu cycles per millisecond,
> current definition is correct for cores with frequency of 2GHZ, for cores
> with different frequency, it caused different periods between refresh,
> (i.e. the definition is about 14ms on ARM cores).
> The devarg that stated the period between stats print was not used,
> instead, it was always defaulted to 10 seconds (on 2GHZ core).
>
> Use dpdk API to get CPU frequency, to define TIMER_MILLISECOND.
> Use the refresh period devarg instead of defaulting to 10s always.
>
> Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Thanks.
prev parent reply other threads:[~2022-04-29 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 11:42 Raja Zidane
2022-04-29 10:04 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448412D0D209D96CE9F69162D8FC9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rzidane@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).