From: Akhil Goyal <gakhil@marvell.com>
To: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXT] Re: [PATCH] test/security: fix buffer leaks in error path
Date: Tue, 19 Sep 2023 06:33:02 +0000 [thread overview]
Message-ID: <CO6PR18MB448468DE1A36E05903BA056FD8FAA@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <94858d65-2088-6108-6aa3-d1db94e92b84@oss.nxp.com>
> > +#define FREE_PKTS(j, m) { \
> > + while (j--) \
> > + rte_pktmbuf_free(m[j]); \
> > +}
> > +
>
> Changes looks good. However do you want to define a static inline
> function here instead of macro?
Any specific reason for changing to inline function?
In this case macro is as good as inline function.
next prev parent reply other threads:[~2023-09-19 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 17:33 Akhil Goyal
2023-08-25 11:22 ` Hemant Agrawal
2023-09-19 6:33 ` Akhil Goyal [this message]
2023-09-19 14:58 ` Stephen Hemminger
2023-09-19 19:17 ` [EXT] " Akhil Goyal
2023-10-31 6:44 ` [PATCH v2] " Akhil Goyal
2023-10-31 13:56 ` Hemant Agrawal
2023-10-31 15:47 ` Stephen Hemminger
2023-10-31 17:59 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448468DE1A36E05903BA056FD8FAA@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).