From: Akhil Goyal <gakhil@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
Radu Nicolau <radu.nicolau@intel.com>
Cc: dev <dev@dpdk.org>, Declan Doherty <declan.doherty@intel.com>,
"Hemant Agrawal (OSS)" <hemant.agrawal@oss.nxp.com>,
Anoob Joseph <anoobj@marvell.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [EXT] Re: [PATCH v2] examples/ipsec-secgw: fix potential build error
Date: Wed, 3 Nov 2021 13:45:34 +0000 [thread overview]
Message-ID: <CO6PR18MB44847026152872484565D304D88C9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8y2XQJr=VewNphuf-mJ2m2gTz3SVWjVNiN51-+p_6A=Ug@mail.gmail.com>
> On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > 03/11/2021 12:56, Radu Nicolau:
> > > When STATS_INTERVAL is set to a non-zero value the core_statistics array
> > > will be defined in multiple compilation units and this can trigger a
> > > linker error on particular environments. In order to fix this the
> > > core_statistics definition was moved out of the header file.
> >
> > So it is not fixing compilation,
> > as we would never apply a patch which would completely break
> compilation.
> > I would say (in the title) that it moves global variable from header file.
> >
> > > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet
> statistics")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
> I guess it has to do with series:
> https://patchwork.dpdk.org/project/dpdk/list/?series=20174
Yes this series initiated the issue, applying both the patch and the series now
On next-crypto
next prev parent reply other threads:[~2021-11-03 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 10:51 [dpdk-stable] [PATCH] examples/ipsec-secgw: fix " Radu Nicolau
2021-11-03 11:56 ` [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential " Radu Nicolau
2021-11-03 13:08 ` Thomas Monjalon
2021-11-03 13:36 ` [dpdk-stable] [EXT] " Akhil Goyal
2021-11-03 13:42 ` [dpdk-stable] " David Marchand
2021-11-03 13:45 ` Akhil Goyal [this message]
2021-11-03 13:50 ` [dpdk-stable] [dpdk-dev] [EXT] " David Marchand
2021-11-03 13:55 ` Akhil Goyal
2021-11-03 11:58 ` [dpdk-stable] [dpdk-dev] [PATCH] examples/ipsec-secgw: fix " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44847026152872484565D304D88C9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@oss.nxp.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).