* [PATCH] test/crypto: add missing MAC-I to PDCP vectors
@ 2023-01-24 16:39 Volodymyr Fialko
2023-01-30 19:26 ` Akhil Goyal
2023-02-01 14:09 ` Akhil Goyal
0 siblings, 2 replies; 3+ messages in thread
From: Volodymyr Fialko @ 2023-01-24 16:39 UTC (permalink / raw)
To: dev, Akhil Goyal, Fan Zhang, Nipun Gupta, Vakul Garg, Hemant Agrawal
Cc: jerinj, anoobj, Volodymyr Fialko, stable
Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL
integrity do not contain the MAC-I (32-bit of all zeros according to the
specification).
Vectors for other SN length (5, 18 bits) have the MAC-I set.
Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases")
Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity cases")
Cc: stable@dpdk.org
Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
app/test/test_cryptodev_security_pdcp_test_vectors.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_security_pdcp_test_vectors.h b/app/test/test_cryptodev_security_pdcp_test_vectors.h
index 6fdc4cd9e3..56d4884529 100644
--- a/app/test/test_cryptodev_security_pdcp_test_vectors.h
+++ b/app/test/test_cryptodev_security_pdcp_test_vectors.h
@@ -5560,7 +5560,7 @@ static uint8_t *pdcp_test_data_out[] = {
0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70,
0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C,
0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46,
- 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD},
+ 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00},
/* Control Plane w/NULL enc. + NULL int. DL LONG SN */
(uint8_t[]){0xA0, 0x00, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82,
0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71,
@@ -5568,7 +5568,7 @@ static uint8_t *pdcp_test_data_out[] = {
0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70,
0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C,
0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46,
- 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD},
+ 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00},
/* Control Plane w/NULL enc. + SNOW f9 int. UL LONG SN */
(uint8_t[]){0x00, 0x01, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82,
0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71,
@@ -5954,7 +5954,7 @@ static uint8_t *pdcp_test_data_out[] = {
0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70,
0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C,
0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46,
- 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD},
+ 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00},
/* User Plane w/NULL enc. + NULL int. DL for 12-bit SN */
(uint8_t[]){0xA0, 0x00, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82,
0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71,
@@ -5962,7 +5962,7 @@ static uint8_t *pdcp_test_data_out[] = {
0xC2, 0xE2, 0x91, 0x91, 0xA3, 0x9C, 0xE6, 0x30, 0x69, 0x70,
0x33, 0x8A, 0x15, 0xD0, 0x36, 0x47, 0x0E, 0x8F, 0xEE, 0x2C,
0x96, 0x0C, 0xD7, 0x7D, 0x70, 0x1B, 0x01, 0x7F, 0x96, 0x46,
- 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD},
+ 0x53, 0xB0, 0xA4, 0x7A, 0xF9, 0xDD, 0x00, 0x00, 0x00, 0x00},
/* User Plane w/NULL enc. + SNOW f9 int. UL for 12-bit SN */
(uint8_t[]){0x80, 0x01, 0x86, 0xB8, 0xF8, 0xDB, 0x2D, 0x3F, 0x23, 0x82,
0x53, 0xFD, 0x37, 0xDE, 0x88, 0x63, 0x08, 0x4F, 0xD3, 0x71,
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] test/crypto: add missing MAC-I to PDCP vectors
2023-01-24 16:39 [PATCH] test/crypto: add missing MAC-I to PDCP vectors Volodymyr Fialko
@ 2023-01-30 19:26 ` Akhil Goyal
2023-02-01 14:09 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2023-01-30 19:26 UTC (permalink / raw)
To: Volodymyr Fialko, dev, Fan Zhang, Nipun Gupta, Vakul Garg,
Hemant Agrawal, Gagandeep Singh
Cc: Jerin Jacob Kollanukkaran, Anoob Joseph, Volodymyr Fialko, stable
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
> Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors
>
> Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL
> integrity do not contain the MAC-I (32-bit of all zeros according to the
> specification).
> Vectors for other SN length (5, 18 bits) have the MAC-I set.
>
> Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases")
> Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity
> cases")
> Cc: stable@dpdk.org
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 21871 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] test/crypto: add missing MAC-I to PDCP vectors
2023-01-24 16:39 [PATCH] test/crypto: add missing MAC-I to PDCP vectors Volodymyr Fialko
2023-01-30 19:26 ` Akhil Goyal
@ 2023-02-01 14:09 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2023-02-01 14:09 UTC (permalink / raw)
To: Volodymyr Fialko, dev, Fan Zhang, Nipun Gupta, Vakul Garg,
Hemant Agrawal
Cc: Jerin Jacob Kollanukkaran, Anoob Joseph, Volodymyr Fialko, stable
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
> Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors
>
> Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL
> integrity do not contain the MAC-I (32-bit of all zeros according to the
> specification).
> Vectors for other SN length (5, 18 bits) have the MAC-I set.
>
> Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases")
> Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity
> cases")
> Cc: stable@dpdk.org
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Applied to dpdk-next-crypto
Thanks.
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 21875 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-01 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-24 16:39 [PATCH] test/crypto: add missing MAC-I to PDCP vectors Volodymyr Fialko
2023-01-30 19:26 ` Akhil Goyal
2023-02-01 14:09 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).