From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7510A00C4 for ; Fri, 1 Jul 2022 20:31:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E30740A7B; Fri, 1 Jul 2022 20:31:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6C54240A7B; Fri, 1 Jul 2022 20:31:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 261Dk8Tp025905; Fri, 1 Jul 2022 11:31:12 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3h17nq70pq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Jul 2022 11:31:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYfSxVkNlSrxH3NQupgt0WL8NXii0HjBIdSfL4KO/QbSehc1PYnDVVWuHTBrre8NH5mruK7qM/rB0GMKP9sxOkUAPFhe6bQYmFnnjgsAxpMHSJOD/n2sm1Mn4ai66+jjmMvOlQP2PzAVhuc6iYxtBAjpsKL6QVmjqT6nrHgsXxypvzMyZiXbxTql8dyIFKBQdAc+zXUBgGoECdEWyle6p9vFXBkKXjnY4q6DH2xpCLpXJDaaH4jGJ+xWXpGH6QqRO6/khE4zcVcuCpy8sJa5XsyjDk9LQ3JFEN2euHXh1vyF5fqosMCceMC9vJXPSCg3EdkBQDkP/3bWbYKQ53jKRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EgO7oc/HQ7RNssRno12Du4OBeNsCKCHgvR4iPZjm/bo=; b=RdR6NmIuQYdNMbpBOX8//C41AskpF6zbpr7FgzA2tFkXGygKeWXd2834jvrwPr+jeueqs08x2bpMkFpU/9iBC8zRcg6r/zg9sqeKmx+TGyF8YFcyo1opMsjmyKRDQdeKrDveBIfqZPLpEy2p4DcCoMerOPUsGWEG2+U7yqiffgCXbUO82NccjUsVZ01mTBX19RhcVZlPEZp1v6QANlQiuqbSoc+YALFCHC4Y7h8+8/xh8on3OJ90iYWs90wSMHaCgeFNhulGO3yfnxedfwqPw3A425moo9nMWim1HzHaYSpg4cOWbICovqmzBg3cjaSIVVTeK4x61Z8f0PUjLkL7kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EgO7oc/HQ7RNssRno12Du4OBeNsCKCHgvR4iPZjm/bo=; b=UeZz1Vi8zbpApD+EuIvdWvbkLoIeC2zibg3Bh2aZhhJ1mAEV4+x5jSPrfHNmS0GxlmpEI6YbVTmHLXUlYUABZVpEFL5fpYSft0FosA6ag/0os+zdylPiQEGUjlsNvs68LRP+dk4EkEDV7clKGAVpS6dvRRUZr4BkQ6PLQjY6ydo= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB3849.namprd18.prod.outlook.com (2603:10b6:a03:2e8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 18:31:10 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::bc33:1fb9:5d70:8c5%9]) with mapi id 15.20.5395.017; Fri, 1 Jul 2022 18:31:10 +0000 From: Akhil Goyal To: Rebecca Troy , Fan Zhang CC: "dev@dpdk.org" , "kai.ji@intel.com" , "stable@dpdk.org" Subject: RE: [EXT] [PATCH] crypto/qat: fix secure session check Thread-Topic: [EXT] [PATCH] crypto/qat: fix secure session check Thread-Index: AQHYjSiW7K3nBBwJbU+UbeQjS4veYK1p1uAA Date: Fri, 1 Jul 2022 18:31:10 +0000 Message-ID: References: <20220701085707.246099-1-rebecca.troy@intel.com> In-Reply-To: <20220701085707.246099-1-rebecca.troy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5188b589-f9f5-4206-bfec-08da5b8fdebb x-ms-traffictypediagnostic: SJ0PR18MB3849:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NvPS+o+xCYR3ANIb8cTAn3/LRpdwKBVGeyuFT3u2IDAcfkkrGEQ3MPzUkzMKnxSBPFPciLqQFnB2JG0WLZCoazGy2hdrZE0Zxxz7jyH8843Nf3O8RahKOejc2X2I3ookhH51eSqTqWuma18HWE0/7lXTnKhKikOTB5/LLOQ1nEAXxV5JGW+obBRWJEng3OJUplIzp0y4na87DubbpNvjam33UYRKK5W2Pfw2J6nDsbgZ2AkxmmkP74Pl0akJl0lGzshDIOis5ExSy6v+/EscuOof8LKh113z4uSnW9xoZp2Z/pdo6NIIVm4rsdU39YwHhPMmdLC9QKXsfmjApKefXj0S9sA6xzamNhXur3+q7m0oPDbG/4nwklChUjIlck5S0BBJ3iVb8BLZP1Ycs7go0TTM2KnKPdgCmZwr6asen2Fw4WTZHIdsRYUf7kfLqjoSR4lCuqaG6xX4kvmfCiKxCx+xMbW4FVXK9JsxECYBFevcmHc4YnTgBSp+WN3Oo4mBWEuPwGANPfkxDCWko8wee4ARazUi7pK5BCdIoHxWbT7+t/BVbY4HfK8mWLQEF1P6AIfsi5aZ2LNgxHxv70NpkD1ynYzM0kqsTHj4nEAQZiDaaQtaYBsXYtixGwgFJrxTSkjQSmqYfmCPQYxhyy1Fjwc7dbMJQPrip17qNuA2oFVSmg5pjgNEgGjoCfqS3yB/1aP2nQWtAK2akxXI725o0QufmlpuHevl+nMYa4wtzR2NiYJycNPJS8WWi2EKvUZYw+233BERnaxDqnfn4cZ8Xy5Yhj4Von78NdsU7SjNKS4vHKEdcMHKGANAqmOLDvUQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(54906003)(2906002)(41300700001)(110136005)(33656002)(38070700005)(5660300002)(55016003)(122000001)(316002)(52536014)(478600001)(8936002)(186003)(26005)(83380400001)(86362001)(6506007)(9686003)(71200400001)(55236004)(7696005)(38100700002)(76116006)(64756008)(8676002)(66476007)(66946007)(66556008)(4326008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6NLMwk3hjLtRzsUPoZ9JAgZPxNnpUHEt+OgmLmcZodzIE7o1oPr3X9xKkZ+g?= =?us-ascii?Q?mNmxvWCYFOxb4uOH1XFBycpvk7TzW16+Fib88UbpqPvie8Aqb+TDtuySb0JN?= =?us-ascii?Q?OSZP/aELAHYRtIRlQogYAkZ7kf3QoS9K5Tjc14LXAwAAmNRw/a4eHF2PvA4l?= =?us-ascii?Q?Vm5y5ypgRQ7bL+3Q0z5eB+5MKM3k9qedIIMggmmeWO9YLff2dcMQeddfWDdB?= =?us-ascii?Q?GMuSblYERfISsnUD/oDfR40D+SPANV8N/3IrYtU4103VUDkkitP7IrjjdlJs?= =?us-ascii?Q?nN38EMIe/MNRO29pk7Jm8kvHFP1kXDGBroJjabVRjnmlHGXeLfcjUGytJb+m?= =?us-ascii?Q?9lFrdtvwmsLR41pZx4RiFEAYjqkEoSKPQ6R9bY/ad0RHx3K7KDS1tYrL4nG9?= =?us-ascii?Q?5erceshKKQ9qvaC6uZgbhJ5SZWoNwnIqPBrcGZUbDolIPH3qXPsKcGkBY/6l?= =?us-ascii?Q?uEf8EI3qnSE+/GjWHdYw7Xa9/9qCw20qpXlOlUNoUQ5kJKlAqCCB/b/FfoZJ?= =?us-ascii?Q?b0yK4l0OdPU/IXaFhWg0uUu7Darebz8E6vV8X4IL+xwbntS28ffliDx5rPeg?= =?us-ascii?Q?l92MsSdjMrYaQXDPhvLUbM0yaVy+6BPe/DGPuTPdJjliE7wt7chjrct2pFSd?= =?us-ascii?Q?dIS+81ddblcDuqootRFefWUZVk2d1d0EE7h4UzKhsGh8WVjVAaOqB2vU7zLA?= =?us-ascii?Q?WKe6zruz3pBkQAlMYzEJFY4YBaLbc4vM501JM7f468YPxz85N4c7UOMHn8HA?= =?us-ascii?Q?SWWvXNOVuQIUYkPzBiEcW+eQ4CFTlDenLyTFCnK1M30XkYpIt1QJ7OfOMVuJ?= =?us-ascii?Q?SWobmwok8ZpcHkHr9xcFB5BdZWTLOiHh/p9kNsWOv8SOZwuwgT0JV947uVCd?= =?us-ascii?Q?TqYF9LjYpMQL/57lL90bJaOxrnSLRUdfVagULoDpa+AZ+gvVCNile7zM2eIr?= =?us-ascii?Q?ZyviJ1ZDNT8ccn7MWqCcpOGYO786AGD8+9AljkNKomnTTc6oqHBE1F6DJN6y?= =?us-ascii?Q?DnraA/g2C9pGzk+uRELeRgAoCzVB8cNYySP4KFsFAOdPpaSw87Rl0hftxp9r?= =?us-ascii?Q?wI9TzmTfFDkfD3opKoSacJ+1NRmCzHI6ychWKCk6BTXQE97ydsmJ81HWQ5+z?= =?us-ascii?Q?AkS5ss9o0pC7SH0vB4heVR9ax1uMos7JuqmZpVggGgu/JlNkY7Ml7w1ln0tL?= =?us-ascii?Q?QEjEshaQzK6QFb4ujS0rfkpG2372gMTLEey5ugXPP2VryrF+J4Ccf/d368iz?= =?us-ascii?Q?naRurLjG+imMTL1KcSNYsaLci1c5gaZ4j3e5p9PwTiOSAFn//YuirWnhzxEo?= =?us-ascii?Q?1P6NdF8crPD1fM55ivbQwSNTYoA/TrDFwNacZhae5BrFvJz8wNpM5ijrbo7H?= =?us-ascii?Q?Q2NobWwu07xYC5KCedBkQE8N1UebekdUDS0jBUkVwry4axqR8dc/l6GnW0Gs?= =?us-ascii?Q?uKYz3ieRokoLl74hEZJYVf5bySEusHbVMaCdq9YHRpSCI8QTKOSarbUcIMBq?= =?us-ascii?Q?WogmaiAPimfMeWt5z7hbJY2NRwvaOLLQocsh4PZamZVFjeaJ2NaSc1f2XhWu?= =?us-ascii?Q?utGKQl+DrZMqqh5cKaSq172OsLwd4gHQOqPCQ2Xn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5188b589-f9f5-4206-bfec-08da5b8fdebb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2022 18:31:10.1487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zliELXPHZTktyjM7DeOSKG2ZMuEmw7khqSntyTEJaxN3tfakyl+voesBFxYOMBTO6FZT6VEVKaiCGOh8D0Ojeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3849 X-Proofpoint-GUID: GLgJL2rwWF_7DASWZVGP00BXa0N8IcvY X-Proofpoint-ORIG-GUID: GLgJL2rwWF_7DASWZVGP00BXa0N8IcvY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-01_10,2022-06-28_01,2022-06-22_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > Currently when running the dpdk-perf-test with docsis > security sessions, a segmentation fault occurs. This > is due to the check being made that the session is not > equal to op->sym->sec_session. This check passes the > first time but on the second iteration fails and doesn't > create the build_request. >=20 > This commit fixes that error by getting the ctx first > from the private session data and then comparing ctx, > rather than op->sym->sec_session, with the sess. >=20 > Fixes: fb3b9f492205 ("crypto/qat: rework burst data path") > Cc: kai.ji@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Rebecca Troy > --- > drivers/crypto/qat/qat_sym.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c > index 3477cd89ad..e5ae670b3a 100644 > --- a/drivers/crypto/qat/qat_sym.c > +++ b/drivers/crypto/qat/qat_sym.c > @@ -105,16 +105,16 @@ qat_sym_build_request(void *in_op, uint8_t > *out_msg, >=20 > #ifdef RTE_LIB_SECURITY > else if (op->sess_type =3D=3D RTE_CRYPTO_OP_SECURITY_SESSION) { > - if ((void *)sess !=3D (void *)op->sym->sec_session) { > - struct rte_cryptodev *cdev; > - struct qat_cryptodev_private *internals; > - > - ctx =3D get_sec_session_private_data( > + ctx =3D get_sec_session_private_data( > op->sym->sec_session); > if (unlikely(!ctx)) { > QAT_DP_LOG(ERR, "No session for this > device"); > return -EINVAL; > } Fix formatting of above if check. > + if (sess !=3D (uintptr_t)ctx) { > + struct rte_cryptodev *cdev; > + struct qat_cryptodev_private *internals; > + > if (unlikely(ctx->bpi_ctx =3D=3D NULL)) { > QAT_DP_LOG(ERR, "QAT PMD only supports > security" > " operation requests for" > -- > 2.25.1