From: "Robin Jarry" <rjarry@redhat.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
"Ciara Power" <ciara.power@intel.com>,
"Keith Wiles" <keith.wiles@intel.com>
Subject: Re: [PATCH] telemetry: reset data before passing it to callback
Date: Wed, 08 Feb 2023 13:32:53 +0100 [thread overview]
Message-ID: <CQD6MZWBN9CG.22GCOHD5VFVGM@ringo> (raw)
In-Reply-To: <Y+NlRBeHqJjvhWFj@bricha3-MOBL.ger.corp.intel.com>
Bruce Richardson, Feb 08, 2023 at 10:03:
> This is also fixed by patch http://patches.dpdk.org/project/dpdk/patch/20230120033456.29710-3-fengchengwen@huawei.com/
>
> While both work the same way, I think I prefer the fix to set "= {0}" on
> init rather than explicit memset.
Oh I had missed that one. Any of these two patches should be applied and
backported. Feel free to take the first one that was sent :)
As I said in the commit message, it can cause the whole application to
crash. It may also expose data from other telemetry endpoint handlers to
other handlers, I don't think this can be considered as a security issue
but I may be wrong.
prev parent reply other threads:[~2023-02-08 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 18:45 Robin Jarry
2023-02-08 9:03 ` Bruce Richardson
2023-02-08 12:32 ` Robin Jarry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CQD6MZWBN9CG.22GCOHD5VFVGM@ringo \
--to=rjarry@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).