From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B32E41C3F for ; Wed, 8 Feb 2023 13:33:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 902C342B8C; Wed, 8 Feb 2023 13:33:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C4F354282D for ; Wed, 8 Feb 2023 13:32:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675859578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ozah0EHPTLCQOe6Nwt4E2xFbxlRghzNXzk/9/fRcGt4=; b=XotyuSCAVrPv1nweJM7/gLWjBwecFES5vhmEH2SE+xMEv3vMsbrE0KQkGJ/sfxLW6lZWx8 AZY4MQRHXbzOaGYUwQ0RuxhDlaJcZqPSgkNOObl4n31xLmzInh/hCvsbGp2gDQ/m8uL1TD bcMfM3z6g8n5zv9gkNdTq3CbuGdWQ+M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-3-08UcyYuoPayXAvau013qXw-1; Wed, 08 Feb 2023 07:32:55 -0500 X-MC-Unique: 08UcyYuoPayXAvau013qXw-1 Received: by mail-wm1-f70.google.com with SMTP id p14-20020a05600c468e00b003e0107732f4so2931146wmo.1 for ; Wed, 08 Feb 2023 04:32:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ozah0EHPTLCQOe6Nwt4E2xFbxlRghzNXzk/9/fRcGt4=; b=S6sKe1N0+W+UOifa2O2LJjSQz+CBWbhPQxOVgGptQcZj+qWH+lD3PYsm/nF+6A/fmr 7Ejav2SXVAq0Zccys+XXH+Lw2oRmMz6bwhcLQkhbqOzLINXfXgpKBMFcez30LJQE6xq6 xF1JV5l1oASgMFeXMYMFHyFOj/U1b3EtG70NJUKvHAMtgB7pODxGLDXjlQroV+nxOmpU cAJrMgI+32gAow8BBZVDA5CcIxD7k8WBApgGJYcWLB8F11PwkCMVqt+Vbuo73AXnDTaU ZxXpba2a7kVZQ6+azHdg1NrQmCeECePoqzTwoFxS7yas5K1+tKYkYi2e7E8WRr8IaNhg mT4A== X-Gm-Message-State: AO0yUKXDlO4FU2mG7vSm/8DR3Vl2Akm5+zQ/PbOJezJZc4Tmr39xP9N6 C8ZtagAImruIpIcIX0+aa/YEcafjNRUa2d4WWjIsj3jIpBRLIov4GEDulHw43v/kEROgg1+PaDK L+ou5UlQ= X-Received: by 2002:a5d:4590:0:b0:2bc:8130:ccb8 with SMTP id p16-20020a5d4590000000b002bc8130ccb8mr6519816wrq.40.1675859574863; Wed, 08 Feb 2023 04:32:54 -0800 (PST) X-Google-Smtp-Source: AK7set8nEPKpcPm6gtR2CxTd8OQxrFbSmaxfZbSWBGrn+dCfywcxVYfZ4fAbqAHF6jL1zKr6Z9CLSg== X-Received: by 2002:a5d:4590:0:b0:2bc:8130:ccb8 with SMTP id p16-20020a5d4590000000b002bc8130ccb8mr6519808wrq.40.1675859574713; Wed, 08 Feb 2023 04:32:54 -0800 (PST) Received: from localhost (2a01cb000f483e0055ae3800781b5cbc.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:55ae:3800:781b:5cbc]) by smtp.gmail.com with ESMTPSA id o10-20020adfa10a000000b002bfcc9d9607sm13923777wro.68.2023.02.08.04.32.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 04:32:54 -0800 (PST) Mime-Version: 1.0 Date: Wed, 08 Feb 2023 13:32:53 +0100 Message-Id: Cc: , , "Ciara Power" , "Keith Wiles" Subject: Re: [PATCH] telemetry: reset data before passing it to callback From: "Robin Jarry" To: "Bruce Richardson" X-Mailer: aerc/0.14.0-67-gad730ab991d9 References: <20230207184520.1238366-1-rjarry@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Bruce Richardson, Feb 08, 2023 at 10:03: > This is also fixed by patch http://patches.dpdk.org/project/dpdk/patch/20= 230120033456.29710-3-fengchengwen@huawei.com/ > > While both work the same way, I think I prefer the fix to set "=3D {0}" o= n > init rather than explicit memset. Oh I had missed that one. Any of these two patches should be applied and backported. Feel free to take the first one that was sent :) As I said in the commit message, it can cause the whole application to crash. It may also expose data from other telemetry endpoint handlers to other handlers, I don't think this can be considered as a security issue but I may be wrong.