From: "Xu, Ting" <ting.xu@intel.com> To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue Date: Wed, 22 Jul 2020 08:30:41 +0000 Message-ID: <CY4PR1101MB231015070338C942BE9013D5F8790@CY4PR1101MB2310.namprd11.prod.outlook.com> (raw) In-Reply-To: <BYAPR11MB2935565CF64827508D474F16EB790@BYAPR11MB2935.namprd11.prod.outlook.com> Hi, Cristian, > -----Original Message----- > From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Sent: Wednesday, July 22, 2020 4:27 PM > To: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue > > > > > +#ifdef RTE_ARCH_64 > > struct rte_bucket_4_32 { > > /* Cache line 0 */ > > uint64_t signature[4 + 1]; > > @@ -46,6 +47,22 @@ struct rte_bucket_4_32 { > > /* Cache line 3 */ > > uint8_t data[0]; > > }; > > +#else > > +struct rte_bucket_4_32 { > > + /* Cache line 0 */ > > + uint64_t signature[4 + 1]; > > + uint64_t lru_list; > > + struct rte_bucket_4_32 *next; > > + uint32_t pad; > > + uint64_t next_valid; > > + > > + /* Cache lines 1 and 2 */ > > + uint64_t key[4][4]; > > + > > + /* Cache line 3 */ > > + uint8_t data[0]; > > +}; > > +#endif > > > > Hi Ting, > > Yes, it looks good, but as mentioned previously please do the same on the > other files in the same folder and add the changes to your patch, as we need > to keep all these files in sync: > > rte_table_hash_key8.c, struct rte_bucket_4_8 rte_table_hash_key32.c, struct > rte_bucket_4_32 > I have did the changes to 8 and 32 bytes in this patch. > Thanks, > Cristian
next prev parent reply other threads:[~2020-07-22 8:30 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-16 16:27 [dpdk-stable] [PATCH v1] " Ting Xu 2020-06-17 5:43 ` [dpdk-stable] [PATCH v2] " Ting Xu 2020-07-02 8:06 ` [dpdk-stable] [dpdk-dev] " Zhou, JunX W 2020-07-09 1:48 ` [dpdk-stable] [PATCH v3] " Ting Xu 2020-07-20 14:37 ` Dumitrescu, Cristian 2020-07-21 5:15 ` Xu, Ting 2020-07-21 21:16 ` Dumitrescu, Cristian 2020-07-22 2:16 ` Xu, Ting 2020-07-22 2:16 ` [dpdk-stable] [PATCH v4] " Ting Xu 2020-07-22 8:26 ` Dumitrescu, Cristian 2020-07-22 8:30 ` Xu, Ting [this message] 2020-07-22 8:49 ` Dumitrescu, Cristian 2020-07-22 8:48 ` Dumitrescu, Cristian 2020-07-29 12:01 ` [dpdk-stable] [dpdk-dev] " David Marchand 2020-07-29 13:13 ` Dumitrescu, Cristian 2020-07-29 13:28 ` David Marchand 2020-07-29 13:54 ` Dumitrescu, Cristian 2020-07-29 13:59 ` David Marchand 2020-07-29 14:53 ` Dumitrescu, Cristian 2020-07-30 6:57 ` Xu, Ting 2020-07-30 10:35 ` Kevin Traynor 2020-09-09 6:18 ` Xu, Ting 2020-09-15 8:03 ` David Marchand 2020-10-14 8:26 ` Xu, Ting 2020-10-14 13:53 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CY4PR1101MB231015070338C942BE9013D5F8790@CY4PR1101MB2310.namprd11.prod.outlook.com \ --to=ting.xu@intel.com \ --cc=cristian.dumitrescu@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git