From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5896A0A01 for ; Wed, 6 Jan 2021 16:17:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A67D61609A2; Wed, 6 Jan 2021 16:17:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 5020F160946; Wed, 6 Jan 2021 16:17:12 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 106FASFd019835; Wed, 6 Jan 2021 07:17:11 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=aP1MdIy0+e8bSkAQN+bKgjjw4cWzyKZHQv2gnpJvRQo=; b=ZShZyiulacHyDWC0S7KTqWzv3GP+OJXXKuom5AdMS0aSnWA/2I7VCUXTRfZHRAAu7m9a dtbCH89fbNKKoj1WDZ/WWp8sBbB6NBa5fsUY3x+0M6di8d8ntiuXNfXRf9/GNDt1m5rf rc6yUOaOj7Tayvw8KymoGneNEmV6NR2MDUhnaBLffWYq9Z8XGYON5KZM6XMBOCNJZ5WY hP8gc9JwfKO/RHF6/YIoAkEEHeQpHW+7L12Nd1+HesQMAV2cpCqSFW0fPcJ0Gi4G/IT/ IJAIgR+ay2bmNVBQIApj8FmpHkmSsY1phBXbNY7XnGRwGnrLF+tfhWdytCcS45h0TitY Bg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com with ESMTP id 35ts7rsmbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 Jan 2021 07:17:11 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 07:17:09 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 07:17:08 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 6 Jan 2021 07:17:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bDDeGS/l/llkpnbzIsN+L1SgI4korh/lHCWLa3IlBQ0wssLxpPRI6FB7pOVEhqEwhWpzQsPwR5Q+UQNqeQXCuAWa+3X8pJyc0NFMLOHDsKBqfKLk0148MUJBdbH0Y6NVfdHR8GBZiMwBoAR+GrYzZgZC64upEQxl9lJNHqmhw/yckSyNKIt7NmUHia4qafxRKi0S36OjoR96gh1uHTbTl5KIX0qgUzaZqlcGzA747ov7LBygIckx9a4MDCJQn10DX9k82aJhJLdutmTkA+iWb+00ztKupNvIN+voCajCYwAkHcB+jHseqS+/mzu/ldYWNl7pBMKlCNzKi6jyPMZbew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aP1MdIy0+e8bSkAQN+bKgjjw4cWzyKZHQv2gnpJvRQo=; b=kYk8WLm8rChZDH4bRTh4IR8A01HZOjU36YU8Plemyenka1QVbn+F9oPXyKp4DRXqEkRN6w084LYhBxUdo2zX+ChROfdHA/DZ19JMoWgXMw8DhP3KBi5tY2sSZJX47E1UEa/sG+d/SSEOtmGpyPkyYlI588hX1Zg6ehiOur7d8oBvjJKfyoRyK/JKG9PHe1FP07thv7KzhCqBJ13zUvvgf+KPyDOUnPQbWMW+FL8bI8Vp0V7SMkr63QdGzxHYK6IoUgo2TrvU0gkTrO0UdIU7Yo5UPhTfG4rqOsMwZVdnVaOKXirwA0cglcnIxV/+NCrpFOaUk+X7nvHpv6x7ya/91Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aP1MdIy0+e8bSkAQN+bKgjjw4cWzyKZHQv2gnpJvRQo=; b=EffB+AFBH+Y1adVoDS8EtH3i9wUj0nB2nkBvyEWH1F7Mldc4pdDfK8MMxW8Tfb/MIODq/nGJS7pCGwHVOxnQAjZI/ShRRnbZVfX4NzESVL0c/U7gkaakvn5+XFrKreLlk1KWxAoFztPTk/vaa9uPieepRVHGoEtiqUvyCSDGCVU= Received: from CY4PR18MB1496.namprd18.prod.outlook.com (2603:10b6:903:149::8) by CY4PR1801MB2039.namprd18.prod.outlook.com (2603:10b6:910:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.22; Wed, 6 Jan 2021 15:17:07 +0000 Received: from CY4PR18MB1496.namprd18.prod.outlook.com ([fe80::d9ed:bc20:6693:bc6b]) by CY4PR18MB1496.namprd18.prod.outlook.com ([fe80::d9ed:bc20:6693:bc6b%11]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 15:17:07 +0000 From: Devendra Singh Rawat To: Devendra Singh Rawat , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "ferruh.yigit@intel.com" CC: GR-Everest-DPDK-Dev , Igor Russkikh , Rasesh Mody , Manish Chopra , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/qede: change driver's default load parameter Thread-Index: AQHW5C6wXHg2dgGOXkSORGnl1/OsnqoatUrg Date: Wed, 6 Jan 2021 15:17:07 +0000 Message-ID: References: <20201203133023.4060250-1-dsinghrawat@marvell.com> <20210106132007.197468-1-dsinghrawat@marvell.com> In-Reply-To: <20210106132007.197468-1-dsinghrawat@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [117.223.89.164] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7b15ca3-3d38-4963-cecb-08d8b25621a3 x-ms-traffictypediagnostic: CY4PR1801MB2039: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NXDNEdGlMnviXIz65Xsg+q7sjr+AbW6eX7tWgun5dFwMNmVueLg1MpZKNhCmpywEesmeY8/zhZ2Dlb6DT+zWgrw9mYGBkGCUY2MgXHlP5rVo3hdzRssd87fLL0hF756NoAKRECIDGH7eT4qIwEFzuWduIiQcSCmPlKwXtx55slpBE5VVPs0stlfjHTqBSxhy7DENqzbdUA9KJeQmIHSLz40qX19Jo3sThy6AlkOy6+fMFEV9tt06ny1z+uB+0BdLj7R1SW5e5v/wdpHlMvWrmQYLaQpwXLNnUngSdk/TL9GAx7n4/KO8kDOooS7+4NTrg2NsaQKC+Y+CWtQpLgVIYdmWnS1Gwdt8zmB2U4xtdaVxU1uhh1K2Go69kpMmOLmdAhEdA3CiPmWgr1P6OWREPg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1496.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(86362001)(9686003)(316002)(33656002)(66946007)(76116006)(64756008)(4326008)(52536014)(83380400001)(8936002)(66476007)(55016002)(66446008)(66556008)(5660300002)(2906002)(478600001)(26005)(6506007)(7696005)(53546011)(71200400001)(54906003)(186003)(110136005)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?+hZWsM8Ho1FfdG/lH4eXv4YTCfN/IQDThBFxDuFrD0Ck/6noaqt7mQNzibWj?= =?us-ascii?Q?HOC1cOuvN+8pGyhi+4I7w+yJS+csdCKpfyCdYafyJn9/2vXa36Bi6h0NCgid?= =?us-ascii?Q?VnidZbeg1cnqlyh3YwS89rvLoisTIRR4Sv/xDuxpHHwXqVvow/OzzUkcBk0o?= =?us-ascii?Q?4kzR+v5stQ/3jtHm1NhEEreXtxnkw9czJ1/F0XOUlI9AmXXfEkE0kXESNS2L?= =?us-ascii?Q?NfgkxA6EHT0C8WzielyhFyHgwdG21q7fhigjAD0ihnFRGtR/6rv3rk4lfdYC?= =?us-ascii?Q?V0RgaVOXPG/aHkvf+GhVzy/c50gCp7H5iBEed44exFIf8EH/tHCiB+jBotnW?= =?us-ascii?Q?x5uiUOO3amichQ4s7c6rniknA7Esq25S1PBA7bhxSlY2IfLAOkyMkgxz3zkJ?= =?us-ascii?Q?bzzUd4oSsuWP8Xj6pTr1eH2/zl7HLO0aUaJX0Z59eF1+q9r/9tGQmlqa+PTq?= =?us-ascii?Q?070KhRxfxJ3CTGLwN/HgJxfwNyfi47UqXfh5MukxPAaJc3LscDziYE0vEXAg?= =?us-ascii?Q?xUgnPi1s5A0HbvVjBCH0cj8znl/gAsKbGIcUqcyMfQ1QXQadtjG1T5d56EhW?= =?us-ascii?Q?v3P6SYQ5WQCcTYe7ya9bwxWU/1zTaYMbiwm+ktMrhJSDXB4iZQ2FDcjeDOQ5?= =?us-ascii?Q?Ed/safg/FMNRb+T1gcZHrjZT2qaC+JwoMJL8MCULG3/rX7gewk06ON4d908R?= =?us-ascii?Q?WafThWPtnogQfTU0uCncKi90ehBKfTWHcWH1pMos6f5AGMaHS0DXPhdxILdy?= =?us-ascii?Q?kBnnS7R0h/kzNpUF4QLamS9T7gpDDDNjebp27HcPVJG0aj8oBhLq/45+j8FA?= =?us-ascii?Q?/AAdSG/kmVdlg98vvsCRr2hdxUogtqCgxN6WRwhwkDkuUNPpKmxdRcMbp9nT?= =?us-ascii?Q?ta3NFOd36xXD43fNfv+xmzCK57ukvaiFFtRXf9htYao87HAQ8MR0+DZlJKp/?= =?us-ascii?Q?TEVgeQk4M/As5VkdHpraXBlcLTxE5dY8qFvJJDj1fr8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1496.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7b15ca3-3d38-4963-cecb-08d8b25621a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2021 15:17:07.2560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k310Ib7xl7bxGsJg4MMR0iQRCcZp5ViGGIZ8vsq8Mp0V1ZDO4ngBHwBmG6CLEEW6DfYUVQ5Mp78D4TenM9UPvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2039 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-06_09:2021-01-06, 2021-01-06 signatures=0 Subject: Re: [dpdk-stable] [PATCH v2] net/qede: change driver's default load parameter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Devendra Singh Rawat > Sent: Wednesday, January 6, 2021 6:50 PM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > ferruh.yigit@intel.com > Cc: GR-Everest-DPDK-Dev ; Igor > Russkikh ; Rasesh Mody ; > Manish Chopra ; Devendra Singh Rawat > ; stable@dpdk.org > Subject: [PATCH v2] net/qede: change driver's default load parameter >=20 > Loading ecore clients (PMD or linux kernel driver) having different ecore > versions concurrently, is problematic from device's init/config perspecti= ve. This > fix changes driver's default load parameter to have ecore version validat= ed by > MFW. All ecore clients having matching ecore version should be allowed to > load, otherwise MFW should fail the load request. >=20 > Fixes: c5e1108920 ("alter driver's force load behavior") > Cc: stable@dpdk.org >=20 > Signed-off-by: Devendra Singh Rawat > Signed-off-by: Manish Chopra > Signed-off-by: Igor Russkikh > --- > doc/guides/nics/qede.rst | 5 ++++- > drivers/net/qede/qede_main.c | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index > bb127ca21..201678401 100644 > --- a/doc/guides/nics/qede.rst > +++ b/doc/guides/nics/qede.rst > @@ -63,11 +63,14 @@ Co-existence considerations > - When SR-IOV is enabled on the adapter, > Linux kernel drivers (qed, qede, qedr, qedi and qedf) can be bound > to the PFs of a given adapter and either qede PMD or Linux drivers > - (qed and qede) can be bound to the VFs of the adapter. > + (qed and qede) can be bound to the VFs of the adapter provided that > + ecore version of Linux kernel driver and qede PMD driver is same. >=20 > - For sharing an adapter between DPDK and Linux drivers, SRIOV needs > to be enabled. Bind all the PFs to Linux Drivers(qed/qede). Create > a VF on PFs where DPDK is desired and bind these VFs to qede_pmd. > + Make sure that ecore version of Linux Driver and qede PMD driver is > + same. > Binding of PFs simultaneously to DPDK and Linux drivers on a given > adapter is not supported. >=20 > diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c > index caa9d1d4f..d208d276a 100644 > --- a/drivers/net/qede/qede_main.c > +++ b/drivers/net/qede/qede_main.c > @@ -300,7 +300,7 @@ static int qed_slowpath_start(struct ecore_dev *edev, > memset(&drv_load_params, 0, sizeof(drv_load_params)); > drv_load_params.mfw_timeout_val =3D > ECORE_LOAD_REQ_LOCK_TO_DEFAULT; > drv_load_params.avoid_eng_reset =3D false; > - drv_load_params.override_force_load =3D > ECORE_OVERRIDE_FORCE_LOAD_ALWAYS; > + drv_load_params.override_force_load =3D > ECORE_OVERRIDE_FORCE_LOAD_NONE; > hw_init_params.avoid_eng_affin =3D false; > hw_init_params.p_drv_load_params =3D &drv_load_params; >=20 > -- > 2.18.2 Dropping this patch for now, please ignore this. Internal discussions are going on regarding this patch. I will send a new = patch after the discussions. Thanks, Devendra