Re: [PATCH v6 2/2] bus/pci: fix secondary process save 'FD' problem

[Chenbo Xia <chenbox@nvidia.com>]

Hi David,

> On Jul 13, 2024, at 01:30, David Marchand <david.marchand@redhat.com> wrote:
> 
> External email: Use caution opening links or attachments
> 
> 
> Hello,
> 
> On Tue, Jul 2, 2024 at 9:40 AM Chaoyong He <chaoyong.he@corigine.com> wrote:
>> 
>> From: Zerun Fu <zerun.fu@corigine.com>
>> 
>> In the previous logic the 'fd' was only saved in the primary process,
>> but for some devices this value is also used in the secondary logic.
>> 
>> For example, the call of 'rte_pci_find_ext_capability()' will fail in
>> the secondary process.
>> 
>> Fix this problem by getting and saving the value of 'fd' also in the
>> secondary process logic.
>> 
>> Fixes: 9b957f378abf ("pci: merge uio functions for linux and bsd")
>> Cc: mukawa@igel.co.jp
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>> Reviewed-by: Long Wu <long.wu@corigine.com>
>> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Chenbo,
> Are you ok with this fix?

Sorry that I was interrupted when I was reviewing this and later I forgot..

For this patch:

Reviewed-by: Chenbo Xia <chenbox@nvidia.com>

> 
> Thanks.
> 
> --
> David Marchand