From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77]) by dpdk.org (Postfix) with ESMTP id E9F151B39E for ; Wed, 1 Aug 2018 22:49:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18UNpH8++NmlbSrYtlsL/jW5QdRlLkTMYl/AkoHj5Ek=; b=N7kG2uNNIGdkC02tWf49jeIhDxyboefnNm/PYcliXCWluS8r5uGhWgYhz+PsPW7FERmQO+2awtU8oiWkX26xseaJ/spnUny68U/LxNldVhqY+VKcPZL7xNY/cice4/p5TBeX5PMQyj56EbntnGYt2CUQrMN0iPPiwHmW/Yjtq5Q= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2335.eurprd05.prod.outlook.com (10.169.135.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.21; Wed, 1 Aug 2018 20:49:15 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::882c:f01c:dfb2:175%2]) with mapi id 15.20.1017.010; Wed, 1 Aug 2018 20:49:15 +0000 From: Yongseok Koh To: Christian Ehrhardt CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , dpdk stable Thread-Topic: patch 'net/mlx5: fix invalid network interface index' has been queued to stable release 18.05.1 Thread-Index: AQHUKCFZPTvnzlGNR06I/ugaC3KMjqSrYfKA Date: Wed, 1 Aug 2018 20:49:15 +0000 Message-ID: References: <20180730161342.16566-1-christian.ehrhardt@canonical.com> <20180730161342.16566-155-christian.ehrhardt@canonical.com> In-Reply-To: <20180730161342.16566-155-christian.ehrhardt@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2335; 6:+n5Bgob3/meFPBhZtlW0R9XbhdabOvHPpnlZDzjrgwVkBZ3YshgwDEZRBPBn0QLDoBDjTVJ43cFfElHra1cEbY6FOVc/OX9S1hsTp/0lQ2JLSLaiol8w5Nt+cCfoEeYkaltId4OWPVRQQL/aSedsnZqRSJhrNGXiCTYUL88NtT9H/WQHpCiDGVfBmPN2i9cmhKeP+e0H3bEI9TmuRSagTxUCDcFU+F9tEPjHjsfXtWpVIs5jPAPxTaimd0dPwAuIQbgic87ZPW6BsnhLIQj83e5p+wVXyodfQs7pUlHKqb/IMhLLHjStd99V9dr/xWBO1vcSYqQHKK3ig2imc4kpnP63uLodd6qedktI0r5jYq9A8ghgHbBGuRFuuCg7YqHF9c0navQt70r4fMNuSUO2UXMgDL9j1WhJRkM01bOAEzGgVt2lXoEeft64quHvP6CcxFP9xyc46Kua6js3Yyhn9A==; 5:vIl3EB6zBDcSp66Wo1MgQJ4cUBYGIbXFnVl5VNP+o7/iCFq++YDqbAUQwWDffpmVKTpKNW6PSFO811lllgctoAcxTOtiiJxPZWi91/C+ctC39fwVF+2QpH+nmkxXNau6x9vISBJh9/FFlBx+HsJOJjwoC8sSGl+zMTfbcpW0AJM=; 7:kwNan7Fb4Lb7Km7gQ2LAAqkDgwCaNzLFSHCBFvxwH23ocZhjiNNvLPc5q0m96Jw8okY9lSFzBlLZHnGIIHZqO3gdqdPryxovFhND5NZYR8k4iXTZI+fflstFlY2WwcJ1apGBwmZF4skakgXx6vjEpPALE5/gKtFs9sbPdErC3V/pcHQ0ZijsF4hTlv39daNKCN9jrqvRpFAFYduEnkt1w4aWjxbxxZWwzNKRDvHkBqxrvjRoPZR6dxGCmdXBhBEF x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9bcc816a-41dc-44ad-0479-08d5f7f03e6d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2335; x-ms-traffictypediagnostic: VI1PR0501MB2335: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(788757137089)(45079756050767)(198206253151910); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2335; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2335; x-forefront-prvs: 0751474A44 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(376002)(366004)(346002)(28163001)(189003)(199004)(69234005)(81156014)(6506007)(6116002)(3846002)(14454004)(256004)(316002)(76176011)(83716003)(6246003)(446003)(53936002)(6512007)(6306002)(305945005)(99286004)(966005)(478600001)(11346002)(575784001)(45080400002)(54906003)(86362001)(7736002)(53546011)(81166006)(66066001)(26005)(106356001)(25786009)(68736007)(486006)(8936002)(82746002)(33656002)(6436002)(2616005)(4326008)(476003)(6916009)(5250100002)(105586002)(8676002)(2900100001)(186003)(102836004)(97736004)(36756003)(6486002)(229853002)(5660300001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2335; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: UnS/Tsp9km3lYkDe++7xu8FcKbfuZBDjE7BHBgQadSYXQ+egb1bMr1o66GnsBCnseQlydVRCsWdAS/peAAf3j7URJrMlxy1SOeo/2CyC5ZaNERG4JGvf38tIYzzpPLdLDza2W4/icmWVnR9XO5edoRsYautdnRBFr4crNaqewT/g5GhaFkFs+E/T9ei0JLavcrXaIIrekbL2jiOQrxjzBb/dYrgtrpYwcMxk9Qdmp2/2WLfQoTZzIVlLiqTdMUzU2xm7QuZl/4M68WZAwJ1fG7UUVHZgdzhxyRE5aqPUkV2RRK84BP285P5ugYTM2YeYoU90AgSymVUNM5TsMP8oPejzPzuip77EBzw18Jcu7Uc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bcc816a-41dc-44ad-0479-08d5f7f03e6d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2018 20:49:15.3336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2335 Subject: Re: [dpdk-stable] patch 'net/mlx5: fix invalid network interface index' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 20:49:18 -0000 > On Jul 30, 2018, at 9:13 AM, Christian Ehrhardt wrote: >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 18.05.1 >=20 > Note it hasn't been pushed to https://emea01.safelinks.protection.outlook= .com/?url=3Dhttp%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=3D02%7C01= %7Cyskoh%40mellanox.com%7C672bbc6bc5d74492636508d5f6387a4e%7Ca652971c7d2e4d= 9ba6a4d149256f461b%7C0%7C0%7C636685644792733413&sdata=3Djqe2g7yUGj6J6lL= No0k0G4s2SUY1vf2ji98YCc0y9wM%3D&reserved=3D0 yet. > It will be pushed if I get no objections before 08/01/18. So please > shout if anyone has objections. >=20 > Thanks. >=20 > Christian Ehrhardt >=20 > --- > From 2049afe07c264d2e4e3754588a264dd17cadaf4f Mon Sep 17 00:00:00 2001 > From: Adrien Mazarguil > Date: Wed, 25 Jul 2018 13:24:33 +0200 > Subject: [PATCH] net/mlx5: fix invalid network interface index >=20 > [ upstream commit 3f8cb05df5407369025fbc8b67f0f9595b781f73 ] >=20 > Network interface indices being unsigned, an invalid index or error is > normally expressed through a zero value (see if_nametoindex()). >=20 > mlx5_ifindex() has a signed return type for negative values in case of > error. Since mlx5_nl.c does not check for errors, these may be fed back a= s > invalid interfaces indices to subsequent system calls. This usage would > have been correct if mlx5_ifindex() returned a zero value instead. >=20 > This patch makes mlx5_ifindex() unsigned for convenience. >=20 > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") >=20 > Signed-off-by: Adrien Mazarguil > Acked-by: Nelio Laranjeiro > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_ethdev.c | 20 ++++++++------------ > drivers/net/mlx5/mlx5_nl.c | 6 +++--- > 3 files changed, 12 insertions(+), 15 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 997b04a33..8f1335200 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -211,6 +211,7 @@ int mlx5_getenv_int(const char *); >=20 > int mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[IF_NAME= SIZE]); > int mlx5_ifindex(const struct rte_eth_dev *dev); > +unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); Hi Christian This line is to replace the upper line. In the original patch: -int mlx5_ifindex(const struct rte_eth_dev *dev); +unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); Please fix it. Thanks, Yongseok