patches for DPDK stable branches
 help / color / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix netlink rdma socket callback routine
Date: Tue, 10 Sep 2019 14:28:05 +0000
Message-ID: <DB3PR0502MB396496FDED7A8A60899C816DC2B60@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1568123511-20153-1-git-send-email-viacheslavo@mellanox.com>

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Tuesday, September 10, 2019 4:52 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix netlink rdma socket callback routine
> 
> The mlx5 PMD uses Netlink socket to communicate with Infiniband
> devices kernel drivers to perform some control and setup operations.
> The kernel drivers send the information back to the user mode
> with Netlink messages which are processed in libnl callback routine.
> This routine perform reply message (or set of messages) processing
> and returned the processing result in ibindex field of provided
> context structure (of mlx5_nl_ifindex_data type). The zero ibindex
> value meant an error of reply message processing. It was found in
> some configurations the zero is valid value for ibindex and error
> was wrongly raised. To avoid this the new flags field is provided
> in context structure, attribute processing flags are introduced
> and these flags are used to decide whether no error occurred and
> valid queried values are returned.
> 
> Fixes: e505508a3858 ("net/mlx5: modify get ifindex routine for multiport IB")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> v2: reverted back local parameter gathering within one Netlink message
>     in callback routine. It allows to avoid parameters overwriting in
>     case of reply contains multiple messages for all Infiniband devices
>     in the system.
> 
> v1:
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F59057%2F&amp;data=02%7C01%7Crasland%40mell
> anox.com%7C8e8cc6e9af8a4552ba8e08d735f60c17%7Ca652971c7d2e4d9ba6a
> 4d149256f461b%7C0%7C0%7C637037203199776325&amp;sdata=E4XI4EG%2B
> ri7OuNiWGWOtA1vZL31LYvVOPUpsiR%2Bz2p8%3D&amp;reserved=0
> 

Replaced V1 with V2 due to some issue was in V1,

So applied v2 to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 13:51 Viacheslav Ovsiienko
2019-09-10 14:28 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0502MB396496FDED7A8A60899C816DC2B60@DB3PR0502MB3964.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox