From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50076.outbound.protection.outlook.com [40.107.5.76]) by dpdk.org (Postfix) with ESMTP id F34C42C00; Wed, 30 Aug 2017 17:32:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R2m6+QJJ/xrfo7kSYU/IxCQ3r06IqKzVJzwGwN8/Mqk=; b=SxiC2J9CTm5kmeDWrlz3Pq2o34khY3XNLqA0DQtENdz73mYlLEsjj+SEmYIvQ3RSJIrPVzlul1mIm7VCfB5FdKC3N4L01P77VbVLFFX+gv0mw2VHkU4fyC8q+accTvkQeWEj2bLPEChs4l8m4dHRePWmyal1m+1+1tC93Xahis8= Received: from DB6PR0502MB3048.eurprd05.prod.outlook.com (10.172.250.136) by DB6PR0502MB2983.eurprd05.prod.outlook.com (10.172.246.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 30 Aug 2017 15:32:47 +0000 Received: from DB6PR0502MB3048.eurprd05.prod.outlook.com ([fe80::e938:efe9:effc:7ef8]) by DB6PR0502MB3048.eurprd05.prod.outlook.com ([fe80::e938:efe9:effc:7ef8%14]) with mapi id 15.01.1385.014; Wed, 30 Aug 2017 15:32:47 +0000 From: Matan Azrad To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" , Raslan Darawsheh , "stable@dpdk.org" Thread-Topic: [PATCH] net/failsafe: fix exec parameter parsing error flow Thread-Index: AQHTIOSZ0QRNWhqwGkGaxALU1E3A3qKcZV0QgACQS4CAABFYYA== Date: Wed, 30 Aug 2017 15:32:46 +0000 Message-ID: References: <1504018748-4766-1-git-send-email-matan@mellanox.com> <20170829163339.GP8124@bidouze.vm.6wind.com> <20170830142443.GB3049@bidouze.vm.6wind.com> In-Reply-To: <20170830142443.GB3049@bidouze.vm.6wind.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0502MB2983; 6:wbGyvZJr9rRobcNFwHzT1lSGlhtw9XvgY2iDxZ2+iWLtleBoILPumqHAshNLQV7zAu60+hedC088qzONIfAjVnSO7+hop9y34OoiXgbWD1MWMelhp8rY9vx0dMwSH/vDJ2TJCv7V2v3IPmG6lycmMEYYBpYpvS5O+vX32AiCbqiXN1GXG0jA3Uo09rFIp1J4pyxD08XEubxcFojv8MsApRtXNBaOsnTcatOeedSAjKuCGbHpJi0oP4PX8/qEQVxdSA/D6oBRIFWkQV0fGqCiyNaiogE7oYjeI3Le1GuJHWHTV2QqVCFafMK2gPlM60Wmn0KzZ35P2SD/DL0le0SX3A==; 5:/I4sAWR0pSfGl8isUDP1ed9cZ1Am7UzTDw3VU7D1x+ZwaNpzGo4nBOZ1FrFC9mWH+/ywzch+tPfnbzks+13lQv90K+pFR3z7Aw4gZFS/UZ8qCKTgWbatJJVmU56LAa1M44im2sSFVu6nGs6Q73fvng==; 24:HA7zt3PjVioDSXxgOTXiyI3yzbTWXvQ7V8bncl+jfCbcuIRzvtPDN0p6X6Y+hK82TOy9JO4LW0OZzYjDI/wZuOCOMMbh+4YM+uasHiTiL3w=; 7:Ri2dq1kwbaI8z5REJAnP+76ASPal5pl3fh40ij9sf56nsr369oSukVReh0vJqqkx0dB6NGZCfwxFJj8dNAfkdhKIfaLYA0P7ncQd6W0LfrPnwU1hOp1KjnmdaE3SZfD8IEmoJtWx+PiNqklbmhfF1QX5WwypystRIQFpIaqwSXBENPfEPQJokwJKRw3+qwTfslRP1l0tF+ocVdcWySNif0a63R1l2RXrq19Rtg5rJfg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: c9e80fb5-c7c2-460a-ef77-08d4efbc5dc3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0502MB2983; x-ms-traffictypediagnostic: DB6PR0502MB2983: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB2983; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB2983; x-forefront-prvs: 041517DFAB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(24454002)(189002)(377454003)(13464003)(199003)(478600001)(54356999)(76176999)(6506006)(33656002)(6436002)(110136004)(50986999)(93886005)(6246003)(105586002)(106356001)(101416001)(86362001)(5250100002)(14454004)(53936002)(8936002)(25786009)(81166006)(8676002)(81156014)(9686003)(305945005)(7736002)(53546010)(68736007)(99286003)(4326008)(66066001)(55016002)(54906002)(6916009)(74316002)(102836003)(6116002)(2900100001)(229853002)(3660700001)(3846002)(3280700002)(2906002)(7696004)(2950100002)(97736004)(5660300001)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB2983; H:DB6PR0502MB3048.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2017 15:32:47.0219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB2983 Subject: Re: [dpdk-stable] [PATCH] net/failsafe: fix exec parameter parsing error flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 15:32:49 -0000 Hi Gaetan > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Wednesday, August 30, 2017 5:25 PM > To: Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix exec parameter parsing error flow >=20 > On Wed, Aug 30, 2017 at 06:11:47AM +0000, Matan Azrad wrote: > > Hi Gaetan > > > > > -----Original Message----- > > > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > > > Sent: Tuesday, August 29, 2017 7:34 PM > > > To: Matan Azrad > > > Cc: dev@dpdk.org; Raslan Darawsheh ; > > > stable@dpdk.org > > > Subject: Re: [PATCH] net/failsafe: fix exec parameter parsing error > > > flow > > > > > > Hi Matan, > > > > > > On Tue, Aug 29, 2017 at 05:59:08PM +0300, Matan Azrad wrote: > > > > The corrupted code returns success value in case of the execution > > > > process output stream is empty(EOF). > > > > It causes to segmentation fault while failsafe polls this command > > > > line again, than gets success and tries to do hotplug add to the > > > > sub device by uninitialized pointer dereferencing. > > > > > > > > > > This is a bug and should be fixed, thanks. > > > >=20 > Actually I am unable to reproduce this bug. >=20 > Do you have a fail-safe command line that would showcase this behavior? testpmd -n 4 --vdev=3D"net_failsafe0,mac=3D00:15:5d:44:4b:17,exec(/root/df= ailsafe.sh,preferred,00:15:5d:44:4b:17),exec(/root/dfailsafe.sh,fallback,00= :15:5d:44:4b:17,0)" -w 0000:00:00.0 -- --burst=3D64 --mbcache=3D512 --por= tmask 0xf -i --txd=3D4096 --rxd=3D4096 --enable-scatter --nb-cores=3D7 = --rxq=3D2 --txq=3D2 --rss-udp --txqflags=3D0 just run the exec with non exists sh script. =20 >=20 > > > > Morever, when the output is not empty but uncorrect, failsafe > > > > returns error for its probe function while the expected behavior > > > > is to do polling until the output is correct. > > > > > > > > > > The expected behavior is for the fail-safe to return an error if the > > > execution of the given command returns an error. > > > > > > The intention is that users writing such script would be able to > > > output a blank lines in case there is nothing to probe, but still > > > remain aware of issues during the execution of the command. > > > > > > The fail-safe ignores errors pertaining to absent devices due to its = nature. > > > This does not mean that it should ignore all errors and try to keep > > > on going while everything else is on fire. > > > > > > The contract with the user is that "blank line" without other errors > > > means "absent device". Garbled output or return code !=3D 0 means > > > runtime error and should be thrown to the user / application. > > > > > > > OK, good, I would have signed this contract :) > > > > What's about if the parsing is not empty and out with error in the poll= ing > process? > > I think in current code failsafe just continues normally and tries agai= n on > next polling time. > > Because of this code I thought that if error occurs we should poll it a= gain... > > >=20 > It depends whether the fail-safe has already been initialized or not. > During the initialization phase, any errors other than -ENODEV means that= it > must stop and force the user to look into it. >=20 > When initialization has finished, if polling errors occurs, the fail-safe= will try to > minimize service disruption to the potentially existing sub-devices. It t= hus > discards the error and will try again later. >=20 > > Can you please add it (the contract) in failsafe documentation for exec > parameter? > > Can you answer to the above question? > > > > The fix changes the return value to be -ENODEV for this sub device > > > > in the two cases. > > > > By this way, failsafe tries to parse this sub device parameter by > > > > exec method until the output is correct. > > > > > > > > > > The issue is that this portion of the code will be heavily modified > > > anyway. The errno handling is erroneous and must be fixed, which is > > > in conflict with your patch. > > > > > > I will send the intended fix shortly, referencing this patch and the > > > issue your highlighted, but both patch won't be compatible. > > > > > > > Good, no problems. > > > > > > Fixes: a0194d828100 ("net/failsafe: add flexible device > > > > definition") > > > > Fixes: 35ffe4208140 ("net/failsafe: fix missing pclose after > > > > popen") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Matan Azrad > > > > --- > > > > drivers/net/failsafe/failsafe_args.c | 6 +++++- > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/failsafe/failsafe_args.c > > > > b/drivers/net/failsafe/failsafe_args.c > > > > index 645c885..61c55df 100644 > > > > --- a/drivers/net/failsafe/failsafe_args.c > > > > +++ b/drivers/net/failsafe/failsafe_args.c > > > > @@ -157,12 +157,16 @@ fs_execute_cmd(struct sub_device *sdev, > char > > > *cmdline) > > > > ret =3D fs_parse_device(sdev, output); > > > > if (ret) { > > > > ERROR("Parsing device '%s' failed", output); > > > > + ret =3D -ENODEV; > > > > Remove the above line for probe function error report. > > > > > > goto ret_pclose; > > > > } > > > > ret_pclose: > > > > pclose_ret =3D pclose(fp); > > > > if (pclose_ret) { > > > > - pclose_ret =3D errno; > > > > + if (errno =3D=3D 0) > > > > + errno =3D -(pclose_ret =3D ret); > > > > + else > > > > + pclose_ret =3D errno; > > > > ERROR("pclose: %s", strerror(errno)); > > > > errno =3D old_err; > > > > return pclose_ret; > > > > -- > > > > 2.7.4 > > > > > > > > > > Best regards, > > > -- > > > Ga=EBtan Rivet > > > 6WIND > > > > Thanks, > > Matan Azrad >=20 > -- > Ga=EBtan Rivet > 6WIND Regards Matan Azrad