* [dpdk-stable] A missing mlx5 patch for stable 17.11
@ 2018-05-23 21:07 Yongseok Koh
2018-05-27 3:15 ` Yuanhan Liu
0 siblings, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2018-05-23 21:07 UTC (permalink / raw)
To: Yuanhan Liu; +Cc: luca.boccassi, Shahaf Shuler, Wisam Monther, dpdk stable
Hi, Yuanhan
There's one missing patch from upstream repo. It is because the patch doesn't
have Cc tag. I should've asked when I acked it.
Please push this one to the 17.11 queue for the next available release.
I confirmed it can be applied without any conflict.
commit 0915e287a6a7ed884a3de198f08926d8418366d4
Author: Bin Huang <bin.huang@hxt-semitech.com>
Date: Fri Mar 30 13:13:38 2018 +0800
net/mlx5: add packet type index for TCP ack
According to CQE format:
- l4_hdr_type:
0 - None
1 - TCP header was present in the packet
2 - UDP header was present in the packet
3 - TCP header was present in the packet with Empty
TCP ACK indication. (TCP packet <ACK> flag is set,
and packet carries no data)
4 - TCP header was present in the packet with TCP ACK indication.
(TCP packet <ACK> flag is set, and packet carries data).
A packet should be identified as TCP packet if l4_hdr_type is 1, 3 or 4.
Add corresponding idx of TCP ACK to ptype table.
previous discussion:
https://www.mail-archive.com/users@dpdk.org/msg02980.html
Signed-off-by: Bin Huang <bin.huang@hxt-semitech.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] A missing mlx5 patch for stable 17.11
2018-05-23 21:07 [dpdk-stable] A missing mlx5 patch for stable 17.11 Yongseok Koh
@ 2018-05-27 3:15 ` Yuanhan Liu
2018-05-29 6:51 ` Shahaf Shuler
0 siblings, 1 reply; 4+ messages in thread
From: Yuanhan Liu @ 2018-05-27 3:15 UTC (permalink / raw)
To: Yongseok Koh; +Cc: luca.boccassi, Shahaf Shuler, Wisam Monther, dpdk stable
On Wed, May 23, 2018 at 09:07:56PM +0000, Yongseok Koh wrote:
> Hi, Yuanhan
>
> There's one missing patch from upstream repo. It is because the patch doesn't
> have Cc tag. I should've asked when I acked it.
>
> Please push this one to the 17.11 queue for the next available release.
> I confirmed it can be applied without any conflict.
Hi Yongseok,
Thank you for letting me know that! I have now pushed it to dpdk-stable/17.11.
--yliu
>
>
> commit 0915e287a6a7ed884a3de198f08926d8418366d4
> Author: Bin Huang <bin.huang@hxt-semitech.com>
> Date: Fri Mar 30 13:13:38 2018 +0800
>
> net/mlx5: add packet type index for TCP ack
>
> According to CQE format:
> - l4_hdr_type:
> 0 - None
> 1 - TCP header was present in the packet
> 2 - UDP header was present in the packet
> 3 - TCP header was present in the packet with Empty
> TCP ACK indication. (TCP packet <ACK> flag is set,
> and packet carries no data)
> 4 - TCP header was present in the packet with TCP ACK indication.
> (TCP packet <ACK> flag is set, and packet carries data).
>
> A packet should be identified as TCP packet if l4_hdr_type is 1, 3 or 4.
> Add corresponding idx of TCP ACK to ptype table.
>
> previous discussion:
> https://www.mail-archive.com/users@dpdk.org/msg02980.html
>
> Signed-off-by: Bin Huang <bin.huang@hxt-semitech.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
>
>
>
> Thanks,
> Yongseok
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] A missing mlx5 patch for stable 17.11
2018-05-27 3:15 ` Yuanhan Liu
@ 2018-05-29 6:51 ` Shahaf Shuler
2018-06-02 5:14 ` Yuanhan Liu
0 siblings, 1 reply; 4+ messages in thread
From: Shahaf Shuler @ 2018-05-29 6:51 UTC (permalink / raw)
To: Yuanhan Liu, Yongseok Koh; +Cc: luca.boccassi, Wisam Monther, dpdk stable
Hi Yuanhan,
Sunday, May 27, 2018 6:16 AM, Yuanhan Liu:
> Subject: Re: A missing mlx5 patch for stable 17.11
>
> On Wed, May 23, 2018 at 09:07:56PM +0000, Yongseok Koh wrote:
> > Hi, Yuanhan
> >
> > There's one missing patch from upstream repo. It is because the patch
> > doesn't have Cc tag. I should've asked when I acked it.
> >
> > Please push this one to the 17.11 queue for the next available release.
> > I confirmed it can be applied without any conflict.
>
> Hi Yongseok,
>
> Thank you for letting me know that! I have now pushed it to dpdk-
> stable/17.11.
In fact there is a bunch of fixes that we plan to backport to 17.11. they are currently missing probably to rebase issues.
We will send them out by EOW.
Thanks.
>
> --yliu
> >
> >
> > commit 0915e287a6a7ed884a3de198f08926d8418366d4
> > Author: Bin Huang <bin.huang@hxt-semitech.com>
> > Date: Fri Mar 30 13:13:38 2018 +0800
> >
> > net/mlx5: add packet type index for TCP ack
> >
> > According to CQE format:
> > - l4_hdr_type:
> > 0 - None
> > 1 - TCP header was present in the packet
> > 2 - UDP header was present in the packet
> > 3 - TCP header was present in the packet with Empty
> > TCP ACK indication. (TCP packet <ACK> flag is set,
> > and packet carries no data)
> > 4 - TCP header was present in the packet with TCP ACK indication.
> > (TCP packet <ACK> flag is set, and packet carries data).
> >
> > A packet should be identified as TCP packet if l4_hdr_type is 1, 3 or 4.
> > Add corresponding idx of TCP ACK to ptype table.
> >
> > previous discussion:
> >
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw
> ww
> > .mail-
> archive.com%2Fusers%40dpdk.org%2Fmsg02980.html&data=02%7C01%7Csh
> >
> ahafs%40mellanox.com%7C84449d300af3499abdfb08d5c3802afc%7Ca652971
> c7d2e
> >
> 4d9ba6a4d149256f461b%7C0%7C0%7C636629877612129429&sdata=Zqw10vw
> 38CRcKU
> > r0Jc25rM8ruEO7bP%2Fa5hHqOZ%2BB3EE%3D&reserved=0
> >
> > Signed-off-by: Bin Huang <bin.huang@hxt-semitech.com>
> > Acked-by: Yongseok Koh <yskoh@mellanox.com>
> >
> >
> >
> > Thanks,
> > Yongseok
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] A missing mlx5 patch for stable 17.11
2018-05-29 6:51 ` Shahaf Shuler
@ 2018-06-02 5:14 ` Yuanhan Liu
0 siblings, 0 replies; 4+ messages in thread
From: Yuanhan Liu @ 2018-06-02 5:14 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: Yongseok Koh, luca.boccassi, Wisam Monther, dpdk stable
On Tue, May 29, 2018 at 06:51:14AM +0000, Shahaf Shuler wrote:
> Hi Yuanhan,
>
> Sunday, May 27, 2018 6:16 AM, Yuanhan Liu:
> > Subject: Re: A missing mlx5 patch for stable 17.11
> >
> > On Wed, May 23, 2018 at 09:07:56PM +0000, Yongseok Koh wrote:
> > > Hi, Yuanhan
> > >
> > > There's one missing patch from upstream repo. It is because the patch
> > > doesn't have Cc tag. I should've asked when I acked it.
> > >
> > > Please push this one to the 17.11 queue for the next available release.
> > > I confirmed it can be applied without any conflict.
> >
> > Hi Yongseok,
> >
> > Thank you for letting me know that! I have now pushed it to dpdk-
> > stable/17.11.
>
> In fact there is a bunch of fixes that we plan to backport to 17.11. they are currently missing probably to rebase issues.
> We will send them out by EOW.
Thank you! And please make sure they are well tested.
--yliu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-02 5:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-23 21:07 [dpdk-stable] A missing mlx5 patch for stable 17.11 Yongseok Koh
2018-05-27 3:15 ` Yuanhan Liu
2018-05-29 6:51 ` Shahaf Shuler
2018-06-02 5:14 ` Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).