From: Shahaf Shuler <shahafs@mellanox.com>
To: Luca Boccassi <bluca@debian.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"christian.ehrhardt@canonical.com"
<christian.ehrhardt@canonical.com>,
Yongseok Koh <yskoh@mellanox.com>
Cc: Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix compilation for rdma-core v19
Date: Tue, 24 Jul 2018 04:53:55 +0000 [thread overview]
Message-ID: <DB7PR05MB4426BAC07E985223AD667AC5C3550@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1532365793.7624.11.camel@debian.org>
Monday, July 23, 2018 8:10 PM, Luca Boccassi:
> Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix compilation for rdma-core
> v19
>
> On Mon, 2018-07-23 at 10:30 +0300, Shahaf Shuler wrote:
> > [ backported from upstream commit
> > 06b1fe3f6d2121009b3b879e92b8cca25d4c0c42 ]
> >
> > The flow counter support introduced by commit 9a761de8ea14 ("net/mlx5:
> > flow counter support") was intend to work only with MLNX_OFED_4.2 as
> > the upstream rdma-core libraries were lack such support.
> >
> > On rdma-core v19 the support for the flow counters was added but with
> > different user APIs, hence causing compilation issues on the PMD.
> >
> > This patch fix the compilation errors by forcing the flow counters to
> > be enabled only with MLNX_OFED APIs.
> > Once MLNX_OFED and rdma-core APIs will be aligned, a proper patch to
> > support the new API will be submitted.
> >
> > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> > Cc: stable@dpdk.org
> > Cc: orika@mellanox.com
> >
> > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> > drivers/net/mlx5/Makefile | 2 +-
> > drivers/net/mlx5/mlx5_flow.c | 13 +++++++------
> > 2 files changed, 8 insertions(+), 7 deletions(-)
>
> Hi Shahaf,
>
> For which stable release branch is this patch intended?
This one for 18.05.1, I will have to make another one for 17.11.4
>
> --
> Kind regards,
> Luca Boccassi
next prev parent reply other threads:[~2018-07-24 4:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 7:30 Shahaf Shuler
2018-07-23 17:09 ` Luca Boccassi
2018-07-24 4:53 ` Shahaf Shuler [this message]
2018-07-24 8:15 ` Luca Boccassi
-- strict thread matches above, loose matches on Subject: below --
2018-07-12 6:56 Shahaf Shuler
2018-07-12 10:53 ` Ori Kam
2018-07-12 10:57 ` Shahaf Shuler
2018-07-17 14:59 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426BAC07E985223AD667AC5C3550@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=orika@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).