From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38A76A04FF for ; Thu, 24 Mar 2022 22:32:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FE5042836; Thu, 24 Mar 2022 22:32:42 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by mails.dpdk.org (Postfix) with ESMTP id 87DFB40150; Thu, 24 Mar 2022 22:32:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px40STmQed1cWpb35pV+VeuWskwjYrdqbcQ6YHVD4FI=; b=VSkO7uVwpSdTOMLqXWBVG13ROAolPNBr4eBoc3BrVPxdfppKpjPcvy+jnqtCBfp8C9LD0FTorC2rmPe/3FfOjae6blJhgh8CrfF0Vzu8vasiFAVuCaQzv3aoQ4GcC6kgKUFlj83cHJ+1os5RHwqwx9tZ/L0X04Mk8y92sTS2Vvg= Received: from DB6PR0501CA0019.eurprd05.prod.outlook.com (2603:10a6:4:8f::29) by AM0PR08MB5074.eurprd08.prod.outlook.com (2603:10a6:208:157::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Thu, 24 Mar 2022 21:32:38 +0000 Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::93) by DB6PR0501CA0019.outlook.office365.com (2603:10a6:4:8f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17 via Frontend Transport; Thu, 24 Mar 2022 21:32:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18 via Frontend Transport; Thu, 24 Mar 2022 21:32:37 +0000 Received: ("Tessian outbound 18e50a6f0513:v113"); Thu, 24 Mar 2022 21:32:37 +0000 X-CR-MTA-TID: 64aa7808 Received: from 435882fbb7c2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D15647EE-D3D2-473A-8C9D-C7E80E4CBDFE.1; Thu, 24 Mar 2022 21:32:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 435882fbb7c2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 24 Mar 2022 21:32:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIoC0+NLvLffepjkFhQdGwU1g/2jB+KRFvOipL7Xfcrf+Mrf0v2JjssnaTgvrqfajQPeNVn3Lk0oeZVM4pKnQAW+AxixY919yrQcP3wTVzr2XrpsDDWEekVmiY91/5HFqoABpRR0C86+2dTGqviOUENcPL+SWWhx0usjucwjWmtPTP25cEFAxbRK2NUaEqiQV6Z480mhp2w7tQpn1UIw7fU/sLgvt1MyYX8G8cAC0FRkACC2beJ88SYZs5ca7Vgvm17ey3eBqmvMUk2T3H4aIV6wYko4zFuLYtD+vZg/+81J58cRrKDbtcWZ3ND9dg49G6RQeDngNLKJG5uKClyXcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=px40STmQed1cWpb35pV+VeuWskwjYrdqbcQ6YHVD4FI=; b=E466NsHo8xw+L+FjMMNHlmxiDTLB7UIpAtYI+S1pR1CXV31eDQRY+jhV0L4wVB3gvG3xkHZQc46iTW4rN7xBMRwVbS1JRf+XOCZIWQ/HQCKwIJTQ3VAzTSXyh7Ynu3sFtBCUUeXW6SSaRZtnYatptlXJRgM9dD+//AaGx/wnMhYsYjpiaGthP6hBEApYBuMaDiEAyeJNBlLgpKOhDwL43c8nbABMIsc47yEda+gQ1C7zEQmVSmr9dnvP84DXTVIfC/OKoB7yZTTGLKRAUAvw5OgYkDEML/CeS4RcGKKoPcl3Cj7wgyq9WJESfG+HI+3z34H17HR3EdvACFk3vSpk0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px40STmQed1cWpb35pV+VeuWskwjYrdqbcQ6YHVD4FI=; b=VSkO7uVwpSdTOMLqXWBVG13ROAolPNBr4eBoc3BrVPxdfppKpjPcvy+jnqtCBfp8C9LD0FTorC2rmPe/3FfOjae6blJhgh8CrfF0Vzu8vasiFAVuCaQzv3aoQ4GcC6kgKUFlj83cHJ+1os5RHwqwx9tZ/L0X04Mk8y92sTS2Vvg= Received: from DBAPR08MB5752.eurprd08.prod.outlook.com (2603:10a6:10:1ac::21) by DB6PR0802MB2311.eurprd08.prod.outlook.com (2603:10a6:4:87::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Thu, 24 Mar 2022 21:32:24 +0000 Received: from DBAPR08MB5752.eurprd08.prod.outlook.com ([fe80::c9d4:b47c:637c:36b6]) by DBAPR08MB5752.eurprd08.prod.outlook.com ([fe80::c9d4:b47c:637c:36b6%9]) with mapi id 15.20.5102.018; Thu, 24 Mar 2022 21:32:23 +0000 From: Kathleen Capella To: "Zhang, Qi Z" , "Xing, Beilei" , "Yang, SteveX" , "dev@dpdk.org" CC: "Wu, Jingjing" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid Thread-Topic: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid Thread-Index: AQHYN4eCSznChnffxEiZSJL5T6Ab76zBq9aAgAyeDYCAANQSMA== Date: Thu, 24 Mar 2022 21:32:23 +0000 Message-ID: References: <20220314093146.697256-1-stevex.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 07EB81AA11880C43BB779EEECC09DD69.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1f2bfceb-2266-4da8-1273-08da0dddd137 x-ms-traffictypediagnostic: DB6PR0802MB2311:EE_|DB5EUR03FT060:EE_|AM0PR08MB5074:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dkdGG7f6uvj/ZVdu9H0bRZBfUJ29wO94zBexBU+P+cBpv+y3hpFjCJqDrnaaiD5zIIvFKRGmPmtgVH2Y/J4ZZxDw++mwxCaakY32ynFumkyppcIRaFwBnj5Cf8X14+lUPUO20svZZpJTbRONIU1vJx3XuzXedVD84QLzptuIn+hnI7O5yD+9TFmkpKK/9rnketk6oHHoQ5ryG4Zm1pqsDE929/fwthosn1P9VsURVo4RhtR+E1VsvH2m8X04BdLVg0e80WDNR6dnnmzGD7Wh7NnI3KnJ9yphkgCQfgW/aXIUIG+nBkZC2PPjeu4SocaPORbt5O6TagBbxVOJJhRCghxeFCVSaRbPVV/lOhEyONGWgmIYISQ7Ywed+oMI+pT5AoxMlWrryzDp0uTxgFr6prIl7Y+MgVsZWALIs+XppNgvNNb1Lay7pu88VO4IH1KhVz6O0AOXwwTO24RGP98YpuCsQP622wBXyQ3dPR/Vb2DHm3RG1xArxUvgJVlixH13sgikrc67sLZhdNCW6ZJgKaGVnLy8lllQLdQVxOl4jdlQTobGGCxOnptcuvVQW1cx8VZhI5NKwPSlxAu7TXfyPwfFQlHiTCc7Wd6WZq70M7vIUUgnW3afSGC9AzSp/Rhwb7c0bw+tkVN2yZNubbeu/xkzwJGylZMBU23PXIrJwzV2ylAQ56+kJTUhgNWHL8/ImpbhCO6PiyYMD22Eed7GqQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5752.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(86362001)(52536014)(33656002)(8936002)(9686003)(508600001)(7696005)(2906002)(6506007)(53546011)(122000001)(38100700002)(55016003)(186003)(83380400001)(38070700005)(8676002)(66946007)(4326008)(71200400001)(66556008)(66446008)(110136005)(66476007)(64756008)(316002)(76116006)(54906003); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2311 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c8144e85-ef0b-409e-e7af-08da0dddc912 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2d8Mn4d/mizM9caWyez9YCyspyT1QhwbKjAvfbF098fseUF9Uy8UnRpSkiLlbJIn1kC+fX08tlwKUshJ3lWReC6v8+p4PlBm9usTXmEMEqFVBC/7+3QeYErdV9birkDOX2yNUNo/Glx0T8skZDxD33O2GLj0TMPSIl7GJyfTdf5imrn2iu6vI3MysdIMQVwQclfrWzAdLu4HeGdiSS6IWOh3mXjt0EG+ukeEJcbid9kiW8z3ADeDOpxo/zuaJWqpVDeyAwIaIWuhq00w5oB5s48mcnKe8QX7v1Jrdr0cLIqsXPj0ChzyAuaKV2GA5RGUGhYoO33lgcBk0jEUkncA/0zQl9rlF67JAXXSdrDJSve6w4KpEEhhT/oqhIr1Q+AcJdLMUfwsRYdngc/tH8b2tAuc3qYcBE9gO7RbhUnluhzGFiVx4oAMz2Qr0+3UIC5GKrEKpZ1F8jfOJHXqsmfMDYSnHRaPxCw3ieYWSdQuklWaDvmB8aPnJw5eOiX0qBA4DLSobFeGAIZ7HZCe6OmL2mn7H/P6cYYCrhyKTiWkpTaaYhQit/rKMPW81yQdLIxvX/RAjsKXvZlm8SOWhKm9hvfTmiN6W8xJQTASK+vgyu3fOe9Cau9FYrG3NTru1DcxGfkh77iBKbjzPWVIewSwh18b1AREYNZV8ijXKhu58B1I9MzZr+eKI32rPJ+Fpx1o X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(47076005)(70206006)(70586007)(52536014)(82310400004)(450100002)(83380400001)(356005)(8676002)(110136005)(4326008)(6506007)(81166007)(7696005)(53546011)(54906003)(9686003)(33656002)(8936002)(336012)(26005)(40460700003)(316002)(36860700001)(55016003)(2906002)(508600001)(86362001)(5660300002)(186003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2022 21:32:37.5171 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f2bfceb-2266-4da8-1273-08da0dddd137 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5074 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Tested okay on N1SDP and on Intel(R) Xeon(R) Platinum 8268 CPU @ 2.90GHz Tested-by: Kathleen Capella > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, March 24, 2022 3:52 AM > To: Xing, Beilei ; Yang, SteveX > ; dev@dpdk.org > Cc: Wu, Jingjing ; stable@dpdk.org > Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid > > > > > -----Original Message----- > > From: Xing, Beilei > > Sent: Wednesday, March 16, 2022 4:12 PM > > To: Yang, SteveX ; dev@dpdk.org > > Cc: Wu, Jingjing ; Zhang, Qi Z > > ; stable@dpdk.org > > Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by > > rxdid > > > > > > > > > -----Original Message----- > > > From: Yang, SteveX > > > Sent: Monday, March 14, 2022 5:32 PM > > > To: dev@dpdk.org > > > Cc: Wu, Jingjing ; Xing, Beilei > > > ; Zhang, Qi Z ; Yang, > > > SteveX ; stable@dpdk.org > > > Subject: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid > > > > > > When setup RX queue, the rxdid would be changed if it's > > > "IAVF_RXDID_LEGACY_0/1", that caused the scan hw ring used the wrong > > > function 'iavf_rx_scan_hw_ring_flex_rxd()'. > > > > > > Ignore the rxdid changed when equals "IAVF_RXDID_LEGACY_0/1". > > > > > > Fixes: 0ed16e01313e ("net/iavf: fix function pointer in > > > multi-process") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Steve Yang > > > --- > > > drivers/net/iavf/iavf_rxtx.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > > b/drivers/net/iavf/iavf_rxtx.c index 16e8d021f9..3b16609f7d 100644 > > > --- a/drivers/net/iavf/iavf_rxtx.c > > > +++ b/drivers/net/iavf/iavf_rxtx.c > > > @@ -477,6 +477,8 @@ iavf_rxd_to_pkt_fields_by_comms_aux_v2(struct > > > iavf_rx_queue *rxq, > > > > > > static const > > > iavf_rxd_to_pkt_fields_t rxd_to_pkt_fields_ops[IAVF_RXDID_LAST + 1] > > > =3D { > > > + [IAVF_RXDID_LEGACY_0] =3D iavf_rxd_to_pkt_fields_by_comms_ovs, > > > + [IAVF_RXDID_LEGACY_1] =3D iavf_rxd_to_pkt_fields_by_comms_ovs, > > > [IAVF_RXDID_COMMS_AUX_VLAN] =3D > > > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > > > [IAVF_RXDID_COMMS_AUX_IPV4] =3D > > > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > > > [IAVF_RXDID_COMMS_AUX_IPV6] =3D > > > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > > > @@ -521,6 +523,8 @@ iavf_select_rxd_to_pkt_fields_handler(struct > > > iavf_rx_queue *rxq, uint32_t rxdid) > > > > > > rte_pmd_ifd_dynflag_proto_xtr_ipsec_crypto_said_mask; > > > break; > > > case IAVF_RXDID_COMMS_OVS_1: > > > + case IAVF_RXDID_LEGACY_0: > > > + case IAVF_RXDID_LEGACY_1: > > > break; > > > default: > > > /* update this according to the RXDID for FLEX_DESC_NONE > > */ > > > -- > > > 2.27.0 > > > > Acked-by: Beilei Xing > > Applied to dpdk-next-net-intel. > > Thanks > Qi IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.