From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Joyce Kong <Joyce.Kong@arm.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>
Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>,
"mdr@ashroe.eu" <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>,
nd <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>,
nd <nd@arm.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] doc: update atomic operation deprecation
Date: Mon, 2 Aug 2021 17:22:03 +0000 [thread overview]
Message-ID: <DBAPR08MB58142A044873F3B11EBECEC098EF9@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2994487.6sU7YWgjxR@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Saturday, July 31, 2021 3:27 PM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Joyce Kong <Joyce.Kong@arm.com>
> Cc: stephen@networkplumber.org; mdr@ashroe.eu; dev@dpdk.org; nd
> <nd@arm.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: update atomic operation deprecation
>
> 23/07/2021 11:49, Joyce Kong:
> > Update the incorrect description about atomic operations with provided
> > wrappers in deprecation doc[1].
> >
> > [1]https://mails.dpdk.org/archives/dev/2021-July/213333.html
> >
> > Fixes: 7518c5c4ae6a ("doc: announce adoption of C11 atomic operations
> > semantics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Applied, thanks.
>
> Considering all the questions regarding usage of atomics, I still think we need a
> documentation about their correct use.
I think few things to document are:
1) Use of __atomic_add_fetch vs __atomic_fetch_add
2) Using __ATOMIC_RELAXED for statistics
3) Using rte_atomic_thread_fence API
Anything else?
>
next prev parent reply other threads:[~2021-08-02 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 8:02 [dpdk-stable] [PATCH v1] " Joyce Kong
2021-07-17 18:47 ` Honnappa Nagarahalli
2021-07-23 9:49 ` [dpdk-stable] [PATCH v2] " Joyce Kong
2021-07-31 20:26 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-08-02 17:22 ` Honnappa Nagarahalli [this message]
2021-08-02 17:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB58142A044873F3B11EBECEC098EF9@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).