From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2A0F48B0B for ; Fri, 14 Nov 2025 17:08:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAD2B40E3F; Fri, 14 Nov 2025 17:08:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E5A1F40E3F for ; Fri, 14 Nov 2025 17:08:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763136523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qYZI4G7NJ7HlNAl8CSPpvXZLtrVIagzofR1UAcggMFY=; b=J0K0RVaxUtABjS1mvpfwssPseenC5eD85FgKCjhIAAEFFfPfXZ49186DPErGh6O74VidvU TSpGdE4+RWQsP3zO8mse1kFC0NJ1fUiu1C4h1IxOHeoieQO1E8Z6yy5CctDAMwB4z4yzy3 VF87+Oni1QXHakJMCn79eTaMI6XmiQU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-XJjrvH0cN2-aRgatiGPIkw-1; Fri, 14 Nov 2025 11:08:42 -0500 X-MC-Unique: XJjrvH0cN2-aRgatiGPIkw-1 X-Mimecast-MFC-AGG-ID: XJjrvH0cN2-aRgatiGPIkw_1763136521 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477792eb8e4so18027025e9.1 for ; Fri, 14 Nov 2025 08:08:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763136521; x=1763741321; h=in-reply-to:references:user-agent:subject:to:from:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Flpxv46njfn2jBYh4rVkPwRFerJ5wEjcP5hw/tEVu1o=; b=qWgvml7uZ8JGFVBe0MTpWRz5Hdg+xvnDKaBCJduQDRj/cubsyYFMTXYrWA1SFoUnUM 7Qb6jhqHb+vuqmsWHguu3674Uj/FFOfVQNgzYEQhwZfZUnza1eLX0QnIoRxB2XPSYo0Z 2HYXPnsiTNvlxTRf0nR6kXT8MuoRbCNnxTjlGdV7l2rGtsYQsu+porzMNZqe5uRLy6Ur k+orv6xGaduAC9S9TnVlHeaPMD6u/AKNHvcg9tD8SJ/+TlFgiTNK6DJaY1GgD40Ll0Yn 0VKM3JOETNhnhmModzjIidIkAd3PV48cW52clV1PTALCg+niY3sXxAVmvsFvEJrurbTv m2xg== X-Forwarded-Encrypted: i=1; AJvYcCVUSTA9Igde8LS9dYfjUNTK0RseNvj+AfKIFLH7KnKUTHhAirFFLd0+b15kzLkz3OD0pVx0vHA=@dpdk.org X-Gm-Message-State: AOJu0YwiE22Ovi1reYL4MB0Eop5KV/KWM8Lx/tAOYqxZyn/sB1DKbsJH YKeCQFfyvAwkfK7IwRiUXTj0pOTkWYUUCK4XquD4nxLbUilFXT9/elHUThDfbLoA0OY6U2/EIRr sDd/X+RMyquEbiQSRXpQt3zNZR+NSIdJYuySxPcVLZQs2WTcI X-Gm-Gg: ASbGncuhFJ4qI1IamzPPWexNuENpyKILR+5kHoGX76pSfcFb0NJs2fKIgCxvvu2nInQ rFHEa+vPYos+wUkCZkyJ2fFTZI025q5OTNdNLhwmPXpWlCaoU7DC2l8nifq95Sv/SrN5cvEyjB+ NUSRJViftEnYKJuhkkOB/w6BQ7M/WYXSXK/7jqXbXazk/MjlNDiVafbyMaPPjopUdjC6HglnzpK MarO5xt5pZM42235wjlt9mfZ7ptgsFy7SH43cQ8x2zU9qnirhJUP9pFk+0LBz8tzisVzlsWV1Tg 4V36zz3BmTLBva9pL8kVw7jE04qFfu2u4WceMAC55G3WJ4LQxTVkAcbYPnqDJLvRY0GQ8b+nBMs GP3q9ykjV2CkR4PFqiu4VLXOFkC2fpKghJJIDdNzzFPPuhekhGLX/O3ZjjQ== X-Received: by 2002:a05:600c:1ca8:b0:475:d9de:952e with SMTP id 5b1f17b1804b1-4778fd80818mr44736245e9.1.1763136521078; Fri, 14 Nov 2025 08:08:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHuU7WKq09pGWqWRejpTFWGmqebgQU5IXSJ01osphVrAGjEpDyQj7xmQTAEIuPk6jCotq5bQw== X-Received: by 2002:a05:600c:1ca8:b0:475:d9de:952e with SMTP id 5b1f17b1804b1-4778fd80818mr44735805e9.1.1763136520654; Fri, 14 Nov 2025 08:08:40 -0800 (PST) Received: from localhost (2a01cb00021ec000b06e6b63494bd4c5.ipv6.abo.wanadoo.fr. [2a01:cb00:21e:c000:b06e:6b63:494b:d4c5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778bcf75b8sm50174775e9.1.2025.11.14.08.08.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 08:08:40 -0800 (PST) Mime-Version: 1.0 Date: Fri, 14 Nov 2025 17:08:39 +0100 Message-Id: Cc: , "Christophe Fontaine" , From: "Robin Jarry" To: "Stephen Hemminger" Subject: Re: [PATCH dpdk] net: ipv6 link local compliance with rfc 4291 User-Agent: aerc/0.21.0-27-g605fd3b39ccd-dirty References: <20251114105751.54802-3-rjarry@redhat.com> <20251114080532.1e86d13e@phoenix> In-Reply-To: <20251114080532.1e86d13e@phoenix> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zZ0rhFAMAJwv8noFhO4Je23A-Jv_RNvgqdWzfgrEcgc_1763136521 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Stephen Hemminger, Nov 14, 2025 at 17:05: > On Fri, 14 Nov 2025 11:57:53 +0100 > Robin Jarry wrote: > >> diff --git a/app/test/test_net_ip6.c b/app/test/test_net_ip6.c >> index cfc550940306..e4642c9a39d9 100644 >> --- a/app/test/test_net_ip6.c >> +++ b/app/test/test_net_ip6.c >> @@ -160,7 +160,7 @@ test_ipv6_llocal_from_ethernet(void) >> { >> =09const struct rte_ether_addr local_mac =3D {{0x04, 0x7b, 0xcb, 0x5c, = 0x08, 0x44}}; >> =09const struct rte_ipv6_addr local_ip =3D >> -=09=09RTE_IPV6(0xfe80, 0, 0, 0, 0x047b, 0xcbff, 0xfe5c, 0x0844); >> +=09=09RTE_IPV6(0xfe80, 0, 0, 0, 0x067b, 0xcbff, 0xfe5c, 0x0844); >> =09struct rte_ipv6_addr ip; > > Reading the kernel source there is also special handling to include devic= e > id into link local address. This is to handle corner case where multiple = network > cards have same hardware MAC address. > > Perhaps DPDK should roll port id into link local address? We discussed about this but it would break the API since you would need to pass an additional parameter to this function. And also, I couldn't find anything in the RFC that describes what the kernel does with device IDs. Nothing mentions if the device id should be big or little endian, etc. I don't mind changing the API though but it seems very opinionated. --=20 Robin > Contest void where prohibited by law.