From: "Shetty, Praveen" <praveen.shetty@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Loftus, Ciara" <ciara.loftus@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/idpf: fix missing offload from conversion function
Date: Mon, 17 Nov 2025 06:46:44 +0000 [thread overview]
Message-ID: <DM3PPF291EF9BF16AE2EB6DB4623D607D049DC9A@DM3PPF291EF9BF1.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20251113145021.3793930-1-ciara.loftus@intel.com>
The TCP_TSO tx offload was missing from the conversion function. This was effectively taking the request for that offload out of consideration when selecting the tx function. As a result a vector path which does not support TSO could be chosen when that offload was requested, when instead the scalar path should be chosen which does support that offload. Fix this by adding the TSO offload to the conversion function.
Fixes: c008a5e740bd ("common/idpf: add queue setup/release")
Cc: stable@dpdk.org
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/idpf/idpf_rxtx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/intel/idpf/idpf_rxtx.c b/drivers/net/intel/idpf/idpf_rxtx.c
index 1c725065df..4796d8b862 100644
--- a/drivers/net/intel/idpf/idpf_rxtx.c
+++ b/drivers/net/intel/idpf/idpf_rxtx.c
@@ -42,6 +42,8 @@ idpf_tx_offload_convert(uint64_t offload)
ol |= IDPF_TX_OFFLOAD_TCP_CKSUM;
if ((offload & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM) != 0)
ol |= IDPF_TX_OFFLOAD_SCTP_CKSUM;
+ if ((offload & RTE_ETH_TX_OFFLOAD_TCP_TSO) != 0)
+ ol |= IDPF_TX_OFFLOAD_TCP_TSO;
if ((offload & RTE_ETH_TX_OFFLOAD_MULTI_SEGS) != 0)
ol |= IDPF_TX_OFFLOAD_MULTI_SEGS;
if ((offload & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0)
--
Looks good to me,
Acked-by: Praveen Shetty <praveen.shetty@intel.com>
2.34.1
next prev parent reply other threads:[~2025-11-17 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 14:50 Ciara Loftus
2025-11-17 6:46 ` Shetty, Praveen [this message]
2025-11-17 9:35 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM3PPF291EF9BF16AE2EB6DB4623D607D049DC9A@DM3PPF291EF9BF1.namprd11.prod.outlook.com \
--to=praveen.shetty@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).