From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: "Hore, Soumyadeep" <soumyadeep.hore@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "Kumar, Rajesh3" <rajesh3.kumar@intel.com>,
	"Singh, Aman Deep" <aman.deep.singh@intel.com>,
	"Subbarao, Manoj Kumar" <manoj.kumar.subbarao@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2 1/3] net/ice: restrict ice PMD to scalar path for TxPP
Date: Mon, 3 Nov 2025 10:25:21 +0000	[thread overview]
Message-ID: <DM3PPF7D18F34A133AB1DF75CBD81F45A038EC7A@DM3PPF7D18F34A1.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20251030173304.260209-2-soumyadeep.hore@intel.com>
> Subject: [PATCH v2 1/3] net/ice: restrict ice PMD to scalar path for TxPP
> 
> ICE PMD supports TxPP feature only in scalar path. Hence restricted
> testpmd to scalar path when the feature is enabled.
Remove the reference to testpmd in the commit message, as the change
will affect all applications, not just specifically testpmd.
The code change looks good to me.
Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> 
> Fixes: 0b6ff09a1f19 ("net/intel: support Tx packet pacing for E830")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
> ---
>  drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> index a7cc4736cf..a24694c0b1 100644
> --- a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> +++ b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> @@ -59,7 +59,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue
> *rxq)
>  		RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |    \
>  		RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |    \
>  		RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |    \
> -		RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM)
> +		RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |	\
> +		RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP)
> 
>  #define ICE_TX_VECTOR_OFFLOAD (				\
>  		RTE_ETH_TX_OFFLOAD_VLAN_INSERT |		\
> --
> 2.47.1
next prev parent reply	other threads:[~2025-11-03 10:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251027182801.191295-1-soumyadeep.hore@intel.com>
2025-10-27 18:27 ` [PATCH v1 1/3] net/ice: restrict testpmd " Soumyadeep Hore
2025-10-29  9:30   ` Loftus, Ciara
2025-10-27 18:28 ` [PATCH v1 2/3] net/ice: fix PTP clock corruption with TxPP Soumyadeep Hore
2025-10-29 17:11   ` Bruce Richardson
2025-10-27 18:28 ` [PATCH v1 3/3] doc: update TxPP documentation Soumyadeep Hore
     [not found] ` <20251030173304.260209-1-soumyadeep.hore@intel.com>
2025-10-30 17:33   ` [PATCH v2 1/3] net/ice: restrict ice PMD to scalar path for TxPP Soumyadeep Hore
2025-11-03 10:25     ` Loftus, Ciara [this message]
2025-10-30 17:33   ` [PATCH v2 2/3] net/ice: fix PTP clock corruption with TxPP Soumyadeep Hore
2025-11-04 11:32     ` Bruce Richardson
2025-10-30 17:33   ` [PATCH v2 3/3] doc: update TxPP documentation Soumyadeep Hore
2025-11-04 11:41     ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=DM3PPF7D18F34A133AB1DF75CBD81F45A038EC7A@DM3PPF7D18F34A1.namprd11.prod.outlook.com \
    --to=ciara.loftus@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=manoj.kumar.subbarao@intel.com \
    --cc=rajesh3.kumar@intel.com \
    --cc=soumyadeep.hore@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).