patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	"amorenoz@redhat.com" <amorenoz@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"michaelba@nvidia.com" <michaelba@nvidia.com>,
	"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
	"yvugenfi@redhat.com" <yvugenfi@redhat.com>,
	"ybendito@redhat.com" <ybendito@redhat.com>
Subject: Re: [dpdk-stable] [PATCH v2 3/5] app/testpmd: fix RSS type display
Date: Wed, 22 Sep 2021 12:01:04 +0000	[thread overview]
Message-ID: <DM4PR11MB55349D64B3E5E3BAA2444D4199A29@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210922095742.229262-4-maxime.coquelin@redhat.com>


> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, September 22, 2021 17:58
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> amorenoz@redhat.com; david.marchand@redhat.com;
> andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh <ferruh.yigit@intel.com>;
> michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun
> <xiaoyun.li@intel.com>
> Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com;
> ybendito@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v2 3/5] app/testpmd: fix RSS type display
> 
> This patch fixes the display of the RSS hash types configured in the port, which
> displayed "all" even if only a single type was configured
> 
> Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  app/test-pmd/config.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 611965769c..9a4a0c232b 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2833,7 +2833,9 @@ port_rss_hash_conf_show(portid_t port_id, int
> show_rss_key)
>  	}
>  	printf("RSS functions:\n ");
>  	for (i = 0; rss_type_table[i].str; i++) {
> -		if (rss_hf & rss_type_table[i].rss_type)
> +		if (rss_type_table[i].rss_type == 0)
> +			continue;
> +		if ((rss_hf & rss_type_table[i].rss_type) ==
> +rss_type_table[i].rss_type)
>  			printf("%s ", rss_type_table[i].str);
>  	}
>  	printf("\n");
> --
> 2.31.1

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

  reply	other threads:[~2021-09-22 12:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  9:57 [dpdk-stable] [PATCH v2 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-22  9:57 ` [dpdk-stable] [PATCH v2 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-09-22 11:20   ` Andrew Rybchenko
2021-09-22 12:28     ` Maxime Coquelin
2021-09-23  7:35   ` Xia, Chenbo
2021-09-29  9:02     ` Maxime Coquelin
2021-09-22  9:57 ` [dpdk-stable] [PATCH v2 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-09-22 11:25   ` Li, Xiaoyun
2021-09-23  7:52   ` Xia, Chenbo
2021-09-22  9:57 ` [dpdk-stable] [PATCH v2 3/5] app/testpmd: fix RSS type display Maxime Coquelin
2021-09-22 12:01   ` Li, Xiaoyun [this message]
2021-09-23  7:59   ` Xia, Chenbo
2021-09-22  9:57 ` [dpdk-stable] [PATCH v2 4/5] net/mlx5: fix RSS RETA update Maxime Coquelin
2021-09-22  9:57 ` [dpdk-stable] [PATCH v2 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-09-22 11:31   ` Li, Xiaoyun
2021-09-29  7:27     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB55349D64B3E5E3BAA2444D4199A29@DM4PR11MB5534.namprd11.prod.outlook.com \
    --to=xiaoyun.li@intel.com \
    --cc=amorenoz@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=michaelba@nvidia.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=ybendito@redhat.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).