From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50CE6A00C3 for ; Fri, 1 Jul 2022 05:47:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4483140A80; Fri, 1 Jul 2022 05:47:14 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E61C640694; Fri, 1 Jul 2022 05:47:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656647232; x=1688183232; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ikj+cM5AFJHeKJLoQLneTqYZSE/j82xFTEaD7rVndl0=; b=PunlIM4gLDBVi3joovXSMpU1+Zt1+DIgPSgfA4NItryxvEUaJ2bRQmjg FTB68WECPBEi3kfQvh0M+DZEJ7kCEKJrbhAOEJeA9UCoZAdyqKVQgGIze xC0i2PYY/ku7wridiT/8LtbBWhZAzvcxSTEvB/OyVuQY9hkPhYJnhZWDD u7IoF1kZXnf66kEExyvTWiiKOhzVnoN8oaH7UcSFy/WAtnsJ0T8qTmnNA ILu4cw6gdEmMlUPxscB0g/FJs8Ye602cB2ThLME0gk4g/oLx6SzI3wIjM H08oUXSqiQ0gPpLPWlgjm6dU8Xmvh2S4PPPDTFtf5WbY1XWB8/jF8o2gn w==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="282573948" X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="282573948" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 20:47:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="837875927" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 30 Jun 2022 20:47:10 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 30 Jun 2022 20:47:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 30 Jun 2022 20:47:10 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 30 Jun 2022 20:47:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ASiNBnGVw0bASSM7OTBQKBvLEchj/myZnVo9uALJwF+rhLbCVqK5n8hViatE3G2fP54NSeLCsBCFX67dUqPkNfTJ+K/JPRUO6SInZr6FtI0lcwSkVXBLddiuNJEt1gy33KEns3XW7KyRbh8VlWIasbrRkj+3VZy6K/C9bgdhzsUHGlDF8EAxMpUwHPufQcVt9vVDv92NyRV/Vo0MoyGnlRrOXDm4NAnuZ3dOQIfM+XEZOy6EsPIW7cawdm8p4msFPAdKl9tTiDMink2kqvAB04YNGBRJZz0DRWmvSPC5a3XztxOajWWv5TAWYvqO5i1ma5w2py33DtDSJeidVfvziA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XI/bH9SwLDQ8PDU4rM5bNCU11KyxQEtax1NCFUN314s=; b=KWkx3zYYnIF8sdlBwxioLJL3TW7uxcb05K68+79WO5nX0nkggJroPVvj7AZ+ebn/17TZzVd8uqyu1tj1r3Y6enzhx/HEXGfIZ+1fM13tPFA7Habt3HsHClkPZn0i6Gqe3Wa4EIOxfP9uzldXEUL6tjRM3U5Z8n3asHUWeiXmKTKz3DflIScO6D65Bg/HWyFqSuJUtCd8NGdghoH1MlzJBbiNY0HIWKv1J9BnlxANDf55/ZcpQsId+DpG0yE/3dm9wtQ5a8YzOW+cVzye/i+TLXF6LYEgC0BPfxargNapESvC5YOoCUDwOof9kgVSvh5pkPyJR/G35x92/Tufv9AmSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM6PR11MB2697.namprd11.prod.outlook.com (2603:10b6:5:c3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 03:47:09 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d%3]) with mapi id 15.20.5373.018; Fri, 1 Jul 2022 03:47:08 +0000 From: "Zhang, Qi Z" To: "Zeng, ZhichaoX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "alvinx.zhang@intel.com" , "Guo, Junfeng" , "Su, Simei" , "Burakov, Anatoly" , Ferruh Yigit Subject: RE: [PATCH v4] net/igc: add support for secondary processes Thread-Topic: [PATCH v4] net/igc: add support for secondary processes Thread-Index: AQHYjHESpL0si5Ks5EOZZ+hGSddSqK1n1SywgAEC84CAAAakAA== Date: Fri, 1 Jul 2022 03:47:08 +0000 Message-ID: References: <20220628062052.5397-1-zhichaox.zeng@intel.com> <20220630110330.211655-1-zhichaox.zeng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ede283f-d29f-47db-0b3a-08da5b145f86 x-ms-traffictypediagnostic: DM6PR11MB2697:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3liR2RxOvoQc/P3x9N6lyI5UBh7mYYLiWUJfa6Hd+qJd6kH3vPhBsmzUW5tit0p48nsfmXxlmjXdaduf1rMhnxZKtDNhM6d4bdmMT6wKghLd8SAUiMDmgUPowaGF/4V5Jvnhormm17m/gu9V1qjaf4ykpGEG1kHlOR+yYEGOvofTDFqaOR2CJyyMzFQ46WQGNfVPtI3QHRrd4rkSwVpK5EJCfPtQ5s6786/lLXXTXEteAOub9bBo0eele1VMaJx19dsHxCb2552yIhdjlHaLjpX+1vc492C8J8JSP5AI305fzwNQoA0rTeDJ3qOX3tr6NFPhtWJE5cDVGac02E0pYiMNmE3vBFjb66Q15sX2BzHpMNGC56f3kSDvyiE+1sxiz4wxaKBJQd+72IW39DmmD8zO7/pRy/aoZobIXcyiIIxRvUjW+l/9pLz9vAL6MJhx5IGl66BKRWPYEuyZ+mI6hXPEhK79An2Rqbv00lMN5eiANV0nrt2LxAqDP6BC0vM+O6k/MdvlcwXFxNfULZq9FsczsooqO8OpYiyciyTNd3ydmmH8TGWjiRO7Yt2YOGqF8HakE+x8FnyditQvICv2tlULiobq4ajrZXegDR82Zc3b5CnFSQRDXBALSP80xLwKEYHJmPPjaropz9tKDw1nTs+CvxW9VeksWpH0XQGAeBamrzw0HM7p3tim5fEVRHpKL3C0R2K1nQlxmIWH8hIEurur5owbs9LFdMEGbn3Whqy1QGKaOTIS1/FYY9z3zWD+fUCC6Kqz7xt8+BnPZNuAOysmVA89MC+jfrfX8ZC3NLC1/4tq468/wkrA3bQfPv0U x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(396003)(346002)(366004)(39860400002)(6506007)(122000001)(107886003)(41300700001)(38070700005)(8936002)(82960400001)(4326008)(55016003)(186003)(38100700002)(66476007)(66946007)(7696005)(66446008)(76116006)(53546011)(83380400001)(86362001)(5660300002)(9686003)(66556008)(33656002)(52536014)(450100002)(54906003)(71200400001)(2906002)(478600001)(26005)(8676002)(64756008)(316002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CO5SPTyptJCRd3Y3tmSGMh0mf0b9HaS4W801R1iIfPAmhVosaeqw8rz5X5dY?= =?us-ascii?Q?YMKvdgxP1MaiVHRh/X62UYpJTF1YjeSVmcdDaX43E2cKh9dQgNQ5AEgyb/bj?= =?us-ascii?Q?Rn+isGRkydhuGj8yqQfhK5bhh5ExPfA7lXcdTJmzLQPw8nHaQNz0mdENlUrJ?= =?us-ascii?Q?jdQ3z9k9ULUDsAef/rqUB1RNpDPO9VorGLSgRYKY3y1rtJbqUyQMQnqGv7mg?= =?us-ascii?Q?U7IfGXJNkV38XtWvQe89m6qNIjmFECMzUGkMeUtydXz+5FL2DuMAihhVNmmA?= =?us-ascii?Q?9uxEZs1fwleIhHDn71kN3lgjDmPmTJ2/BdxTLzb8asm9oQnG/aW4t0oC+ByL?= =?us-ascii?Q?/6AqIXxJZU7KZ15kB4kEL0FY/OW5Rtdrirlu6h4o1KbD0FLdtE+PB9vLDrZP?= =?us-ascii?Q?Hz/T0A58YuPA46AdUT/HpB5IdFMiJzhPSoZ09Jld1Gy6RbMFVFcB5EKJ7FGj?= =?us-ascii?Q?kF5p2Vfo2AA+3Yi/oY+8KBASvfN2fHXQXzSFVpC1d0oZ/s0R906BhabYZ08E?= =?us-ascii?Q?nXiTIBBVS/LD3a3YP9tlRbamc6Pp4UFpLjvvYb/xTfVqL+14CBybXXb4HYUO?= =?us-ascii?Q?Veg7iysv4vMadx2hVEENJkJAu6uKx0G7VFjCepngvLsIbKdNShuKFodUkilk?= =?us-ascii?Q?IpZBc0mK8ICZmblHzW0U4Kg9wl4UoNILMEBFkpgvZe6f15fzkYfJKMvnNtmk?= =?us-ascii?Q?Tlqx3WSPa5F6EpcwSjkliUmROyC3L2VEIhDkkxO/pgRjaV0I1mM/fcG6nQOR?= =?us-ascii?Q?oPJFlMpH4iFInS2uY3CB5nP4FU6XI2jrCAbeoK3MhY8jlruvjHs6YwXC3/eg?= =?us-ascii?Q?rmWwT4DaaLIKTokVr9ynrnXguxiYAvZJV4CMdUpSW6u61h/txn7GGXOGkq2S?= =?us-ascii?Q?CPu0LrU8yxO+SpYiOnGalwlTCPJ+nSE1TioVkgTqLvOhflQ/5Ew4cgR/emI+?= =?us-ascii?Q?FIJS9GGymlDbm1VQA8OMSAohPmbE+DnQoM5cYqo/lGE9+/bpYJ71VrgvNeA8?= =?us-ascii?Q?/lKa5xYm+Lyiw3yeGyKvDYdKnXctK7BBy4PxxDEidk3vilszncd/LHh2QvdZ?= =?us-ascii?Q?HSfYGUN5GRMlBI4vvqmvQ2+wkw7mkqDN8irrLBj4lD2qs1G7mSj3aSqI4zst?= =?us-ascii?Q?c9gptBW+Hwor0Fw79SlKn11tQ6c43jWaiAanqKQOM8iSM5MReBPc1hwA8GNZ?= =?us-ascii?Q?awM+kEUTObcpVc3Ruqp/6oUzRAIbvr5apGphiHugemaIqwusj9jmnMAXnRvp?= =?us-ascii?Q?SatMVCEKn0UNej48j6it8Wzn7oBeigWGiOz9Cb3EuPyo2fqhQoRjlsuLkKi7?= =?us-ascii?Q?KFTSKH1hR4b0SSCMAeB5MruktxyCHhde9yLOeufdQKlXepWX9Npa06lHFcYN?= =?us-ascii?Q?6C7kDGIl0hTE0PMZhhyCe325G0qDT0q0bvtzDMqOmck2aBCtnuz22HFfcqho?= =?us-ascii?Q?fqJ5RmOtISeADWYrz3QD9IVhoTdFitfaM/0qTQ6aXLeiXy/HNPSUtwPzIRlq?= =?us-ascii?Q?H6p63iLpb1rlz/f3hNT53w8G2LPRjGfAwa41r6w/1oDLcfm4CzdV9z9OR+xk?= =?us-ascii?Q?8/x50/WykXSrya2v5c/f4oRkkHq3O8UErL1fWWuK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ede283f-d29f-47db-0b3a-08da5b145f86 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2022 03:47:08.5809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kdr+5Lvn6/VElQGs5ygFk+RDGm/YwbUcNjQ95OBsiZ8v0b64SJRbzoCTD7rCIVvcom91tbB5RVfBjfN0oRhuZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2697 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zeng, ZhichaoX > Sent: Friday, July 1, 2022 11:13 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; > alvinx.zhang@intel.com; Guo, Junfeng ; Su, Simei > ; Burakov, Anatoly ; > Ferruh Yigit > Subject: RE: [PATCH v4] net/igc: add support for secondary processes >=20 > >> The RX function was not specified in the secondary process, causing > >> the secondary process to segfault in a multi-process environment. > >> > >> This patch specify RX/TX functions in "dev_init" to support secondary > processes. > >> > >> Fixes: 66fde1b943eb ("net/igc: add skeleton") > >> Cc: alvinx.zhang@intel.com > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Zhichao Zeng > >> > >> --- > >> v2: > >> remove unnecessary parameters, move declaration to relevant header > >> file > >> --- > >> v3: > >> remove redundant code, optimize commit log > >> --- > >> v4: > >> rework patch > >> --- > >> drivers/net/igc/igc_ethdev.c | 9 ++++++++- > >> drivers/net/igc/igc_txrx.c | 8 ++++---- > >> drivers/net/igc/igc_txrx.h | 6 ++++++ > >> 3 files changed, 18 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/net/igc/igc_ethdev.c > >> b/drivers/net/igc/igc_ethdev.c index > >> b9933b395d..7f221a5d34 100644 > >> --- a/drivers/net/igc/igc_ethdev.c > >> +++ b/drivers/net/igc/igc_ethdev.c > >> @@ -1240,8 +1240,15 @@ eth_igc_dev_init(struct rte_eth_dev *dev) > >> * has already done this work. Only check we don't need a different > >> * RX function. > >> */ > >> - if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > >> + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) { > >> + dev->rx_pkt_burst =3D igc_recv_pkts; > >> + if (dev->data->scattered_rx) > >> + dev->rx_pkt_burst =3D igc_recv_scattered_pkts; > > > >Please removed the redundant code in igc_rx_init >=20 > Only the main process will execute "igc_rx_init", and the secondary proce= ss > will not execute it. > So, the data path of the secondary process is not initialized. >=20 > The code that this patch adds to initialize the data path in "dev_init" w= ill > only be executed in the secondary process. The same code in "igc_rx_init"= is > not redundant. Ok, I missed this point, the implementation is correct. Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi >=20 > May I ask if the commit log is confusing, and should I submit new patch t= o > correct it? >=20 > Regards > Zhichao