From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58CA642B0B for ; Mon, 15 May 2023 04:25:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29BA840687; Mon, 15 May 2023 04:25:47 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id ED72040395 for ; Mon, 15 May 2023 04:25:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684117545; x=1715653545; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AFMYhgC337IGxxSePPTanADlnejpbmVYz22bJOX//4w=; b=Dm7wGqwXqYuFSPg82eZCs1wJUujkTpQ3s0rT9JEDbHS7cbl5gZiDhDkC Mv/YuWF0gEB88L7xWptjhTj3I+O2tlJEWcuSFGBp/Kt7sc/p8MytkLhDH ziZiUY51UO7QEQiATTmy5RGjJP0zISelNhiiiV8Crf/6MR7kli3vOBWYF 5Vy9UXnWhWXU+wi/OEokQ+nO6Pz5eskFssUyPYWNplI6GmXqwEKsPUy6/ eEqVR06F/np/EPwXAVJAoSNETco7wZjkqX9K3mEDAMhNL6dzluddMaTvq 0KW1+ru8PzX+TjfyZUMMiCVkJvhYe3mEWHQiXKXWnP904Ej7T5WeQXtc+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="353365516" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="353365516" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2023 19:25:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="733695260" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="733695260" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 14 May 2023 19:25:43 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 14 May 2023 19:25:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 14 May 2023 19:25:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 14 May 2023 19:25:43 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 14 May 2023 19:25:42 -0700 Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB6497.namprd11.prod.outlook.com (2603:10b6:510:1f2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.29; Mon, 15 May 2023 02:25:39 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6387.030; Mon, 15 May 2023 02:25:38 +0000 From: "Zhang, Qi Z" To: "He, ShiyangX" , "dev@dpdk.org" CC: "Zhou, YidingX" , "He, ShiyangX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "Xu, Ting" Subject: RE: [PATCH] net/iavf: fix large vf queues cannot re-use. Thread-Topic: [PATCH] net/iavf: fix large vf queues cannot re-use. Thread-Index: AQHZgY9tOQ4WGd9t+Eizdzzzt+WNC69ao3Jw Date: Mon, 15 May 2023 02:25:38 +0000 Message-ID: References: <20230508165824.2086818-1-shiyangx.he@intel.com> In-Reply-To: <20230508165824.2086818-1-shiyangx.he@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH7PR11MB6497:EE_ x-ms-office365-filtering-correlation-id: 28a045a6-de4b-493f-15f3-08db54ebabfb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D/YSNbMYHdkwYDYEa+VCmTRXoYMkIulCVDttSeRjBXwP2If9Bh6B0DYJMwpZsNZRnGWD9UuY5ojh1ekhePqPZ4p1nX0yYcRjSvlU1ZnJGPB9IuolORtiHJ3gR0QPBif1YD1YfG0iC+GD7gEvyEGUIOvQQXt/GLthOcCRa+bDwJrcjf0VNs46fZCbCv8qKDrj9U0m40UrNrHLWvh+31+AhYJ06rGOoi6Uua46XXocsTkGdQS3IY9XWBdulxynO7H1AWZg/EvJXIxSyrr4qH2xjOj6sZotjBpC64Ef1W2tyixs7+tRpnFElLbhHlB/OLieSLsFWzSHFZ4QUb6FcMnMP6LVD7tUIUx+a/dlgjJU7O7oYYkCCJF1+qL+cxqLb+xiXhQgXsZ4IkYPdyM0WZ4LJH2omneXbLf+WupFpxz7phAYZBsbU6LmIqDljzpPmZUq2Yu0YHxfksDwVAzWanyJuE453EGn0rpUVw3F/TJ11/wRCIGcjb92aw+6WgD0o8Wm/9RSEUWzYF6Icg8m8vdl8iGKHWGur3GTD5E/eHAMfk80JlV1dl5u3aMEYDywajW+2DnRvUpJE5kSADL0qqI6s22bHmlatZ5O/Dp2rT2XHwosWGpc9KeWcBJnYBW29csl x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199021)(83380400001)(64756008)(66476007)(66556008)(66946007)(33656002)(66446008)(316002)(450100002)(76116006)(55016003)(9686003)(26005)(6506007)(53546011)(107886003)(7696005)(478600001)(2906002)(54906003)(110136005)(71200400001)(86362001)(186003)(52536014)(8676002)(8936002)(5660300002)(82960400001)(4326008)(122000001)(41300700001)(38100700002)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EWEXtTa6+wYze37NYoW8JsVFlXVAvrxhsnbStGesRfpgad6Tpt2csXP7CJPh?= =?us-ascii?Q?tSSRd4FS+zjNlx8tAK1Nu/NbxsZtS0+PGsDHnin6Oju7RKFstSvsL6A11BOc?= =?us-ascii?Q?UujjFtEAvoKs8vN55mr+DcFfc5yuPV6HXVA9Q6MuyqN4xbNwPswQxxTjjH12?= =?us-ascii?Q?H+w0r+YbOLRDmhL8kIiC0FL+lxz5BnPp6YW/6e0dHhfnJGwDqLmKs7nd1RKX?= =?us-ascii?Q?JzpnOizeVJyPOcX+0kBtpCXDqSx8WTOTerxFidsT2oCWtpApA2MDG3BiAnpy?= =?us-ascii?Q?40jmuSs3F2BlpwVp2StPqoEm8PUk+ZV3pXiKqRrt8WB6msuHKo4Lupu6QSoF?= =?us-ascii?Q?8SDN/QfeERp3ik/oaUZKuqvRR/H5KYiIwZQLFh2NW3/xXUefhqG1FOc4fs4a?= =?us-ascii?Q?mOld9BbL1s9FdZxZ20o1Vuk7CvF6Efo/8NIv5/vy2Fj2uLKppncMfmGI1DoG?= =?us-ascii?Q?e0voYcI0DZIZDBX8DYCLvAicZQsT3BGvQMDGDpFEb2GaaCV+PShCrF+j4r+c?= =?us-ascii?Q?d0RFxL0S1u4g0toAsUFwqLKP0xjKJlIgY8CoBAE/fbeN/es/+BWPrPAgr/XT?= =?us-ascii?Q?3zeGQkrF62u+rkmZT9xhjCz2tHMzSdC7z7EU1iNPBdZhMEI8Rw9R5YCFc0e+?= =?us-ascii?Q?1UDL5X2KH6JfzRNwSp1CsROvUQcygP/8Cei/Clk8u2TfSugnLRGxTRqbFkEA?= =?us-ascii?Q?fgja2bGa58q6T71mTJDeIT2LNAR0zfjMVgp09dtT4j5lEc2viQ2SlorPXN90?= =?us-ascii?Q?zvIuvWgfKBThBxwv7DEG0o5DP69sF86Ouu+1N+la6sBo9OFcVmnfbwHuEMgf?= =?us-ascii?Q?SslVgq6Q9M0E3W5XpUICW2SjPurQH93GzEIiAhl9uw+1TgJiGFKHUShiDxfR?= =?us-ascii?Q?sCBPLs0yUIqG4VnJBvfOsaEbM0GedsqLKcP7XkXjz1NFHIMqpJlhUhtSUhBC?= =?us-ascii?Q?muiubkja275hrTRHmWeghv620cf10tiMx7qTlq00XZXFfRfJSXawyVVQ9Wx9?= =?us-ascii?Q?n2ck03Yye2PuEgrIviB2FNPMwhrKYglwTifQh4M/rmfysgfm5JzWTxxHHNBh?= =?us-ascii?Q?nK/nbi3719Ezoc0dN9RavfDvnLqcy8+vBtO4AUJ4SCNM8DekDxEfcoR/rmde?= =?us-ascii?Q?+Icee7wUS/O1HGx2AJU2eZgs6Fr3isqgUXLTkPULM+xN0i5vID3bAY9H5Uq1?= =?us-ascii?Q?5T8eGdKlJK2Zkpw6jybmJf9bxr4yUG0zJlqciXHo+BtI2x0lD8hzE8RcxdjS?= =?us-ascii?Q?ukV6TSTh1tBN4mCSnaUC3dP0kHkJKR5VeFHlgkUQJB6RSngYcAm58wvP0VYH?= =?us-ascii?Q?tejOqBmD57RWxytQndBprjXKtmH/bfHm475jPb+viDWitF5U1eqPBp04L0Lc?= =?us-ascii?Q?YVC5n1uDdR3hxVpoSfl3U5Xy0SVg83v1ujBjNU+KHwOZlgys0OsL9hu4yhR1?= =?us-ascii?Q?BjJLRFlQzhFKFDzNUsFZUQPaHP9AW1uRTddsKjtBrv1/MqQkrOmLTLfd/oq7?= =?us-ascii?Q?gztk96NX09voBUtUhQo5obpuWkg2+1RWLKEv/U3rDBzoS5GWBJ8l7RMD8dqm?= =?us-ascii?Q?7aX/WTlQSuRxd6uTghKkuO20a2p43sxg3CwmZEZi?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bjvit5Otg8Pptm+YWaLLPiQqyuzY8fVUmpKvuWsZ/bdXaERLtx3L16gat/XaB31NIpdUnsmm0r+5hpbF73vlEUVahYGOlyqlPquaCkXT+sbsumwAfZM6HLYCNrPsSBkclx38EcyFy6iNEiPXLohfKCm4V3I5WFb0jgcFHBO4m5nGNPUTjV+VGmcJjv23m6K6Pmhm/8wWMKjKNY6Vx6+9Y/fNAMh5gsbJY7Dg+tN9d4HfcC7zm/cdA4EY5GMHnPPWeFnqHQ+oT2DYrQuxwMYOQMdsJLmA6DTLVypNxrOxnRmH3NSzLSmSqPrrFZ4kWrB+HVsLv5DecTAkm072KLzaGw== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fmx10sS4rhEbOH5pmDrUcKgDgVrX7y7dRnObA9xeXG4=; b=V9AE9TwOfV5MDPghD5Yrg0Yn5IL+LVK3Stj98bsurtTbxPq7Lze3wqZ12AgW0VpKbVV14RV52o3SBCHiUO4GEcsu/wRa7+I9/Hr8i2a3Ybbj3H3TcJ24yDHkJP5KK1o8luxF8NTibHyyTily5gY3sI5m79lobs0jFNz4Gc0+HJHP60b3jsLh0ktdokUMZOdi/3WvO++yL0KGyYe9CoyH81T9Bg2Exs6crk134YOyl30I5wskfliYoQaiKGK0O/A8POfv7FHV27kRaPKi5dDbCKiHKICf/6shw6jfZpCCJ+B8nAUcM//i37WJcGN5YyzSot0hg4HWuq6ejZDLKhbZ5w== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: DM4PR11MB5994.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 28a045a6-de4b-493f-15f3-08db54ebabfb x-ms-exchange-crosstenant-originalarrivaltime: 15 May 2023 02:25:38.2103 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: bzjBLi6YdcfTMYwD0uSdfUowjsd/1E3MhCxuSzLfixf4AhvGT+rfBV2YfA7CybosP3O4p6//lqjXVQi8V6Dkxw== x-ms-exchange-transport-crosstenantheadersstamped: PH7PR11MB6497 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Shiyang He > Sent: Tuesday, May 9, 2023 12:58 AM > To: dev@dpdk.org > Cc: Zhou, YidingX ; He, ShiyangX > ; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei ; Xu, Ting > > Subject: [PATCH] net/iavf: fix large vf queues cannot re-use. > > Multiple vfs created based on one PF. If one of the vf requests a large > number of queues, the queue resources are not released when exiting the > program, resulting in these queues cannot be available to other vfs. > > This commit fixes the issue by resetting the number of queues to default > when closing the dev (refer to the kernel driver) . > > Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more > queues") > Cc: stable@dpdk.org > > Signed-off-by: Shiyang He I assume this is a workaround, as the queue resources may not be released i= f the PMD quits abnormally. A robust solution would rely on the kernel driv= er to reclaim the resources during a VF reset. Nevertheless, this fix is not harmful and provides temporary relief for the= issue until a proper solution can be implemented in the kernel driver. Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi