From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A55F142A12 for ; Fri, 28 Apr 2023 04:46:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97AA642D8E; Fri, 28 Apr 2023 04:46:41 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id AB2F340151; Fri, 28 Apr 2023 04:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682649999; x=1714185999; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xHIhEh9SmmBGrYasF+A5xyf6JZriIFfb/kwWuZZ3mns=; b=nkyPlGtXZfyeZ6mThkAJpJxLUWACyHeoqs9vLyAAsYKmDeBHUQvtkCH9 Cl5oIZZJfZnbm+AAi+cG/dFMKVYAa4yP2ndxSxEDMhUMn1adYkCDNpy9U zpZE30kzlVhqNAiyJHVLr/S/AGPg2DzJYpivG7JdCERQyjCaLADWE917F bz2Npdjd6AKdt6e6A6pZ2+Sj7aaURQZ6KAbuoXI7yJSU/nDvTfEMIKxnQ 00t8xj3/vZb5dhuk0M1OhAMmL/Wk/5PEDXqE2tsgtI8InUClpqWRFJ4Jv IKwMfh8h4ONv2xUsaHtkal27ZgH89j/YlqJJMYGBMuLZ7fUplHbLzObEK A==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="349652253" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="349652253" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 19:46:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="725182684" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="725182684" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 27 Apr 2023 19:46:37 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 19:46:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 19:46:37 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 19:46:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zqpmsl5ZkDm+yXrn2legb0LGIy/AVYA78fosUL1yxWPQ9kmXisfpH64bKDFa4iP5pEOA7sdmTRnVVZjO4iNqlMSyIpxZg3/nz1iUJ70OO6zFQ8wP7e9vUOcLsOYUHdCqj1MyiCx30XtuyHDVm5RF8Xx5kNdiOV0M5GbJFK6PFwwjpJndnutrDcLSfDvCXmkxAu0BW6YkzQF9fAC2WnmAkiCy5cWO8i+Xu3SqWASdJrqRO5ECMo/ACZepqn17M0APnxGaczZTDBaLGszCL1xwD6RPCjiXgkSad4KmwfsIxHOOz0CfEJCbx25z9Fx3XXbdXPVv+il1jRiubu5qPgqHCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5HqF3USbExnrc1d7hlGNi3tknJH2zt8CWp8u7dmMTek=; b=cCBw6GCW/GinZAi1Phzc6l+SuVpG6GrMU71on23o6tljX4KR1EkOx/x6toNgZ8iT/cpN7OYCmaZd56QjaoLRW9oqMfVthnh4mpCTTgSYM0FWB8RhEaifAxt9uvAIErNF2AV7/7MycGDjANmKLVoWnFjAnnAOXf5JICgpkMxQ+kYhHlxq5qYZrL7MP+tGKhpNufo42HazDA2LafcBhK5VH22AEB1Edz4yV3DphVACau5mrmr8p0fvIB+cIQclzsWxU+wlNZIYkDCzwR/nI1j5KxQXFsAEOo5Xqc6NJKPKdgp27va14zo7C35G8Ib7za3EDHm0gDZBQI4tYAkujZ5Zug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CO1PR11MB5169.namprd11.prod.outlook.com (2603:10b6:303:95::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20; Fri, 28 Apr 2023 02:46:35 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6340.022; Fri, 28 Apr 2023 02:46:35 +0000 From: "Zhang, Qi Z" To: "Qiao, Wenjing" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2 2/7] net/idpf: save main time by alarm Thread-Topic: [PATCH v2 2/7] net/idpf: save main time by alarm Thread-Index: AQHZdCHVrsDdPTGFrkW1bAxzvYj6ua9ADGag Date: Fri, 28 Apr 2023 02:46:35 +0000 Message-ID: References: <20230420091935.43116-2-wenjing.qiao@intel.com> <20230421071603.55680-1-wenjing.qiao@intel.com> <20230421071603.55680-3-wenjing.qiao@intel.com> In-Reply-To: <20230421071603.55680-3-wenjing.qiao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CO1PR11MB5169:EE_ x-ms-office365-filtering-correlation-id: 9e04827c-ace0-4226-d250-08db4792c82a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e5Bosp7iferUkQFuP10r7taq2fvabEaNd/kDe9KfU3u3KWZPSE2p76plqhw0D6TjpUt7Wua5VrMA4U5Vs/NxelJ769RYTBcOu1g6oo1ONtUhvTWiGLnxCMohnRSJQ/cB9Mh9KNcDaKtD4U4vzWuTdAaJhkQYPR6Efb8T9J/YLnWymCzcVcX8zsnWzeATfTK7LLSaqJar+iacBx/l8CGEI1fp2z9Lf1LzMWTQ65+lRze4xJXtpCOOEidnj0Hma2yy2715co5D1KJJuIydPt6BPxBO6htt6bM0v2WYxdwe4Rb+r6R3NDFSAUDeqlKf9aJVWj8kh63/jfRd216WDEY3kSDOybUy3TMa9xwKDYzYtaihQKWqBPm6/7yPYQdGCHuPZxxizwaZh7UWCFrwtQabc7UQWYZSLn8RTW4yol/QEoMu5Lbb03gzKoMCqbdVZ5rTH4tYOFdGd4yREcfrbxTcGJD8PARkFgbuDXqR1YfrC5qkZOD2r2Hz9RUp/Z/nUgDaYCEWVOthF2+djYGKxfCmgKib1Xe/U59AMXyzJvlKyxXo8MfZmjtlP96f4FN5bq3PRWIuoytgHCl3BTQMYG29PIDdzTVWuezYl3UPjdTcbpEUIBijYxqaP2+ZVbOrnG43 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(346002)(366004)(376002)(39860400002)(136003)(451199021)(110136005)(6636002)(54906003)(38070700005)(66899021)(33656002)(478600001)(38100700002)(122000001)(86362001)(8676002)(2906002)(8936002)(4326008)(64756008)(55016003)(450100002)(52536014)(66476007)(66556008)(76116006)(316002)(66946007)(5660300002)(66446008)(41300700001)(82960400001)(26005)(186003)(9686003)(53546011)(6506007)(83380400001)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Fw1YT8rF8zxaIDvUwTMXKJe9hHityIgsPSagy56HuvPUVV4iy05FHJ5EUXJc?= =?us-ascii?Q?uaHtf8mk8kFpnYrP2nDsBP0dGUjsMwbrAK/JzP0RN2vGdxSwb3DVytIBKadQ?= =?us-ascii?Q?M3hYMYyRdHHAqsahfUf94QGDibeBSdz9ZW6N5uXeU04u8AnGK3DjGiccEDv0?= =?us-ascii?Q?p1O7jJAKqd/oUGgzeE+pKxzOOKh/E8kIUH9BPnjuf4TojlL539bySDyyRMZA?= =?us-ascii?Q?1jJTHO6dLDYhtKqVWvcmCKQdxo5hZ4vLcHx6mC8SWH7cOIwv8dBhfPhnJwIM?= =?us-ascii?Q?caryds3esFmWAGBaKQKwZWH7oSxpT86jtnX/QvI6L9kwdNqm4AnORcxZtTAy?= =?us-ascii?Q?vI3UEAr4kWVtKX3BkkeP/jJU7l4Z2B4zyRDCS+KByINcNoSnpEQRleV27PHs?= =?us-ascii?Q?E8C0n1E3hDWxuFObgIltn72TgMoIx9+7Dm7xjtI9GHY2p4yHkJ1FnPqjKseJ?= =?us-ascii?Q?IvaANFqy8SEaY/wsDoPRsKwPjwH3drUfB1TgU/0G55jD0mC06gf9UTmssuov?= =?us-ascii?Q?dLAaHyLkEIn7a2ItvJKaZPcW+0aRdd+ktMvd//iwAgXK6i1i2T+vvVqdUpX1?= =?us-ascii?Q?v6TOdxdRsZ2kNzFYtg0iwmBUgiZYCm/1QVTEHQcH2C4Ub9NfATWRly0fx1XP?= =?us-ascii?Q?ff/eS+TMAZuS1HRUEndrg2/xx7lUTgKnw+hFuUqvnHh4fR5HAQvqwK8WJqFc?= =?us-ascii?Q?xRKL0UXpwMprLbZPigLJq4QvptU3GKkmnVChy6TbUPOzgZD5hpeMbfxQxNHX?= =?us-ascii?Q?ozr0dbfPhIQJ4/y3P/XrVtyNMNBsRmDpM7Ir2fiXNdzYTELTumG7tGu3MwP1?= =?us-ascii?Q?FcX9o54uSUQCLcV1GnJIysb2D2xZkYGiRG+04K1g2CaG7HLdgQn0LiNt742G?= =?us-ascii?Q?zOjR/SlmAMCzW/q4cO5N4l5pO+4FYbR8vSzZHU2GkMNaeLa3LQYsO25XmmUY?= =?us-ascii?Q?YWzeQyIm4UDazeayT8uz/P+IftoWILY867ahE8jJSPYOKYumPePEunZATXym?= =?us-ascii?Q?gU4VQBLRjGcw5iRHQ/ZAV4MzytdR0h6zPTsN+U5AJ/1U29FYOBvDi2G8ASCe?= =?us-ascii?Q?rpN0NFNVGZv18HEdVIwbF0tQbjx4TatFxOc6EZBr6YNGLuIIc1ljIDpA2RsQ?= =?us-ascii?Q?aSiz4ec3oIj652UomIhNBE94a/gkcPjxQDipAiLSK5WNevVPofRp5wSRxOOf?= =?us-ascii?Q?js98pB3Aepv9vHCCR/uVaP5n1AWA9u7yR6LXZTcHaP5hSpCI9q0AOLn+tmxK?= =?us-ascii?Q?ng/n5KelZMODn+V8BuS7gLKd3/OF6xXMpnX+zJpPXEFDSsvBDFEJbqr5TsOC?= =?us-ascii?Q?76K5ITnssD3ETgzP3I64v6+XC1JUACxXcrFMKM2Kb0e2owRsPLrvwbim2Jze?= =?us-ascii?Q?0G7D/kCVLMgeok3basKyZnabLLUJ3HncR+ORYR64NvMLLskarYXeLQmCrP7+?= =?us-ascii?Q?NLn20o1gNQQVClLSw0lLrzpj0xkoJZ7v6rf820vqN96ILQAj1wnQ9rc6/pRl?= =?us-ascii?Q?S1vaYud6rJWm08XmLGd35Awwx4o4NoUQ8pUYrduON3sGxEFv35HnWjeMQxE7?= =?us-ascii?Q?daoS1txUZhPxqcGRXgT+6LAiBTCIGjbfX6UL8K/Y?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e04827c-ace0-4226-d250-08db4792c82a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 02:46:35.1626 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A/lQzuPT3sBxfkIR8beUUdyghJbPWMdBstkTtIph7L73dR/+PcNp5XgCus2nfPjEWBJ1DZIUTtc07ttaUbeJzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5169 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Qiao, Wenjing > Sent: Friday, April 21, 2023 3:16 PM > To: Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Qiao, Wenjing ; > stable@dpdk.org > Subject: [PATCH v2 2/7] net/idpf: save main time by alarm >=20 > Using alarm to save main time from registers every 1 second. >=20 > Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjing Qiao > --- > drivers/net/idpf/idpf_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethde= v.c > index e02ec2ec5a..3f33ffbc78 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -761,6 +761,12 @@ idpf_dev_start(struct rte_eth_dev *dev) > goto err_vec; > } >=20 > + if (dev->data->dev_conf.rxmode.offloads & > RTE_ETH_RX_OFFLOAD_TIMESTAMP) { > + rte_eal_alarm_set(1000 * 1000, Please use a macro for easy read. > + &idpf_dev_read_time_hw, > + (void *)base); It seems that the alarm logic in the driver/idpf is being continued in comm= on/idpf, which can make the code messy. It would be better to wrap this as = internal logic and expose API like "idpf_rx_timestamp_start/stop" in common= /idpf for better organization and maintainability. > + } > + > ret =3D idpf_vc_vectors_alloc(vport, req_vecs_num); > if (ret !=3D 0) { > PMD_DRV_LOG(ERR, "Failed to allocate interrupt vectors"); > @@ -810,6 +816,7 @@ static int idpf_dev_stop(struct rte_eth_dev *dev) { > struct idpf_vport *vport =3D dev->data->dev_private; > + struct idpf_adapter *base =3D vport->adapter; >=20 > if (vport->stopped =3D=3D 1) > return 0; > @@ -822,6 +829,11 @@ idpf_dev_stop(struct rte_eth_dev *dev) >=20 > idpf_vc_vectors_dealloc(vport); >=20 > + if (dev->data->dev_conf.rxmode.offloads & > RTE_ETH_RX_OFFLOAD_TIMESTAMP) { > + rte_eal_alarm_cancel(idpf_dev_read_time_hw, > + base); > + } > + > vport->stopped =3D 1; >=20 > return 0; > -- > 2.25.1