From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B85D42C98 for ; Mon, 12 Jun 2023 14:40:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F20F642BB1; Mon, 12 Jun 2023 14:40:28 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id BA05441138; Mon, 12 Jun 2023 14:40:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686573626; x=1718109626; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wyOI/6GFv/s7giU8JUTFhliX0EFVoirsuDSgdZ1dXKU=; b=Nde3Dd6AVm1f0detNtfQCRVqg9W1AAtV+Mw2l9J2jijXR0BqtpQGoheK 8Vo+5S/5F7FyQZqd2yIIfwiZyLYtb+w8HfXSfQLRUiUwZkCPaDmtsT/ib lIHwNg2QwnTI+qlhy4yy/IzOXNit6+RLVBgUwW2UhKJ00dMf3ZSqNj/6L yMZ8ILFRJxd99VBWnclJVEBT8c+N9z+EX7wWPD0W7FMmqxnI1CETivr09 7QIUlNgaNwmysl8zHXJvxfkWd3C29usRs1vy2ue3VfYvPLjscpVgyZG10 Fd2IAPJlx8TL9jSULSAccRw9/9vETVe1AuOb2nC3WOTj7P/ycmKeiQSoZ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="356910110" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="356910110" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 05:40:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="776347475" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="776347475" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 12 Jun 2023 05:40:24 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 05:40:24 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 12 Jun 2023 05:40:24 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 12 Jun 2023 05:40:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDEmb0hfaz+9GPWTlLp+0m6Ab+FKHuj2Hxk2v/RMVXYJAvbv1q/P+pcD6gK/kxW0RzmSkk5REkBNR8G5GdNVTPn7z2fYSj7SBcyP+jTsRIKx5mW/EUtSez7x1/aNFz87+zpWzfwZMdpRy8Xx7Hv9h1csIXr22/AVtxTgBNG64haR853o9E2jLgUAcJlfjX31f5+DAKn+6e1smVxpKh+ZboKeoPYASUCnWwakLEm6mxcqI1vyu5iQCi5bsOJGcFPECpPD/MrVQCmBsftStM7VgiNnuEcJha08N3avfH5gPPzu1wzQiVAq8T41ZP9kHdb/a18sN7WtbGV0GLCHpwT+1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/aMU/OE/ByRmFUaJI7WnDXIUzXzXx6pL6be/SlQEVGA=; b=bVQMBtsXSzF6v03F8mIYREO/qOopCKdG6wOI3NTiRQRu4+ubkQpcNkUeOSfXvfaRfhMdnn3wr/TftqJM23y2YZ3+/RMOOhximA5ubR94NxCaIevSLfi3COsF1NDUcL7rx1AJqYPcEW00Fg/pMeaFZ7GsJQZIHrMSDYHIX3ThCmePfNFUepXhrpv9TJ9xOcjggiqvX+p+8GgV/SHwUqvVWpiQvYPnnPIiT+kooeY4r21MHxVaeMGv/x+j4/q7RfhkXxHIKAIBiItx9BgXhpU3RwPsjXoHU5ou6/6OIjg+oSNKBbU82etsF/n0+jmjqwNtHdDmoeS6pjxykX0dwClB9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by LV8PR11MB8486.namprd11.prod.outlook.com (2603:10b6:408:1e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.42; Mon, 12 Jun 2023 12:40:21 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6455.030; Mon, 12 Jun 2023 12:40:20 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Topic: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Index: AQHZmdL+I848w4U1/k+6isYKcDm7HK+Bs5PwgAAbaACABVFl4A== Date: Mon, 12 Jun 2023 12:40:20 +0000 Message-ID: References: <20230608062305.99819-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|LV8PR11MB8486:EE_ x-ms-office365-filtering-correlation-id: f38ec76e-c924-4f14-d4ea-08db6b422f23 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hK8wJwHyOiji2I2PmAkgho9biE0V7BOrWYr/CSvpiG4iylYspyF90kUNk6bH9QW2mxNV4kogz6VJHjj9lx1ESdBl9cjgFW0FTDjteiCTPIikHLkTMhvKIQqKxLiH6B+qR5ZXViaTLwWPl/qN/o3UT53bxzKFSML5xdJW6qcvk7W3HUtu1O2LSFgqM2MDfBLq4ndpVJHht5TrSrQpIVEoWavtcE6WWthYj5BHFXMQUlxH2DmxDga1u8/gF1Ffa6aKPQ0bS8s4XJK20EVRbAW8I/HlKvlul2yQe/O79YmJrkjbRziH34LIMf1ajagFmA6QXmsInEvEe7LY2FRn5c4CeGg2CwW+eujSxXu7WGqPJHs7Ow0b24gmlIMfwCOAqftlurEMdR3q82oC6hQIn7GBfSpI7+4/ZsH4nnH9FSPCj0LIERpP9Es9DD2e67SisikCTjUMWdwzsE0TVPeP/z4CMitOumYpfO1SDrulmDpzSivehfHNzCExRWyOE6O5FvH1Jryyux1wHviAFTD2FknpKNFL84M+M80LBHU2wbx6ce90vdZZW8tllCL8SxCzHV5N3d2FEt4LCnMGdc/ngDOnc9PpFZOgjvEzdmwS3CLPdN1aZlUbs9+uoiryBUCLNED/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(39860400002)(376002)(366004)(346002)(451199021)(64756008)(33656002)(55016003)(450100002)(122000001)(52536014)(5660300002)(86362001)(66476007)(66556008)(66946007)(66446008)(8936002)(41300700001)(38100700002)(82960400001)(76116006)(38070700005)(8676002)(4326008)(316002)(83380400001)(6506007)(53546011)(26005)(2906002)(9686003)(54906003)(186003)(7696005)(110136005)(478600001)(107886003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?MFpoS1MwUEJsa0pTclZnc3FMU05kcExEUWIxMTl2L3VQMkl2TDV0MHR5?= =?iso-2022-jp?B?ZEtPOUhxUXFvQXFHWFJ1OWdKY1NKdGhSeVVranNTTzNDbTBMcDNUbHdu?= =?iso-2022-jp?B?bG1ZRVYrR3M0amxaaFZ2YmcwSFRGRm42SEZsTStML0pPWS9tT2NCYTRa?= =?iso-2022-jp?B?eUE5SzBDanRHbXB4bm5KT05VTW5uSmN3b0M0MFpUY0F3UkhUMWVlb0hH?= =?iso-2022-jp?B?TkNFMU5Xbk1oMHAzbW9SdFJ3dmZhWXJLRUxvOGxSdFRJSmtVUm5pUWYw?= =?iso-2022-jp?B?L0lvSjE2dHVyd08rRGpNMVZWWnhjOE5ZOW0wUkM1cU00WTV1VUNBUUls?= =?iso-2022-jp?B?d0wwN0pSZmRlNkduVm5RS1M0S1FpR1QyYzRjTFZqRnpKSytHdk1hTWEy?= =?iso-2022-jp?B?bXJrVWZ4aHNMcG5KTEFTMmYxVkVBdzhNNFQ3RHYwbllaMzd3TWZEVXVE?= =?iso-2022-jp?B?d0xTVmtxNVNmZjN0OGFIUHM0QllBa04yS0p5UVJWYTdMejd6VDl1aWN0?= =?iso-2022-jp?B?Wm1sQWs3M3BpSzd5MmRxN2xWUlMyNUdhdXBXTVFJNTNLd0I4NFRhZnUv?= =?iso-2022-jp?B?MklIdnBEMUJpanlCU0pwQld4eTdrUXF0amRzUHQyeC85a0NHcFdqK2FF?= =?iso-2022-jp?B?MnVMNElhcjlCTkE0RmJjWmU2RDUwVCtPMUgwVmYwMnlRTXJTa2ZMbml5?= =?iso-2022-jp?B?aU1QaWZMMlg3ZjBlc3J4a1JVVTRHRUgyckVJanVsVXhaMld3RUF3K3R3?= =?iso-2022-jp?B?bEFBNkg1dzVVTCtXaFpndm5ENGRUcVAvakg2TVpqNXhCNXFnaUFRUmF3?= =?iso-2022-jp?B?alhuV0gzRWVXMEJFVFRleGFqdVB5ZFVlenVwMTRnbitrUmdkenBGTm5Z?= =?iso-2022-jp?B?RTQ5YWpEVE4xV2hqN0N3RGVPT0hIdGpsNFhkdmRtdUE4Q0ZFb1N5eGQw?= =?iso-2022-jp?B?akpYejg5Zm9EUU03MGZiK3BTL3RrUEZaK3BjdUpMbUN1NW1EK1l0NTFX?= =?iso-2022-jp?B?N3JRei93V2ZRSFZhWU5hRVIwd0ZkeDdIbUl3a3dYUFQyWlF3clByMm83?= =?iso-2022-jp?B?dHE3dnBGOGEyQzVrZFAwdXBTSUljQk5kMkU4T0FGa0d5cm90TCs0Y1Y5?= =?iso-2022-jp?B?U0dLN2NYRTlsalRMVHdCMVA0YzFiVFVXbHc4VERmREpxeUV3Undxd3dl?= =?iso-2022-jp?B?MXgyNXVwSzMzRUdSSnAvS0hPRFQyZkkyTTQxQkoxbDB5ditna3ZMc0FV?= =?iso-2022-jp?B?WUJRYktxZXhVTFdUclVscHJIT05iZlVpZjdOVUIrbk1uUGI4bzVpTFVJ?= =?iso-2022-jp?B?dUtNU1JGUUNiandBdS9GRzhOQ0tJSS9vTCtmMFhubitzVE94eEtCTWlt?= =?iso-2022-jp?B?OWpGQ2pBMjg5VjBxV2VFS1IzMThpQmtsdTRIN2hqODF0Mk90NWtzcUdz?= =?iso-2022-jp?B?YXh6MWFhcHd5blY1bGF6SjBBZE9HZkV4NXFhS2ZjZTJFcXlvVW1CK2pp?= =?iso-2022-jp?B?a3hvNm13dVp6UXd3YWVmdDF3OXc5L0dUajJMeDNVQmIwZW5vb1NQUjFY?= =?iso-2022-jp?B?RUo5QW5OTWRNclZhMWdWRVJVSzdUNXJLckFScUJQVVNaR3pPSTBPc0ZW?= =?iso-2022-jp?B?NTdEM1h6OFpLdWtaVW52endqUmxBWDZ4MGZpYVlKb2hSUXVtUkRhWGFz?= =?iso-2022-jp?B?aFVTNVpoQzJjZXhYRFJCS2syZTZkQ3hOemVsaVNQSHM4eElWZmdKRHMz?= =?iso-2022-jp?B?ZUdPRGQ2T2VvZWZrQVB0V2xTeEg5QWNuQm9LSHBOTWlIRGFrQ3QwVmpO?= =?iso-2022-jp?B?RTVkZDUwZW1qWGJNbzY1V3dTOEJYdThmdGhFU3ZPaUpQa3RlRGVTTGJl?= =?iso-2022-jp?B?SWR5dWt1UXRjbWx2b21ydERnSFl0dFp4aEU1ak1QQUt2MEpkQUhzMVFu?= =?iso-2022-jp?B?VzNIUFBtNHhXODN6czVSaklZTGRscHhlVmhBQnZlL2xQVlNIcDIxREFt?= =?iso-2022-jp?B?bkZkUEtWV0s4blJMaWpqT09ZT3lPR2NVN0tHTTNpYWR3dEExQTQwNncr?= =?iso-2022-jp?B?NU51c1R4djZLM2VCR09HWEJZM2Z0R3FBQmxCL09ydERzWG5rVkZ5OTBZ?= =?iso-2022-jp?B?Vnh6OVF1UnBUSXBjYWVUUDBnMlYrdlpEL1M0T3ZGSHZOaUFjN21YUmFs?= =?iso-2022-jp?B?YUptSTlwV0xQSmJsMDBvdmdXRk5wMGdnVDE2cVdiblkvVkhtaGlEK0tZ?= =?iso-2022-jp?B?cCtMWmc3cno4UmlMM1lrVzhER0pvakJhOVhIclJwSk9NWm82ZUVwSXNJ?= =?iso-2022-jp?B?TVhuMw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f38ec76e-c924-4f14-d4ea-08db6b422f23 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2023 12:40:20.5762 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cU0+3JChEriUyPI8pA6AYSZcGu3cJmZHusMr9HCvZQVnJ1h3CGtdjjT64ydYmTxBufq4ZtLfVuA42uGRt7/6fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8486 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Ye, MingjinX > Sent: Friday, June 9, 2023 11:20 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: 2023=1B$BG/=1B(B6=1B$B7n=1B(B9=1B$BF|=1B(B 9:48 > > To: Ye, MingjinX ; dev@dpdk.org > > Cc: Yang, Qiming ; Zhou, YidingX > > ; Ye, MingjinX ; > > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > > > > > -----Original Message----- > > > From: Mingjin Ye > > > Sent: Thursday, June 8, 2023 2:23 PM > > > To: dev@dpdk.org > > > Cc: Yang, Qiming ; Zhou, YidingX > > > ; Ye, MingjinX ; > > > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > > > Subject: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > > For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the > > admin > > > queue has the issue of access overruns after disabling interrupt. > > > That results in FW disabling HW interrupt for protection purposes. > > > > > > The updates/changes in this patch: > > > 1. Remove the polling admin queue processing and use the generic > > > interrupt processing instead. > > > 2. Release redundant queue resource before stopping processing > > > interrupt events. > > > > > > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > > > Fixes: ef807926e148 ("net/iavf: support requesting additional queues > > > from > > > PF") > > > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel > > > message") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Mingjin Ye > > > --- > > > drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- > > > drivers/net/iavf/iavf_vchnl.c | 48 > > > +++++++--------------------------- > > > 2 files changed, 23 insertions(+), 50 deletions(-) > > > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > > b/drivers/net/iavf/iavf_ethdev.c index e6cf897293..ba5c88a1ec 100644 > > > --- a/drivers/net/iavf/iavf_ethdev.c > > > +++ b/drivers/net/iavf/iavf_ethdev.c > > > @@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) > > > } > > > > > > ret =3D iavf_dev_stop(dev); > > > + > > > + /* > > > + * Release redundant queue resource when close the dev > > > + * so that other vfs can re-use the queues. > > > + */ > > > + if (vf->lv_enabled) { > > > + ret =3D iavf_request_queues(dev, > > > IAVF_MAX_NUM_QUEUES_DFLT); > > > + if (ret) > > > + PMD_DRV_LOG(ERR, "Reset the num of queues > > > failed"); > > > + > > > + vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > > > + } > > > + > > > adapter->closed =3D true; > > > > > > /* free iAVF security device context all related resources */ @@ - > > > 2772,18 +2785,6 @@ iavf_dev_close(struct rte_eth_dev *dev) > > > if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled) > > > iavf_config_promisc(adapter, false, false); > > > > > > - /* > > > - * Release redundant queue resource when close the dev > > > - * so that other vfs can re-use the queues. > > > - */ > > > - if (vf->lv_enabled) { > > > - ret =3D iavf_request_queues(dev, > > > IAVF_MAX_NUM_QUEUES_DFLT); > > > - if (ret) > > > - PMD_DRV_LOG(ERR, "Reset the num of queues > > > failed"); > > > - > > > - vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > > > - } > > > - > > > iavf_shutdown_adminq(hw); > > > if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) > > { > > > /* disable uio intr before callback unregister */ diff --git > > > a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c > > > index > > > 8cc5377bcf..579c0d0d70 100644 > > > --- a/drivers/net/iavf/iavf_vchnl.c > > > +++ b/drivers/net/iavf/iavf_vchnl.c > > > @@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter > > > *adapter, struct iavf_cmd_info *args, > > > > > > switch (args->ops) { > > > case VIRTCHNL_OP_RESET_VF: > > > + case VIRTCHNL_OP_REQUEST_QUEUES: > > > /*no need to wait for response */ > > > _clear_cmd(vf); > > > break; > > > > Have you tested the "large VF" case ( > 16 queue) with this patch. You didn't answer my question. > > I assume event VIRTCHNL_EVENT_RESET_IMPENDING need to be handled > here > > then to trigger a device reset. > > But I didn't see related part in your patch. >=20 > The processing related to the "big VF" is moved before "adapter->closed = =3D > true;" > to make sure it can be handled correctly by the interrupt function. >=20 I'm not asking what happened during dev_close but the init scenario in the = large VF case,=20 dev_configure-> iavf_queues_req_reset-> iavf_request_queues this happens at the situation that is no interrupt is enabled and it need t= o handle event VIRTCHNL_EVENT_RESET_IMPENDING