From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>,
"Deng, KaiwenX" <kaiwenx.deng@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhou, YidingX" <yidingx.zhou@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Dai, Wei" <wei.dai@intel.com>
Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
Date: Wed, 8 Feb 2023 03:23:11 +0000 [thread overview]
Message-ID: <DM4PR11MB59946B2CA9DCFAFE2620CA22D7D89@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB1886325160260112820329A2E5DB9@MWHPR11MB1886.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Tuesday, February 7, 2023 2:41 PM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Dai, Wei <wei.dai@intel.com>
> Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Hi,
>
> > -----Original Message-----
> > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > Sent: Thursday, February 2, 2023 2:53 PM
> > To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> > Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> >
> >
> >
> > > -----Original Message-----
> > > From: Yang, Qiming <qiming.yang@intel.com>
> > > Sent: Thursday, February 2, 2023 2:10 PM
> > > To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> > > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> > > Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > > Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > > <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow
> > > API
> > >
> > > Hi, Kaiwen
> > >
> > > The code looks good to me.
> > > Can you ask someone to test this behavior and add a tested-by?
> > >
> > > Qiming
> > >
> > Hi,Qiming
> >
> > Peng Yuan just added tested-by.
> >
> > Kaiwen
> > > > -----Original Message-----
> > > > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > > > Sent: Saturday, January 28, 2023 3:15 PM
> > > > To: dev@dpdk.org
> > > > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Deng,
> > > > KaiwenX <kaiwenx.deng@intel.com>; Yang, Qiming
> > > > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>;
> > > Zhao1,
> > > > Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > > > Lu, Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > > > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> > > >
> > > > Add IPv6 addr mask and L4 mask support for rte_flow APIs.
> > > >
> > > > IPv6 flow rules do not take effect in ixgbe when set
> > > > IPv6 addr mask and L4 mask to default value as 0xFF.
> > > >
> > > > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
> > > >
> > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > > > ---
> > > > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > > > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27
> > > > 100644
> > > > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > > > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > > > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> > > > rte_eth_dev *dev,
> > > > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> > > > rule->mask.vlan_tci_mask = 0;
> > > > rule->mask.flex_bytes_mask = 0;
> > > > + rule->mask.dst_port_mask = 0;
> > > > + rule->mask.src_port_mask = 0;
> > > > + rule->mask.src_ipv6_mask = 0;
> > > > + rule->mask.dst_ipv6_mask = 0;
> > > >
> > > > /**
> > > > * The first not void item should be
> > > > --
> > > > 2.34.1
>
> Acked-by: Qiming Yang <qiming.yang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2023-02-08 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 7:15 Kaiwen Deng
2023-02-02 6:09 ` Yang, Qiming
2023-02-02 6:52 ` Deng, KaiwenX
2023-02-07 6:41 ` Yang, Qiming
2023-02-08 3:23 ` Zhang, Qi Z [this message]
2023-02-02 6:29 ` Peng, Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB59946B2CA9DCFAFE2620CA22D7D89@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=kaiwenx.deng@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
--cc=wei.zhao1@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).