From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD5F2A0547 for ; Tue, 31 May 2022 13:52:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2B1640A87; Tue, 31 May 2022 13:52:03 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C5DA7400D6; Tue, 31 May 2022 13:52:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653997921; x=1685533921; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rJrMPHX/EKELAyRxr4HyfCqtuot+G/mSepjgZ1IWkkE=; b=hlJOB+OJbKAkPzzwzZe3Kd/eggFOvNThLNvDaiITpUjHsmOjLpBJnRQ0 LqrOb7XzHkRJrGgRGJsaE2MkYq1SxiqCYWOs83A5j9KEdf/zSewZPuD4e UZO7WDvaua+v6Ud+FkotdXw/OZmO09UpqENr3D11O0ikFFpIFxh7iJcQL 0W34V8vPuJZvmCIgydSyiDEQSD1NXrHrvavOkCqO8FIIH8A17IjYzqxPi 1attZwb0ZQCHxj5qt6aPQLO03Nnwisloooj+xVztdF90W4OO6ZG+R92Dq 0558945L/Lhrg8vxsr1en+yttVZ/BNNuE8ULlpgsKb32gIpKSqggesfOL A==; X-IronPort-AV: E=McAfee;i="6400,9594,10363"; a="274035434" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="274035434" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 04:51:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="666886396" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 31 May 2022 04:51:59 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 04:51:59 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 04:51:59 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 04:51:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AwlZf2Y9LDNd3kOgkfT8igcnwwOsydwFip6VqsCWWZkh9NQdcdF6r+/GQMrZ4YXKCB2w2z6yZbdNbdlwvBTclnKv7NYZxhvVz628dPXl/AmM0cVxFq+No6ofsMzH8NsUQ9WLnYH5O9o44rZZ0182V0K6v3FUurjWqNcdEMno6wtqTOIEny1UROVKpC83rClZnojfNHFvvqFH7IhRM5KsGMwv6qlXTSkPQq7K689euUGrCGOqvAzHLSdNW6McoD5qsIKNni4JSXj98cIi3eEA8QhXC/N3ZHFG1hUjpIC0sm0vIEDwfbDtvOeX792naR6glsALssImaE2xRxzAOTB+TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bLc3ZOZkYmsI8/BDAewFJDYUHGSv5lwjQX3mtP0xEnU=; b=RdVelp/pvem142ywNLuLpApFq3jRIiuQ3I0la6YPc9eH86PluSISvyMAQe352mXUlnW6LtkCEqw/5r+DxjTq8kQ6z4GB2OIlacTKrk8+XiTPECcGYGIR32GCJHw6gNd2dVpiNuc+3p7NAU6xFYpbcIS/A5I3kT1/OXEht6ejfEZjxyxgfwDD+kuQIgMyT8ApvKVA4F279WY6ak8gNSRHW4YCL6OWQOeDuNMbsAvPZpnl+5Px/AvLdi9LCSF+xs/nQY/QkJtgKaJzR91W8Xj9nUE0o3ZrVILwWTWm2y00Mv6tChXy8PWreAhoruwPTvtCDCG6v1dYn3+iiexYGW5sOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CO1PR11MB4770.namprd11.prod.outlook.com (2603:10b6:303:94::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 11:51:55 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%6]) with mapi id 15.20.5293.019; Tue, 31 May 2022 11:51:55 +0000 From: "Zhang, Qi Z" To: "Zhang, Peng1X" , "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after failure Thread-Topic: [PATCH v4] net/ice: retry sending adminQ command after failure Thread-Index: AQHYdNSiXBpek/VeY0qC3RcbCZNBtK043Tlw Date: Tue, 31 May 2022 11:51:55 +0000 Message-ID: References: <20220520183112.26546-1-peng1x.zhang@intel.com> <20220531174827.357629-1-peng1x.zhang@intel.com> In-Reply-To: <20220531174827.357629-1-peng1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f255078-d1b6-4df5-73c0-08da42fbf595 x-ms-traffictypediagnostic: CO1PR11MB4770:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PAc80t6p8AQs7CK+GsU+WEUBiwVWYKWmNUkI9NSffVGLOMlqMf7FD64ad1FWmMY6LJMEj94our3APOr5qLk2RFMjukeDM9pgxRhoNllg4jcy+ktkkdxUA+We5L8m7gitycF2KxFwmeKvWlRSpohywjBDSLUBIsBGcJ6y2ao5j+d8CjLNU6nK7SuPnEgGxQskvLOFo1jniLUxi9JFCEsZzApeLFRoypAaN2ylL1e0omBxHHdZrwP/yI7jalx+Ri49bTHzZfJWP0a/4JM9TySAfBkS97LEkyZNACJ/X+SQbNIUVytZBQJvzE6CggMde3FfEE3VtVvNJWdGaAyPp9WrBzv2a3YbxhLorKQQm738BMHJ/4A6FuE/ygylyoW6zSYHSRoRjE7xXeWkF2dpi1hxjZSGJXJPKA2jCx2S2szl/UQXdzKu++2YrNxXNpOfthvEFhj+vpLhvfjKzqR1dzOIQ0MdDvIxcbbvjlMRhclsCph4TN2/RPpJWmvoMET5tR59b/DYhoNE5SAvdM7GLwMmoYV2mt4wkpE9Nqr/3ISGyh3OMWpMslmHca+z3vcVRvXZN0CeLHBWBuvdKqf+UJD0+Mlgm+oFcWIZJjVrITCo4CHARSl2rA9P6BCOdTTvSjcjDi8uRCAfvdNymFuPV1vBJSZ3DpMsGu8L/LWcTQAYjPAlZ3YaVIxelxjpzkt25Ph9/WwMaTeVc6lxRQQHOKjH6Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(9686003)(186003)(53546011)(7696005)(6506007)(66446008)(110136005)(66556008)(66476007)(38070700005)(450100002)(82960400001)(316002)(122000001)(8676002)(4326008)(64756008)(71200400001)(76116006)(66946007)(8936002)(38100700002)(5660300002)(508600001)(2906002)(33656002)(55016003)(86362001)(83380400001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sK8FcslsQP2V4y7j75g+/1xU2OafIGE7glVdp8r7NSa2BEa9lRZvue4S+BDe?= =?us-ascii?Q?shqN8rV5oZYqvcIr/FALPH1wMeix56yCLBl9W9HPty9J199ci1qWAT+CxNZn?= =?us-ascii?Q?r3Z+fZycDIQbzTg+K68kUs7MvulACOVwsITP2iYCVjneYtJCbAYhPHmMeWw+?= =?us-ascii?Q?OgSJsgHvzRGv7o5PJHFaL8GFYnATq5qu+gGepR8INqefeNrnBhUplNa2hWHv?= =?us-ascii?Q?Orl78aGGN33XJ1PoDQldmouD2jo0IT4icyi/ryox1MtAF9hWZG/eSujmkzCk?= =?us-ascii?Q?rQdv3sINBBfWelhjOM8zA5N4y7p08Dg9GkME5LCslGcjg5PNzD2qh2Jp0mI+?= =?us-ascii?Q?kEVz4FY1agP5gCepiSnN4WZtw1wOnfbqr/AfnH0Gz9gBtUhxoxNKtf/1Iek/?= =?us-ascii?Q?F30oU7w5n3x1muXTqQyeBG8H8feHtUXkqT/z8sjAOKOqQDuAGyIz2pSZ0Z8i?= =?us-ascii?Q?0Q5u2cKicUCueSLnH7vdNx/HjVSBNmKkKivut4a9sblGiyNXFP3meRrBATtG?= =?us-ascii?Q?AYy3JXjYHoq+gVJuo9qs58zGGhGSbukWF2z3zP8gDwHs5VDqeevLhgLF9yV9?= =?us-ascii?Q?US8vnvIr5k411nSu6WXuANtFvKLqlCsy9enbkuT7M25eFaTckIhhI9pror3Z?= =?us-ascii?Q?/fa23DnzzKb3ysIWEk0ib6CNu6KhhL3HgUJkIWKDihlnuYX2k+tXHGpSe39q?= =?us-ascii?Q?EAoR3WCDEoO2GN/va0JVEpB3KBvSAA4W5nyjVbzwYkJ14sDxP7Bw5eTHdt44?= =?us-ascii?Q?+vCYCu59UIxV5WbPtjB0STEF6k+E6Ky2zdejJWp7WACHXGov9FhzJqW6JrBb?= =?us-ascii?Q?3YvHr7Iy8jXL/qupMhNS+UgUz+OxRN871BIpXN6vlArGDya69rfEv09eFsV2?= =?us-ascii?Q?2pr43qGfPcFNpPHsPgEGA8I46ZEdhJBSP1OwKOBN9zl/eAeaidiTVW9VGXPs?= =?us-ascii?Q?ZBdJblOn4z9ZUJEU5P+Z9muOketE2eLh3Fw5l8dmNdhODWN9LwbES2dAmLtA?= =?us-ascii?Q?LjoH9z2fGEu4ztMnc+b1yj8yLlgbIyLL/jBtflvTeAw+icnXXcfocmzU6sgG?= =?us-ascii?Q?L3Cc64Wl/DSnNW4SB9/N4c4LPoGkAC5UH4AnsT2XUAFHJVOUG5MCJ2jtxKOG?= =?us-ascii?Q?O9wwNDsmjpIkro1jIKaBu56+aUFV96gc+p3guK5prUA/GMgDegw+Y2NS/6cD?= =?us-ascii?Q?VBma1giCft1qQIGVI3S8B6Oo/pEFPgegjZ0K/PlwTUSaJVIqFQvJfDJJphSF?= =?us-ascii?Q?vwA2WhHDIRhW0tPHthvA6qlctR6PWz/Cw/BJ5ez4rENCVyXNIrSnejAdhkGO?= =?us-ascii?Q?TNe+ANhKW9J3W6+WUiebOM/ISLXa/BFWiCPpl7iRm+B5kxOPfUUcEb0pJQ2G?= =?us-ascii?Q?fdRpXIWKW59agWhIyXXhsqsqKFkjsddITJsuV+mjcQ0ISmCE2axyAfKLchI+?= =?us-ascii?Q?Rk8k7X8SLGBXa2OdbcY838W+4bM//4GCRMIO3LBne5RQb2HFk3dsJuI5JswP?= =?us-ascii?Q?k4UV2eHOZ3WcLt8n8SdN3i1TgeT+iStkDELH1Q8Qi/zGQWXx0fNqBanCBijw?= =?us-ascii?Q?qvkj6xBceSgO490n+0TJbCh93Mr1IBP9sKC2JiSExWWghl4gAXdPsauV22H0?= =?us-ascii?Q?BSzVc3qiqjp9un6VgqvSsTWI64+zExc37Xt4gFFuWj+ARTWSyvZwtUAADWB3?= =?us-ascii?Q?P6DckXJN0NaaUjx1/OBkLr7YD0U9ubAAc+gM6sc5x7Fcy1QF/fxlCxXb+43Z?= =?us-ascii?Q?uzto50IPTw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f255078-d1b6-4df5-73c0-08da42fbf595 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 11:51:55.0627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4BOn8mh0x9Y/HDjlGMTOv+8ipEvF83TKaSmnptOCaCemMxl5+A84xdW4ObzVeuxPe5wInIcnqEBqvck+lPhmTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4770 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Peng1X > Sent: Wednesday, June 1, 2022 1:48 AM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Zhang, Peng1X ; stable@dpdk.org > Subject: [PATCH v4] net/ice: retry sending adminQ command after failure >=20 > From: Peng Zhang >=20 > The origin design is if error happen during the step 3 of following given= situation, > it will return error directly without retry. While in current patch, it w= ill retry > again and again during certain time. If retry succeed, rule can be contin= uously > created. It will improve success rate of creating rule under following gi= ven > situation. >=20 > The given situation as following steps show: > step 1. Kernel PF and DCF are ready at the beginning. > step 2. A VF reset happen, kernel send an event to DPDK DCF and set STATE= to > pause. > step 3. Before DPDK DCF receive the event, it is possible a rule creation= is > ongoing and switch rules, recipe, or vsi list related adminQ operation is > executing. > step 4. Then result of operation is failure, it will lead to error return= to DPDK > DCF. DPDK DCF error code will be set as EINVAL, not EAGAIN. >=20 > Fixes: 6bad5047be24 ("net/ice/base: return correct error code") > Fixes: 453d087ccaff ("net/ice/base: add common functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhang > --- > v4 changes: > - Add retry mechanism if fail to send adminQ command under given situati= on. > v3 Changes: > - Add the situation description, expected error code and incorrect error= code > - in commit log. > v2 Changes: > - Modify DCF state checking mechanism. >=20 > drivers/net/ice/base/ice_common.c | 2 +- drivers/net/ice/base/ice_swit= ch.c | > 46 +++++++++++++++++++++++++++---- drivers/net/ice/base/ice_switch.h | = 5 > ++++ > 3 files changed, 46 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_common.c > b/drivers/net/ice/base/ice_common.c > index db87bacd97..013c255371 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -2127,7 +2127,7 @@ ice_aq_alloc_free_res(struct ice_hw *hw, u16 > num_entries, >=20 > cmd->num_entries =3D CPU_TO_LE16(num_entries); >=20 > - return ice_aq_send_cmd(hw, &desc, buf, buf_size, cd); > + return ice_aq_retry_send_cmd(hw, &desc, buf, buf_size, cd); this is the fix only for DCF, we don't need to retry in a PF driver context= . Better keep the same function name, but implements the retry mechanism insi= de the function, and should only be triggered when it is in a DCF context