From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98FE1A00C2 for ; Tue, 17 May 2022 02:57:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C8B341109; Tue, 17 May 2022 02:57:56 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 3F38D40042; Tue, 17 May 2022 02:57:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652749073; x=1684285073; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0BEVfZaqc5V2rqtA9LoVezYduGKJDU8eECBUmhrDWrM=; b=emCD2lRU8wtL3HVK/YUl3U6SmA0JMX3BNK4JCQk3IYPcH/RgmwsXFjxI JFj7b5YcDM4+SbYRmHUjqL3gmOdTm7BmJrD93CRoWW+jS0W+uPR5HyjVY eRKreOqPrQwVD5KcIByFOs3RqEXB/AwVjnTrZLgMZHOuKMp+G0h13AjDL kM4tUVwczcA3jZcsQlfbxO0ztRBWaWNsB+MO1ddzwKAQgR5M4af5RDByr TcTC9OHbrvFTmfVxw6wvaj7sT2T8Yv3lYDf5DHA+KTl6MetBP8UGFx+g7 L6slKqh9dXFTd8kgzWN4o6N/dbF5q9PEwwp7kWVXMNpPMV9ZjanjhTLph w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="296283683" X-IronPort-AV: E=Sophos;i="5.91,231,1647327600"; d="scan'208";a="296283683" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 17:57:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,231,1647327600"; d="scan'208";a="544623808" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 16 May 2022 17:57:51 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 16 May 2022 17:57:51 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 16 May 2022 17:57:51 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 16 May 2022 17:57:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIvKE3hdI6StGTxUE4QVVwpNX84WFwmwG45/TeiMBszb/Vb1hXzGi/1AKEko6B2F/jjgEYe1cm2jZgsi3G5h0+0A4BkRHadEzrn3meSP8DCshEp0WEnqEswgreuABTWFT/h+DGgib5ZAFY7uz2isycSHw5OIkVjAcZf9T5X8AgM75m4cU3ByeBfv8BrUqPaxo5APpLem+kyF2oilWY+FTG1jrW5xpXQICOrq/3JkT/p97t0e6axjUpVz7ui7qXU+wkmCBz6YXTAoy+DIDve9R2Z6tYU0gyQcwYvzXWHo77q8qJToYKcbfWMXkb7OukZ8fw5+9k7BSbs7T7t9w7uCXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8zm8EFChRLzCc+slb/46vEKBZkKqrlmLeyRkKtcyNYM=; b=ntsZJzdyo4DsbD1/g5NJ/DGFCqeBD+JQWmyxJKXttc2ZmoaZx6cHZjNNZ7NGupJ5tpdWT4FbG2/Jr9VnncMdtscMbqj/tU2rZ8pTWn1Z6bjQp9UJt/9Hb/wWn5e0KPIvyI0OlulNnAphS8EM1b9EqapfnNIgA29+mIGIrEJ+QM81is1B2/CWykpJ7EHYq6HbDrTXHe6DuTHFl4w+lLDhJxai2r3kD0NwkS0MBZ7Vgzao0JjqzH0VzVzcZE69PS3suUJ8MAyFUMDOhWZfx8gxG9aM/nutluACjrVWDdTCfMLv+NFJWvuEdFxQE5u0aP363uRhPlqxha0wEl8dqzdihg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BYAPR11MB2918.namprd11.prod.outlook.com (2603:10b6:a03:92::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 00:57:49 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%6]) with mapi id 15.20.5250.014; Tue, 17 May 2022 00:57:48 +0000 From: "Zhang, Qi Z" To: "Zhou, YidingX" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" CC: "Yang, Qiming" , "stable@dpdk.org" , "Yeleswarapu, Ramamani" Subject: RE: [PATCH v2] net/iavf: fix mismatch between rx_pkt_burst and RX descriptor Thread-Topic: [PATCH v2] net/iavf: fix mismatch between rx_pkt_burst and RX descriptor Thread-Index: AQHYYggIymU26kq8NEGZQYZlYRLD8K0VzaJwgAMDIBCACXuRMA== Date: Tue, 17 May 2022 00:57:48 +0000 Message-ID: References: <20220507093637.127591-1-yidingx.zhou@intel.com> <20220507195239.250067-1-yidingx.zhou@intel.com> <16094f5ab1604c06bcf7ad322a649ebc@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ee7bc7f-fc97-494a-523b-08da37a0433b x-ms-traffictypediagnostic: BYAPR11MB2918:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4E4T5Zc+itQgtP1lkPwC1Cawx7nL8F3T8J4PUmuY5s3ZLQn8wYqqj0+EVb4MT311wDGJctkmODYZ6pypF9QJ5f9LyFFvbKh9aTGJH1zHmiceOK4FO87KXlEQA8HHv/flM0zLz9XcD1Hm9t5NMYLkci/17wN+btQueti7ydquG05TZaQ7fxXtXuNqRw15dpHxvSaPYNwMkY+rexz+KVhXDrnxflk+oAwKPEwsS+yaP9sGw2wqwkrCH2buT/WEg5Vn59fB1zPG37Vfaf0mhgiNwiGKVVNmetkyHjApB4hd0bIyuiSnj0vCsWjHQLJIrR7Hy8E5wJsO/cJElM2S9huCIJIu5QU5mSJds9IhzOfNLHreq/thZ2GesXNWGR37i0kZ+EA2r9r0nJXgwplRqnkSibTK+MlGk91uasDoa9jScV0BUDnZu47C2Ax+QLpzIkMwzEKEf+UJBD7ldeg0hh4oEpT/UaKv2zfS5f9HmJA/fjNrEwrH5RdriNSSPNVdN91Lpz58+V3fD4KWOjEw40PdxfcvjDp3FTPR+V+vu3iDHDWSUgWvO79dZFzYVa8H8TkV6x9kjWXtZaq8KLcDuv1NkXVrlNbVCRdQK3EeSkQNNcLoxotiaougLaN+Fb/eFMHWWOB6+3ZjcD8L3/4Ea7uLWCzEK6yrd1ZqdloTr1OLFiB93/BbVLwfm42spiu6AkkxU8Rm/Awh3aHqLcxSl0etYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66556008)(8676002)(450100002)(66946007)(66476007)(55016003)(6506007)(66446008)(76116006)(64756008)(6636002)(33656002)(186003)(110136005)(5660300002)(38070700005)(71200400001)(82960400001)(38100700002)(26005)(9686003)(86362001)(107886003)(122000001)(83380400001)(8936002)(4326008)(2906002)(316002)(53546011)(54906003)(508600001)(7696005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6GLprfsqrZ1ThOvVq9/EucwQ+gsSznmtMDVfTOwpGixX8Yb6uHt5A1sdnC8x?= =?us-ascii?Q?TllEf9FDOfVnmV5TlhdPQ92HjRRQKvE92JB/rs2SNgfIwmXJBG29f7qPgACD?= =?us-ascii?Q?LP9MOu+QrUxuE0q8aXiq3Lwsgr4nGfhmL3mlugSwNjshDb2FQM+cJOqIsZaQ?= =?us-ascii?Q?1P4wRN63LBF1Ew7YTVieFjcn8N5P8CNbRR3nbmjruhJbcMAa1Dc7ccJ5F9dv?= =?us-ascii?Q?YTSpgr1Rv0ktmYXNEnD8v/e61849kykXbzE0aiI8DIpwxwi2r9+vV53ThGCA?= =?us-ascii?Q?WwbTL0ai6UyXNBOfC58PZq6SfzkA33vDclEHeb2bSvW50uSGWe/aakLna/qU?= =?us-ascii?Q?5sM9AzWixbWF7nY5a2UntlsYQd526YEFBCig0SoFyoahYE+ho6ZVa8EHLzFi?= =?us-ascii?Q?fD1n3P1BYyuvo5N7eBv9WxM96fcYF2JyqEAWoTKjdw3ATbWppAQJUU1Ze31k?= =?us-ascii?Q?PkWMdUAPz76AWUWBZ5a8G+Bu2SFC8bpYwLU2TzStgdQ/i2SNltngAigOr0Hg?= =?us-ascii?Q?pH1VT1lF1wlGNwmed1Ph63IrpKD8N8q3ip0Qs+9OzRGzG+74obL2mf24UGUB?= =?us-ascii?Q?q5Zi4yGr28CeAf4N1MMWQtvzJHmAPhJfbnjOaYzJZRWiU2HXCOPaiYgLzhX6?= =?us-ascii?Q?H3jtE0CIO5EsotU9F++R/auvCxdlR9ZJfEZa8GH+Cs/wW4PefHqSgbi/nH3d?= =?us-ascii?Q?dBTZnH1W0ihoYhiu/6AI6TICXbg+yLy7SkP3M+BXkZ58I9gHjeac7xHp4aQy?= =?us-ascii?Q?QsXJG/EcW7/0VKNgl1vN4ikuR4ZnM7sGLPve5kyyfgKcE2cE/vFeUAxCs9PH?= =?us-ascii?Q?pX83TCYLE2UYc213/3DC2ogna+ljuLqDcoHv+nLsSM4muqBpj8skMsXxmd4j?= =?us-ascii?Q?Pjg+ojbEsDtp17wX05pDytRG5dnBebtYvy496ngPYoWWN+5W3rYlG8lVaTml?= =?us-ascii?Q?vpXnjFYRNNkGc7pWsMRhBaSGYF1Cg6tLisxxV2Re9s89RKSsuZoXTJ8VDiEX?= =?us-ascii?Q?Jl41YUfZuaKd3LKcnPhFPvJ/8iN5VjM6YB0gkJDtCJNY6ICH7NS4Nv6+zKFm?= =?us-ascii?Q?2/v1PpChIMXol8fzTVXI0AOT/dAhT4hkj67dMmnmlwFm4MdQkZ+VtKDXI5Ge?= =?us-ascii?Q?82+iXCa3UMF3nnXjNN6HSuCTwcNdfePyjInZdV+MmkuGOjnQ59jjzAHuU3LY?= =?us-ascii?Q?DLUfOa2Di0qzjvRPiw55Tkl8ku03MFUYuiRvXYiBJ8Ta30YlHaB4s8o6xbJM?= =?us-ascii?Q?8XVMC7XvjdAcb6dMZCqWQR1k6PX6gVlxK0WbLsjYuzBbpAk9W1g5pz9v9e/z?= =?us-ascii?Q?nBun5rDRFUJGqg5m7Fjs88gHEBtBjcpWpKFBJu2UTaeiTslKeW5xoqOe+DVL?= =?us-ascii?Q?mXg4PqJu79M4int97mnlJ7mpGa/y8Eulb/g4hTgzPa27IQqmKeqOBxb8/moD?= =?us-ascii?Q?FhJRwR+XpLAw+ye3TVhbqrlbN0Er4dgs15C7rI+y72uS5V1IQOwZKtSB2XUt?= =?us-ascii?Q?4YJTXW210vqJi0LpfqQUyjFajdcz7Wwmdua9gbqdOQX2Its5EoUMvWifrKXu?= =?us-ascii?Q?fvi+cv90+el8CkAWSvF1t84iWQCi7yK/FX10M48QIToLaGaaL0KMTPa/wv3U?= =?us-ascii?Q?dRI02MjKsssEEQT80NwPVPm1Agvbugh/H/TsCA+Onvq2LRc2kvJ52X9Ni/w4?= =?us-ascii?Q?Lsp/rbh6LcNInHYl4hSWyUTBBbAYYdeefXc3qNCLuEofwAfBAlZq3gRkEU8L?= =?us-ascii?Q?aCR3u0DDhw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee7bc7f-fc97-494a-523b-08da37a0433b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 00:57:48.8290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l/B2CjIiIRTajB73OxpO+Ee4jifmu6uM5L7/Xgnfg4JiFaltqv4iuUynRM5Dzeo/fPoNNb4zS6oNiyIKy5LvIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2918 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 11, 2022 8:04 AM > To: Zhang, Qi Z ; Zhou, YidingX > ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Cc: Yang, Qiming ; stable@dpdk.org; Yeleswarapu, > Ramamani > Subject: RE: [PATCH v2] net/iavf: fix mismatch between rx_pkt_burst and R= X > descriptor >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, May 9, 2022 10:05 AM > > To: Zhou, YidingX ; dev@dpdk.org; Wu, Jingjing > > ; Xing, Beilei > > Cc: Yang, Qiming ; stable@dpdk.org; > > Yeleswarapu, Ramamani > > Subject: RE: [PATCH v2] net/iavf: fix mismatch between rx_pkt_burst > > and RX descriptor > > > > > > > > > -----Original Message----- > > > From: Zhou, YidingX > > > Sent: Sunday, May 8, 2022 3:53 AM > > > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > > > Cc: Yang, Qiming ; Zhang, Qi Z > > > ; stable@dpdk.org; Yeleswarapu, Ramamani > > > > > > Subject: [PATCH v2] net/iavf: fix mismatch between rx_pkt_burst and > > > RX descriptor >=20 > Refined the title to " fix wrong data path selection which cause segment = fault" > In dpdk-next-net-intel to make it clear what it is going to fix. Further refine the commit log in dpdk-next-net-intel as below base on Thoma= s's comment: If PF driver don't support a flex Rx descriptor that required by VF, legacy descriptor format will be negotiated to configure the hardware queue. The patch fixes the issue when an Rx data path that handle flexible descriptor (e.g.: iavf_recv_scattered_pkts_vec_avx512_flex_rxd) is selected while the actual hardware queues are configured as legacy due to above scenario, which will cause following coredump. >=20 > > > > > > Some kernel drivers return the capability > > > VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC when > IAVF_RXDID_COMMS_OVS_1 > > is not > > > supported. This causes PMD to use rx_pkt_burst that handles the Flex > > > Receive Descriptor format, but actually configures the RXDID into > > > IAVF_RXDID_LEGACY_1, then the fields of rte_mbuf Will be filled with > > > wrong values in rx_pkt_burst, which will eventually lead to coredump. > > > > > > This patch fixes mismatch between rx_pkt_burst and rx descriptor. > > > > > > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata > > > extraction") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Yiding Zhou > > > > Acked-by: Qi Zhang > > > > Applied to dpdk-next-net-intel. > > > > Thanks > > Qi