From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D22643727 for ; Mon, 18 Dec 2023 06:13:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79D2740DF5; Mon, 18 Dec 2023 06:13:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 4913F40269; Mon, 18 Dec 2023 06:13:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702876398; x=1734412398; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fk+393xItFl/DH/tHufY5NvsAJFEN2O2NqTrfaRtQvk=; b=grO5msqUQOl26FhYm8FPaeOcVo2vck6iu+YAJ64wZufznV2ygLVJQQj7 U4/FcZQvCwJLeG8BRrx9ZoiqtXtOTTZUXsy1mCXgPBIqyy+As+4c5seaU +mmwfqOQOfnT7TI0zxpCyYYb1OMb4uyv+5ThPjJdYhxDosQEc0n7fk91A M/VcCA1tr1mY0JrzbRtz4Pi4ndfFHvuPEcdxPWgRZW26/gK9FKSyPiO6U SsKqQNoojsCbztuh3Iyzf+uARzgZOj27OwWzCY/QPTQWLIBj0pijlgPme bbJN//8TSGPsSPEXy9hmWsVGDORvNBH+cqV2HiPZkJdRMKXwCSykmyPhx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="2293177" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="2293177" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2023 21:13:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="919142731" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="919142731" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Dec 2023 21:13:12 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 17 Dec 2023 21:13:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 17 Dec 2023 21:13:11 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 17 Dec 2023 21:13:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEugwKtjCSm6ma3MUfwtA6S4cyqLB8+sktAjThcKSorRShCDnLjn1Qw5kskgkh+01HhHWJLSyfXuoUF3rt7BbgnA/ITbIPkmeH050SpablCT2NqeGwkTY+KEqUNBy2d2JI0foUq87ZdKR/mP7iJ2meEBf4rYP+JO1wcgguYOq2RtRV7L31jiIYNIgPwyzfRT1eLJ95fUZe7EGcAU+vzIeRu62dYO8NWB4LXT9pPw3cvO9rfZVBqVfGK3o3GanUug2nVUwgVj2E19eP1i/KxykKariKeB3iRfs6xgfrsfaqw4oEFrj6CteFVoY68kOW39QtVZwYqy66Yb3xyD1yJXvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fk+393xItFl/DH/tHufY5NvsAJFEN2O2NqTrfaRtQvk=; b=eE2zIEqiRgD5UQ8nh8TrdlZkbETSdya93qUaUuQjfOtMDWDto/6Zrwjy43tq09huPLOyi4J0J0l+theVo4EjJCxE4YALuaJDQXOh8nUyuScip7QgGU/PaYbGrnMi/Xku4OtdoNGXoGLU9OaV+ZzSMsGKI3hAVKBcp6bHsDCVikX4k6WD9yK3jMZmB1XG0fqv7+JaFBw0tvVC9KqdqSUmMSR2ouLpiFfKOQaMGmjYh/4BHpRaYaNTg6//VTiNCq9PhYwV3/6fkeCv+b6PrqZWlrcNulREwPRYrqH8/bBJcLJs+dYEwWF6vgiDJH4tIagZXM+JlflKYpgUymjdQ1LhPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CH3PR11MB8591.namprd11.prod.outlook.com (2603:10b6:610:1af::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 05:13:10 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::ea26:4e71:350:51be]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::ea26:4e71:350:51be%4]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 05:13:10 +0000 From: "Zhang, Qi Z" To: Yunjian Wang , "dev@dpdk.org" CC: "Yang, Qiming" , "Wu, Wenjun1" , "xudingke@huawei.com" , "jerry.lilijun@huawei.com" , "stable@dpdk.org" Subject: RE: [PATCH v2 RESEND] net/ixgbe: fix memoy leak after device init failure Thread-Topic: [PATCH v2 RESEND] net/ixgbe: fix memoy leak after device init failure Thread-Index: AQHaMV95qbjDUqEGpUSq1Og/4Wd3hrCufueg Date: Mon, 18 Dec 2023 05:13:09 +0000 Message-ID: References: <5a8a0a3064089e63790d874631e4fb6ab160f17d.1702535665.git.wangyunjian@huawei.com> In-Reply-To: <5a8a0a3064089e63790d874631e4fb6ab160f17d.1702535665.git.wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CH3PR11MB8591:EE_ x-ms-office365-filtering-correlation-id: 02421c18-23da-42fe-854b-08dbff8806a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S8HRBrkAiNtf4wZ2sJT2cw/IUx6GUtf3Cu85DD3V9kwzGPhXgtbEHagL37aJmbhn9v8nxDWHPBiyR4svnk7IPMVvSh3E1+S+z3XTq7412cLVmcXWEECHEgJhlCjsbxTkJvsniufZc0KGImqaH169cwR3Bnx2rQJvqrVHJXxbu+8CovpmQd3qEWIYB/UoBvvKWGlPE6rpMNur+U50p3k+LC8wxCq9b9qhiAvejJbwLCl+6pgvi2P1MGQP+H7UVxZgDVpTT1t8jA0gn+3tughRfP4ClKsp9g7nQJjhAh71bPzLryYtYIZB0M+INTYY/JxNh93d/vK7zqZNO3fIQsrrJ5MQ0jTbYH+J3/K4kAgPsS/4GuZM38V43fCSrLosKNvR3gsGfmaEcux/WaRZbYiAcpUtN/CeMmj6RVAD1Mclx+d4BetKfIkJzHTM+z1L1u86ktewDB9py/yneY5QMujIp9kfA3f3rh095tFJgOqP0ayJVPsOx/xi69mJxSZBrUjf4sq2HKwdBPLN61uePdvgtbYiP7saDsnvWhx/2xmrcZsyYtWkSQ8jMcP5yfVevn4kLr2Js1PTNa+2xyF5J5i8pkHDJFreJirljfHUqkZhiOT3PLuq7WIw3DPxDq2qwAg4 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(136003)(39860400002)(376002)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(26005)(7696005)(9686003)(6506007)(53546011)(83380400001)(52536014)(5660300002)(41300700001)(2906002)(4744005)(478600001)(316002)(54906003)(4326008)(8676002)(8936002)(66946007)(76116006)(66556008)(66476007)(64756008)(110136005)(66446008)(71200400001)(82960400001)(33656002)(86362001)(38100700002)(122000001)(38070700009)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5KpriySyJcpsPbcL0lb4ZQmubQtUYUf/WFiXYoil15O8rCNAqPqi3npRZNrZ?= =?us-ascii?Q?zIk1Y0kr44lg2BmxllAIdoTrv9Z20FNDKKQeeXYcatPV1uExZJD95BQCzrIJ?= =?us-ascii?Q?FOFbZAoACv4nFPCVGeopRenEhp/XqJEItUvFN1tFnh4NPGElanKVk1WnRNqf?= =?us-ascii?Q?uCr4uyUozNU01QJ+L6NPNqOFIKygtMbKdFnSwa2x9mIuh19ac4/q9ylOGzDP?= =?us-ascii?Q?j9XCvLqmt0au0lNB0NpkqIgmM0bh1egKu3WLj2Giv9ks59a+beEE4YFP3KdA?= =?us-ascii?Q?q/lrJJgYXnVozDUmrS/iPJoB8wHkG+dYPQXT8CzzZ0NV7n34NZqM94deKqQx?= =?us-ascii?Q?Slv0sIThYlJVk1J1LhhYUjeV0oc+MvD9xb6L3PmODKrZMsbcqNRrnGspyHka?= =?us-ascii?Q?G9T/lk7eccL0ZrPufTIbrOW+AWzgDbC8Ss+XCEeqJaWwouyQoK9Lu43hc6eP?= =?us-ascii?Q?muIsb88Ow9Bz2UEVQkMfQdpH9jBsWZkQtowtzLyJjzC/2WhqA7u4FZWpwXZt?= =?us-ascii?Q?GzoeoyR+GSb2tAK6h7SSNPbdiWF/n8MSd/rDImPQ7eHpygKfDilPgFhyWZ9f?= =?us-ascii?Q?+0KJ+JEewBZsXp632VcWOVv68o3dISZ7xuXVu19pUGwmeQS8M/BTGBzp/LDG?= =?us-ascii?Q?jsuEbnODU/BW1usCHvZRxZq24ObchQtFNzjvRscjTtQ1dwrKKprs4j0jNcUY?= =?us-ascii?Q?O+VCSI5WXZ3q14OvLRyXwe3zhYUL7yPY9KjlztlN2itl1UQxHlhHD5xBaKgo?= =?us-ascii?Q?RceL+ieaUTlIMYh2CCFB8f5lTKsRGw5dtIdUQzUvBRwbtcdBmMMZx4TQSwMf?= =?us-ascii?Q?IkS1riFjP7X/ZT4zln7d+AcFlmgfGxA631iZqiTuWaANcRX71NlMZiXOQTcd?= =?us-ascii?Q?sJFLhApfVIbQfEeZfTQI6e7HbCNVvBbVIeWJk6E9l3kJx15OTO1fqckKjIfp?= =?us-ascii?Q?xnbvBdqqB7sRH8xxIoI5v9alhStKvalJ0iaUxZCMYswU3uJ7y40AVzplkHEo?= =?us-ascii?Q?tA7Lq6Yx/EP3Ane4yku4oLT+cKcCNeKONTiAyNQPRSt92V+xZc1q35WkkdPL?= =?us-ascii?Q?iu4oYN90ZX33wLSeRbsioYNc0v9kSS3SSVsBz4glVz3qDaYHZZ29Q5J9xRl0?= =?us-ascii?Q?RvSOXkFUhjQ75KzPSTAcWVPCACi/5QYapKI4Et6z1PmqSYtXIUx3B4XcWvT9?= =?us-ascii?Q?DUCr6/VvafLjN6V9/YufV+qPOynSxJAytinzlQfNFFK7d7H17IHAoOmXIO0t?= =?us-ascii?Q?BOcx5vQdYqRGMOUEkFR6Dxxhy8IlHlwuNCbUPu2ZG1TD+kcZ6LQnfCd1dtxZ?= =?us-ascii?Q?VVPzcVs/7mD9UXg38d1f2+oXjaEZc02tgMunExC61RdphYQkVXAXvZturjay?= =?us-ascii?Q?uomCDQAubT+FpnbrfGbnjNjlJUDTYaBkAiP2YmD7/enhe9clU3In6dd+eEH3?= =?us-ascii?Q?t3m/DD3NTKAGHvedRjO6VfTN3QKwCUTVXhy0GUHKeCVCfOnPcCZDdQC0fzQp?= =?us-ascii?Q?eU70OIYFU9ANLC9FlI21KbAGr63cx0lCZ5jF2IF56TSeSmGXefG5DcKIxNOf?= =?us-ascii?Q?jaaI1+8LCn2YQAmlWD2MtygAS/jJbxjSrzblXb1F?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02421c18-23da-42fe-854b-08dbff8806a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 05:13:09.5091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s3awbPd5QAUcq3uaM819esRLsNN7YNi1OMsZpkbGbHxce3FCUCcFvfkOq9SbYkdiZt7ro6VqMs4qHK8gd9oDug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8591 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yunjian Wang > Sent: Monday, December 18, 2023 11:08 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming ; > Wu, Wenjun1 ; xudingke@huawei.com; > jerry.lilijun@huawei.com; Yunjian Wang ; > stable@dpdk.org > Subject: [PATCH v2 RESEND] net/ixgbe: fix memoy leak after device init fa= ilure >=20 > In ixgbe_ipsec_ctx_create() allocated memory for the 'security_ctx', we s= hould > free it when errors occur, otherwise it will lead to memory leak. >=20 > Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi