From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B17D436E9 for ; Thu, 14 Dec 2023 05:39:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 070F740285; Thu, 14 Dec 2023 05:39:07 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 91AA240265; Thu, 14 Dec 2023 05:39:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702528746; x=1734064746; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+xK3S3zakliqWcQWgpzkqbZ7EPAmTkqZvM12qtxgLCs=; b=TXL0YWe9kBoMwXxkFfw4mI0eBaocBtTS5CR03Rl2hSB9fEBmF0NstVvU l7JSutDXNKe5oC1nb4e6FfcpBfisQSBQvUZwnsl9hGlIErpMVV8SRbrrr VoFY/W9BzK/CHXXH7m8mW3w/yyWX+XrFoah0wJA3rh4CojrWeCTJnFqag gTXZcBSg1R5PbJK5dV//0+ng0/ziL72wFPGIVweaWIKvYGya+9yHr0wah XSZ78PUhofpbvCZ8ov7HiOcoRfVzNx3gawf4cq1n4Up+l/ONqgm7/+xEb +djs5DAFLICJG0QlvEsk7WwT3gaFhjXXPui6u4goapskMjnEvVm37muIJ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="13763752" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="13763752" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 20:39:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="897601041" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="897601041" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2023 20:39:04 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Dec 2023 20:39:03 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Dec 2023 20:39:03 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Dec 2023 20:39:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmn3damYd6wbkbGHi85fqKBe/nKOqwewu2bBsh+Kgqs9ZAPKFm+khxyBL90UQtTWeNPq0ln0Br5ecsumbT/5YgmECMKCEf2dcnUZHBLQqdzXliPcJ5ZMmiixeliQOlrCwT/f3KBYBWpQLcLKqhIwSZTkkRVMoh3lyG1BmR27mev7of/GD4zNFEXE0k2QsEcEyoYnbilgjyV3I4UKXLX+UNzF0g1hFMfoZ6Ra3OfjwgQBQEIIs/WODO44MHxkXqzM5P85972WikVeOpgRFcDYhdq9eeGHhqHDznHw73cpJksawCp7JTaV9DxmooULZTcVl4O+XEaO0vYFx97mt1UoTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+xK3S3zakliqWcQWgpzkqbZ7EPAmTkqZvM12qtxgLCs=; b=l6NcOuRcKQk+W3Fgg6LnkEWSL/wxTvM8ZFWmKA+tFBynvBDz5lF8RHBquxRkuej1IZZ5XagABwyFpsbYoaYzv55I8ZjQU26ICkAQSv7OsblK24b/mtdBHOS40STimxJevdaxS/E48kzp8ZHr9TXd6ALwc0mImIXrF0xFqcUUnaMBIN1w9VfhIXoEnTUtD0MIwv1gXCyTA8ICLrs8L4mWLwtEhBZ+rsByiuFVkRVTu645vz7bTSWhSHF1HK377wiAU3hi9P/ABu9RXGtB7Oy0SsFxUe3VpddQy0Mg+LtrqOlnkRVy4/0fYKQ4Bdr1ajKwNP7g2zF/ssYjz7Hlsn0Wqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by IA1PR11MB7387.namprd11.prod.outlook.com (2603:10b6:208:421::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26; Thu, 14 Dec 2023 04:39:01 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%7]) with mapi id 15.20.7068.038; Thu, 14 Dec 2023 04:39:01 +0000 From: "Zhang, Qi Z" To: Yunjian Wang , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "xudingke@huawei.com" , "jerry.lilijun@huawei.com" , "stable@dpdk.org" Subject: RE: [PATCH RESEND] net/iavf: fix memoy leak in error path Thread-Topic: [PATCH RESEND] net/iavf: fix memoy leak in error path Thread-Index: AQHaLi9VVUCO1vgWaUG/4NViCGSMd7CoMbWQ Date: Thu, 14 Dec 2023 04:39:00 +0000 Message-ID: References: <2be401c77779bdc38c8a79b006665ba623c6e2db.1701426993.git.wangyunjian@huawei.com> In-Reply-To: <2be401c77779bdc38c8a79b006665ba623c6e2db.1701426993.git.wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|IA1PR11MB7387:EE_ x-ms-office365-filtering-correlation-id: 4f7ebde4-9c82-4cad-64b5-08dbfc5e97b3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9OAQg8+JLwvvms4xqPRxbHcmR68nH1PR2mpStYyEyaF8KePs7bvic6Yt0sf+5v1B9A5jmIK5BSZl6nbG6reXi88/wfw2Frur69KW739kxBbepmGv3L3VmMMlJddTNk8xXjVaT7p6ihcbOcCUaoE5ARTDiKwpfljnJd1nfgrEvDiq+xz0uIagLMNwzOCnl+btAJd9jpx9+/4csA5uIO5/LyWm6Ly3GRU70j+nYJTPmplmqNqGk9S5RhTvVFQOKQE1OYfPpQZpfPcA2aSqoObxTiQTRsylYyZ0QxSCz0i6+j+k7wQGi5hCrjAmghBajzz2n279bbBGC1TSg7IF33gpXJFF702fPfgTjYOScyjBTZz8qbzz/UinEYCyLppz2yeCoPwL2u4IqmwkhY9dBaDEbw6B2oQC+UMZto/uaW4FHpkE9f2dzbUmj5aglocPBl/LL2jZekPH67VLUwanOvddVjlUlE9zzTG6YSqXQ5817DYzPhUMEGlhRJwMV/CR8AIlQB/K/4wc4te7szrwejY34cRQnpCq8dAW/S/Ld8rR3MI7lXsVzKYaJffW0gJffcnJ/Iy1jLPAGIk3d06tqJzs4yB2KjGR0CoFNVV339KBGDudNNYHRxUKn9yS6cifKjgo x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(136003)(396003)(366004)(376002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(83380400001)(53546011)(9686003)(6506007)(7696005)(38100700002)(122000001)(4326008)(8936002)(5660300002)(26005)(8676002)(52536014)(41300700001)(2906002)(4744005)(71200400001)(478600001)(64756008)(54906003)(316002)(66556008)(66946007)(66446008)(76116006)(110136005)(66476007)(33656002)(86362001)(82960400001)(55016003)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0GJ/+GdGb2N+mbVPRM5IrJ2Uivib8eLzSpFiQGuIgTrXkC4DwgYQtgHoXadB?= =?us-ascii?Q?/TinIhgSkHhJTKw1diz9Rs03Bno5zrHqt1em69lcLLAGEmL1H+a69bE7ZLg4?= =?us-ascii?Q?VwdQt+KfiLHBDjalLWj/CkoHf9oznibGUQialOKZQKU7YeM964iHhmZVgmhx?= =?us-ascii?Q?SgrJgcC2si1En4v3Cs/0NXg/GdZNW4Hn7rcCRgcjdC6GaY6yAekqXhTRzAam?= =?us-ascii?Q?Q8mpTIvrJhuy5OW5NBfZ+WnTHz8BHF284ti5/e1EBNWdwadMEvyQMXvuYqSJ?= =?us-ascii?Q?IC+ZDLR0yGBXgjx569Sp8CPbc8gK6iGo+ybmj2cWted8r/SQ+yVlAph/FiyV?= =?us-ascii?Q?4qkYrJcI3KtsjT0g8z+9uyKjWYPcKwi+118A68vqFtUBuu0cyjgA82hPOno4?= =?us-ascii?Q?TUPafoaMX7DhGk28ZZHYF7DSMUx4hi7JIlZCilEPvnziLqI+XM5KUUVkoSio?= =?us-ascii?Q?YemlaIr0NznbR+Bt5Bq2YsmT3Misyl/SHTIF3QRCI+cv7Gah/qUMLH8sKVcZ?= =?us-ascii?Q?GmQsODkAGD3e7CSd82gD1Y9lQ7IyOGDl+7WDhR+v4nTSnNTsbbyUhM+weTcS?= =?us-ascii?Q?nbTnPi+d+eM83uzYhjxZEnfWDxr92XEwOdAsVGIvYub38ao5JLr72nBFgUW+?= =?us-ascii?Q?JIEPskie4iwkpZgX4pLt/ulzEzQNSsiK/5wl1F7WLCK8RaioEwseelQ3SvHM?= =?us-ascii?Q?CHRj4hLgM6FjAD2tai29t6BWXcYvzVd03r+QnRoDYwG9Q9ywutXxjiHfleJo?= =?us-ascii?Q?SrwyiBru7f51yX/DujIOnsBA3p+feh4UWcofhPk3zSe7+h43Bsnfi88H4xoE?= =?us-ascii?Q?Q7xVo53mbdo82yVfpgp5ur1BzNUXhfEztz1ZrDgbxt24ygZhDVTmXHvKE1Y7?= =?us-ascii?Q?26XI05RzTGqtrdyYeVHbnOTB4oSqVyYEihYKJ5zRqLBSBTb7ajEY1uic8YKo?= =?us-ascii?Q?mfl0O/WvlcLoGwTNSRRZZ+bMJMzlsEL7ZengD0SuNevlsQMSaxYsZpLLiCVj?= =?us-ascii?Q?vbhDbeIc+FE+/cePVTUoQy4IH+8USCiZuQxLl3Fd+J8tjkR3WA7xztZTSFcZ?= =?us-ascii?Q?EuybNy1kFzQg3wLKW76g5KeD/pRF2R1tgVjPGw2YK3oKGHwzqQRaqsrc9lvD?= =?us-ascii?Q?cFHzgLQgoxFdgPy0Cn7iVQ9vK5qoWGzKFfwPXbP/oahy+mxGcBooCsCVZ/pE?= =?us-ascii?Q?LAnPjZ3w3rOBIfjOaJEupz5PFvYfyYcf0mG++Fo07rQipA8C1e1Pds/SWPV9?= =?us-ascii?Q?I3JGR/fiS+mCDlk7XsTTNsyEmk3hLbT5xm7KWrdpnyoyZzUU8sNlzT0fXVmu?= =?us-ascii?Q?FZKeT7n2vnK0dIoUXEs/sqorgV1jhL49UGnngv8F6hoXDWEtyHGy6dljvwgP?= =?us-ascii?Q?R5xVW4KcBjTReOs3cOMAJ84/bvUf7CnYHwFlszrG/M+ub1f0toinKX0ghBFX?= =?us-ascii?Q?wzk5/+I7CKP5oZ8srokCmtlJ9imOSaH8HTKwfnfs0NdIa82mXoG8co1e4JQP?= =?us-ascii?Q?AVNkf/NHwdi+JglNTI4dFcMj6N4Up6oNLNxHDP4UH3QLGucx908gFb0zaL+N?= =?us-ascii?Q?jBENmT6NiHINB1zZZTZgX32gV5+rXJuY4ABs0LX1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f7ebde4-9c82-4cad-64b5-08dbfc5e97b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 04:39:00.5067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1wVEPoaeDJqdA2emHiw/u//iBQLOiMAUslMSwCyKZa2GKWZMoZjEeq9oD4Qn6aHmJUH0HlQ7Mg7WQIlU1q7BZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7387 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yunjian Wang > Sent: Thursday, December 14, 2023 9:46 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; xudingke@huawei.com; > jerry.lilijun@huawei.com; Yunjian Wang ; > stable@dpdk.org > Subject: [PATCH RESEND] net/iavf: fix memoy leak in error path >=20 > In iavf_security_ctx_create() allocated memory for the 'security_ctx', we= should > free it when memory malloc for the 'iavf_security_ctx' fails, otherwise i= t will lead > to memory leak. >=20 > Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang Acked-by: Qi Zhang Thanks Qi