* [PATCH] common/idpf: remove device stop flag
@ 2023-04-20 15:57 Qi Zhang
2023-04-26 6:41 ` Xing, Beilei
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2023-04-20 15:57 UTC (permalink / raw)
To: beilei.xing; +Cc: dev, Qi Zhang, stable
Remove device stop flag, as we already have dev->data-dev_started.
This also fixed the issue when close port directly without start it
first, some error message will be reported in dev_stop.
Fixes: 14aa6ed8f2ec ("net/idpf: support device start and stop")
Fixes: 1082a773a86b ("common/idpf: add vport structure")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/common/idpf/idpf_common_device.h | 2 --
drivers/net/cpfl/cpfl_ethdev.c | 6 +-----
drivers/net/idpf/idpf_ethdev.c | 6 +-----
3 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/common/idpf/idpf_common_device.h b/drivers/common/idpf/idpf_common_device.h
index c2dc2f16b9..7a54f7c937 100644
--- a/drivers/common/idpf/idpf_common_device.h
+++ b/drivers/common/idpf/idpf_common_device.h
@@ -110,8 +110,6 @@ struct idpf_vport {
uint16_t devarg_id;
- bool stopped;
-
bool rx_vec_allowed;
bool tx_vec_allowed;
bool rx_use_avx512;
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index ede730fd50..f1d4425ce2 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -798,8 +798,6 @@ cpfl_dev_start(struct rte_eth_dev *dev)
if (cpfl_dev_stats_reset(dev))
PMD_DRV_LOG(ERR, "Failed to reset stats");
- vport->stopped = 0;
-
return 0;
err_vport:
@@ -817,7 +815,7 @@ cpfl_dev_stop(struct rte_eth_dev *dev)
{
struct idpf_vport *vport = dev->data->dev_private;
- if (vport->stopped == 1)
+ if (dev->data->dev_started == 0)
return 0;
idpf_vc_vport_ena_dis(vport, false);
@@ -828,8 +826,6 @@ cpfl_dev_stop(struct rte_eth_dev *dev)
idpf_vc_vectors_dealloc(vport);
- vport->stopped = 1;
-
return 0;
}
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index e02ec2ec5a..e01eb3a2ec 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -792,8 +792,6 @@ idpf_dev_start(struct rte_eth_dev *dev)
if (idpf_dev_stats_reset(dev))
PMD_DRV_LOG(ERR, "Failed to reset stats");
- vport->stopped = 0;
-
return 0;
err_vport:
@@ -811,7 +809,7 @@ idpf_dev_stop(struct rte_eth_dev *dev)
{
struct idpf_vport *vport = dev->data->dev_private;
- if (vport->stopped == 1)
+ if (dev->data->dev_started == 0)
return 0;
idpf_vc_vport_ena_dis(vport, false);
@@ -822,8 +820,6 @@ idpf_dev_stop(struct rte_eth_dev *dev)
idpf_vc_vectors_dealloc(vport);
- vport->stopped = 1;
-
return 0;
}
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] common/idpf: remove device stop flag
2023-04-20 15:57 [PATCH] common/idpf: remove device stop flag Qi Zhang
@ 2023-04-26 6:41 ` Xing, Beilei
2023-04-26 7:01 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Xing, Beilei @ 2023-04-26 6:41 UTC (permalink / raw)
To: Zhang, Qi Z; +Cc: dev, stable
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Thursday, April 20, 2023 11:57 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] common/idpf: remove device stop flag
>
> Remove device stop flag, as we already have dev->data-dev_started.
> This also fixed the issue when close port directly without start it first, some
> error message will be reported in dev_stop.
>
> Fixes: 14aa6ed8f2ec ("net/idpf: support device start and stop")
> Fixes: 1082a773a86b ("common/idpf: add vport structure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] common/idpf: remove device stop flag
2023-04-26 6:41 ` Xing, Beilei
@ 2023-04-26 7:01 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2023-04-26 7:01 UTC (permalink / raw)
To: Xing, Beilei; +Cc: dev, stable
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, April 26, 2023 2:42 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] common/idpf: remove device stop flag
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Thursday, April 20, 2023 11:57 PM
> > To: Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] common/idpf: remove device stop flag
> >
> > Remove device stop flag, as we already have dev->data-dev_started.
> > This also fixed the issue when close port directly without start it
> > first, some error message will be reported in dev_stop.
> >
> > Fixes: 14aa6ed8f2ec ("net/idpf: support device start and stop")
> > Fixes: 1082a773a86b ("common/idpf: add vport structure")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-26 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-20 15:57 [PATCH] common/idpf: remove device stop flag Qi Zhang
2023-04-26 6:41 ` Xing, Beilei
2023-04-26 7:01 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).