From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D82E42A12 for ; Fri, 28 Apr 2023 05:30:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BDC842D93; Fri, 28 Apr 2023 05:30:31 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6376C406B5; Fri, 28 Apr 2023 05:30:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682652629; x=1714188629; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZsSenyfXq069yC+lpUTS58E2s3Na1oB80SyQcKeo7lE=; b=TNG7ktf6kWtAtS4Y1GQCeYW4fee9HMiepal3nmMPecGEDtFmKeeJ6YG6 Fn8n9O4k+c7AiMmkxJG3EV/DLFUNwUUMHGskpUtgBRgmB2TIVyllG79Ij ksKHzR/Y2ELUUJSnZh69wJpuH8zlv0Sams4IJSa4jQ1iRZpY+xGpzW1Sp PJFDb+qvPk1/FiZU0XXNB8qjwT4muaUDrLK21f+yZQvz+UbmLK7jeGSjH FGyoLgOgcVBPxNBbrVdiaZhE3Icxqu9WVDBveKs3uZcD/BtR2GQmGqexp X0QgoVKNwMPnshwzwRDB0XbGWz56kNihmkzGR63YBAV+fRgcWGwHm65rI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="331943536" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="331943536" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 20:30:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="694660932" X-IronPort-AV: E=Sophos;i="5.99,233,1677571200"; d="scan'208";a="694660932" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2023 20:30:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 20:30:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 20:24:28 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 20:24:28 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 20:24:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqILqIjHNKyvArn2K8GJGvDTdHgh5LJcFqS6C6nCTlRDdBKv6vo34C8q4DsetwwDVLstfOi9uj6DCx+GEVDyK6bAiVIpducuEQfFn8CiCMSe30yd/wNM5ESJknrPFOc/ZtUryqA3T5GOM0kJ/mw5I/Xe6oj5Sd/mYKC8g1kaXOqfGa4c420BHxyHM/o6umaV3I2fCfjf8L3QZUgfc6LbY2oHGtYXhCfV51CPrNP+H6QGsH5YFY/9gJ7S1ZtQVJ1rDq3PConzDqQcE+kSuSXFWgcVhk+0S/Vk+OSBNpCOgUZUUPukXTHU3lfxD9PET8hE92uD+YwcFp7pYoz4jBXzjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wy44MaegUxXe7U2P9wqdSO6WuAApb6w034VzmTCIdVg=; b=cVb8ID3ZnbpL6feTByobRYw6zDEGwePhLRHp/RXU8NO299nJnN5Ri6/PlERws9EqZdqEYMpKz47UdNInBWotFtLWtOr229uVJRf47G+j+FYs+hA4wAUK5Eg3YZSTCCeB3W9GTpJd4/ChAYepkwBTX5061QdfRTVh7qiJmjcWRrL2E0aJUb8JgoklUIPW7p+zFCNyGLgOZ2KGNO0Jo1WTcBTv7IcXz/bOlmQWECGqlus+hn4ddoIFp8K/O+M+2uRMdCKFuq4t2lE5Xu8j3I6rhSo5CBZah9c3Wl0dJK+7Ej680me+zGdYRL2lVWbJDRKdtPZ7H3z9lu5pYT0fxV45kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM8PR11MB5606.namprd11.prod.outlook.com (2603:10b6:8:3c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Fri, 28 Apr 2023 03:24:26 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6340.022; Fri, 28 Apr 2023 03:24:26 +0000 From: "Zhang, Qi Z" To: "Qiao, Wenjing" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Liu, Mingxia" , "stable@dpdk.org" Subject: RE: [PATCH v3 6/7] net/cpfl: register timestamp mbuf when starting dev Thread-Topic: [PATCH v3 6/7] net/cpfl: register timestamp mbuf when starting dev Thread-Index: AQHZdo5i2W8t9TwgzE6c/riobRBnxa9AFFOA Date: Fri, 28 Apr 2023 03:24:25 +0000 Message-ID: References: <20230421071603.55680-2-wenjing.qiao@intel.com> <20230424091707.488045-1-wenjing.qiao@intel.com> <20230424091707.488045-7-wenjing.qiao@intel.com> In-Reply-To: <20230424091707.488045-7-wenjing.qiao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DM8PR11MB5606:EE_ x-ms-office365-filtering-correlation-id: dbe78d8a-6060-4f8a-8c07-08db4798119d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 52Jhfq5l1XA85I0kjBIJ3fPmfX1kptmGUXK7pDGW1kTIeHJZcMaOqS5eyP08NLHUj4S9naju9skNDiGz0y/D/kHFJtQTr1zwHB7uEbgoM6xk5EizKGXbJ4mSOVz8T0GAnO6UnPKF///ibyTAbp2U1gcwK3ltjzLaCW+ObHlKOXnrSz3wRMv6/h/8gggY80k6+SVanhX0EX+1MI8Kt58UXI70sEtcNOeKMpiPHeM/yvLa1H46iZxQ8KqkOkk4whzirl1YjBkgLNHwEl3D8AbuWulquVqgZ2rkV2OVZF/oTI57jQOJkZ1ayHQPIlm09Utc3l5IPRJ6tP9nRaCgqG32JK3mbxbzmKo6EXtVkhvM7nVvRUK9jxFMTmyWm/i1m6tTvouJcW+EL3N0ag1bVw0mqzdVTaeCHcOH9uYfWGKfvhDMz9FwM4kufTJve/tFpF0R7r+32IbN8Hv6RHZjn+WrjLgHkDD0+kMSXY54sLubaKs9lyOXtAaCZe5cje9Hxcw87KhiNmerNE3B53+A2tYNhcccjxw7WTxHd7V55Sd5XcWX4E9D4BGtVheb8v9eLUyIiBJ8N4XP9AdWH3CeReCYG7ZxUIFBSM9MWMjgIGAEaJXu+sMOnakKgjD2KkIWnVYb x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39860400002)(451199021)(53546011)(186003)(9686003)(26005)(6506007)(83380400001)(55016003)(110136005)(66476007)(66946007)(6636002)(66446008)(64756008)(38070700005)(76116006)(66556008)(82960400001)(5660300002)(122000001)(316002)(41300700001)(38100700002)(2906002)(4326008)(450100002)(54906003)(478600001)(8936002)(71200400001)(52536014)(8676002)(7696005)(86362001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7tYpLbpmVngB8GIMnleh1oFGpxzspI9RW7Ymc+ppWqkPa1jRxU3poh9ZVq3M?= =?us-ascii?Q?7mFoS3N7R/i2Gt1dFBp6E6RtNF64teWc3U+0PJzVDVSOskJp9isY7U1H7rSg?= =?us-ascii?Q?IzZRtbUCco+BA8IYxijg7r+9V8slvh3METu7QT4+dE34HAwaNvKUwBJpo8+s?= =?us-ascii?Q?kvqwF2pSaEvIRuKxTG/YsCv88E7eTfaItAPf/e5YsSKVYOVbsNho4df/hGuA?= =?us-ascii?Q?WPwrz/UBSNnin1nEb0lzoTdw39YZitNArdMdXbGOyCvVJ/BM7jDXI+KmIBM8?= =?us-ascii?Q?/AFm7EiV2aFwz6J2DdIL74K44neOsSh99Ba8BBkDy3rpKuen/G8U86nbOi8u?= =?us-ascii?Q?W+R+5j5cxRyspP6D3hwbaFbldOft4t21oSddq5K2eaF12SxV2HvQe6AUXeXA?= =?us-ascii?Q?u/8576AmLWeiDmV9oDT7f31xvQRHWkZjGO0kPq8HR9nUQVkELv6dmrRo853i?= =?us-ascii?Q?Od+dhOGR3venEI7ZrZnZtRguJDrGSl/59zfRU9Ix9cESSUdyXDJRUxqifagl?= =?us-ascii?Q?TrAB8EI7Lox9iN6BjlMr6d9kB4/hbTrTHChK/FigpeTuwdcP9h+m4D/DRqQP?= =?us-ascii?Q?zajec0Ndc8+e5c8YWY3lin4mPlwQzTJid/h7qJZlXP6Xy8I01MJlin126jfV?= =?us-ascii?Q?y06AW4f6meULYPmz2oNKrrua2Q2qn11S3w1monND/cf68K1tUcB4DDVL5rIg?= =?us-ascii?Q?dhxUVOzMY1yonuDTDxreRS0uDCbrmjSdWb0F+mn1ucU1+RUXx4QByS2r+u01?= =?us-ascii?Q?PQMFMSAKmd4gcVmXQPi5pBvxzXoAqJGzXJuls3fIsElX5RyZi8MRgKRkJERX?= =?us-ascii?Q?i4FyHQpm8xf2o0yYFvyx+Y4uoY31Hm9BdYJ+dGbCg6yLg/N7VVXXBxCHSRqF?= =?us-ascii?Q?EiY0tZtfmpGwUvSR4Ei0C9LkUwchFYJ33+d/XelQoWNitbfiehBmaa5cIuIb?= =?us-ascii?Q?eNoLzr0g3uoV0EQtx3e0BsGqaysfiu2pZRWboyPHHoSdZ9Wzz0UVENC0iVIG?= =?us-ascii?Q?adHTEmnhRhpbIwnt3l1nD7bJtR4KIVPbzCvgpoLmWfAZNR4ukZ8haA4Zmt05?= =?us-ascii?Q?v8VWpijNQok2qti93qir2dxgB3ZqOv3Juis9RdFXx5v5QG16hpkdnfcES0uH?= =?us-ascii?Q?JasggTbY+oCq9p6TASv/sVdncWAa77tWNO+y1Sb967w8Ky/tF+u2By8WrBnp?= =?us-ascii?Q?0rQk5Ea5SqzGFhtJ6KRpriS8CKaf0j7rGoxV2WOJDsj218Pxy7LG6XYG2QJF?= =?us-ascii?Q?G3+R32fRBAo4FyUhu0qGAiRllU4cQbfP6yRN5aLMZ34uscMiG1j/A+qZx7LB?= =?us-ascii?Q?HzWs+JNAK6bjbG2oUKNr+BA9twLneUv5L/tR8RAhxgoo2TL9tQETJJb0lgjR?= =?us-ascii?Q?ITn7kQ3jsSn4YYlmbwa4GcWN2jiGmaMGsuIb7gQySd6issEHh18DOQ4RoBc4?= =?us-ascii?Q?Jwbl9WMmwH4zGuroEqgAJkxloMAQC4LVGYBURG99kWM6R08r4zMHs3MhV5//?= =?us-ascii?Q?dhi4Nnt64en/GJj7izSfAdzpwJfe84kSR4VgBIIAC1aNMXBJ2XqufMcMgc9M?= =?us-ascii?Q?sABLPAdYILSD4HmrqDnmjmSSl4gJD/LQN1scG8Xz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbe78d8a-6060-4f8a-8c07-08db4798119d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 03:24:25.8647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ou8ZMvdihV8Fu9lrurBmKqYb5P67u0Ah9fGxVax64Euvns/Vdvu+MFWRtEFIZeCPW7nE99YKPdYwEYatfE1vNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5606 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Qiao, Wenjing > Sent: Monday, April 24, 2023 5:17 PM > To: Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Liu, Mingxia ; Qiao, Wenjing > ; stable@dpdk.org > Subject: [PATCH v3 6/7] net/cpfl: register timestamp mbuf when starting d= ev >=20 > Due to only support timestamp at port level, registering timestamp mbuf > should be at dev start stage. >=20 > Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wenjing Qiao > Suggested-by: Jingjing Wu > --- > drivers/net/cpfl/cpfl_ethdev.c | 7 +++++++ drivers/net/cpfl/cpfl_ethdev= .h | > 3 +++ > drivers/net/cpfl/cpfl_rxtx.c | 2 ++ > 3 files changed, 12 insertions(+) >=20 > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index 82d8147494..416273f567 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -771,6 +771,13 @@ cpfl_dev_start(struct rte_eth_dev *dev) > rte_eal_alarm_set(1000 * 1000, > &idpf_dev_read_time_hw, > (void *)base); > + /* Register mbuf field and flag for Rx timestamp */ > + ret =3D > rte_mbuf_dyn_rx_timestamp_register(&idpf_timestamp_dynfield_offset, > + > &idpf_timestamp_dynflag); Can we also wrap this into common module, so we don't need to expose idpf_t= imestamp_dynfield_offset and idpf_timestamp_dynflag which is not used direc= tly by PMD? > + if (ret !=3D 0) { > + PMD_DRV_LOG(ERR, "Cannot register mbuf field/flag > for timestamp"); > + return -EINVAL; > + } > } >=20 > ret =3D idpf_vc_vectors_alloc(vport, req_vecs_num); diff --git > a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethdev.h index > 200dfcac02..eec253bc77 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.h > +++ b/drivers/net/cpfl/cpfl_ethdev.h > @@ -57,6 +57,9 @@ > /* Device IDs */ > #define IDPF_DEV_ID_CPF 0x1453 >=20 > +extern int idpf_timestamp_dynfield_offset; extern uint64_t > +idpf_timestamp_dynflag; > + > struct cpfl_vport_param { > struct cpfl_adapter_ext *adapter; > uint16_t devarg_id; /* arg id from user */ diff --git > a/drivers/net/cpfl/cpfl_rxtx.c b/drivers/net/cpfl/cpfl_rxtx.c index > de59b31b3d..cdb5b37da0 100644 > --- a/drivers/net/cpfl/cpfl_rxtx.c > +++ b/drivers/net/cpfl/cpfl_rxtx.c > @@ -529,6 +529,8 @@ cpfl_rx_queue_init(struct rte_eth_dev *dev, > uint16_t rx_queue_id) > frame_size > rxq->rx_buf_len) > dev->data->scattered_rx =3D 1; >=20 > + if (dev->data->dev_conf.rxmode.offloads & > RTE_ETH_RX_OFFLOAD_TIMESTAMP) > + rxq->ts_enable =3D TRUE; > err =3D idpf_qc_ts_mbuf_register(rxq); > if (err !=3D 0) { > PMD_DRV_LOG(ERR, "fail to register timestamp mbuf %u", > -- > 2.25.1