From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhou, YidingX" <yidingx.zhou@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhou, YidingX" <yidingx.zhou@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Xu, KuanX" <kuanx.xu@intel.com>
Subject: RE: [PATCH v2] net/iavf: fix port stats not cleared
Date: Mon, 11 Sep 2023 00:42:52 +0000 [thread overview]
Message-ID: <DM4PR11MB5994C8E288693354BDE3C733D7F2A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230907023942.3150495-1-yidingx.zhou@intel.com>
> -----Original Message-----
> From: Yiding Zhou <yidingx.zhou@intel.com>
> Sent: Thursday, September 7, 2023 10:40 AM
> To: dev@dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou@intel.com>; stable@dpdk.org; Xu, KuanX
> <kuanx.xu@intel.com>
> Subject: [PATCH v2] net/iavf: fix port stats not cleared
>
> After VF reset, kernel driver may reuse the orignal VSI without reset its stats.
> Call 'iavf_dev_stats_reset' during the initialization of the VF in order to clear
> any statistics that may exist from the last use of the VF and to avoid statistics
> errors.
>
> Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kuan Xu <kuanx.xu@intel.com>
> Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index f2fc5a5621..24c6342dee 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -2721,6 +2721,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
>
> iavf_default_rss_disable(adapter);
>
> + iavf_dev_stats_reset(eth_dev);
>
> /* Start device watchdog */
> iavf_dev_watchdog_enable(adapter);
> --
> 2.34.1
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2023-09-11 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 6:54 [PATCH] " Yiding Zhou
2023-09-05 8:06 ` Liao, TingtingX
2023-09-07 2:39 ` [PATCH v2] " Yiding Zhou
2023-09-11 0:42 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994C8E288693354BDE3C733D7F2A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=kuanx.xu@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).