From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C87FA0542 for ; Sun, 9 Oct 2022 08:03:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13AB1400D5; Sun, 9 Oct 2022 08:03:39 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 73E6440042 for ; Sun, 9 Oct 2022 08:03:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665295417; x=1696831417; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZWrlf+ZdITatNlbxQ65WeIEt4DQDRs2wOSQYATSrFbo=; b=cPW+6meCJOOfVtXUK8+pA5SM4wJPng0C9xSg8We8/6PcUNbLTa9iMCiy RUbBdZMnQkCVCjJIRTeaUEDc0T2GVEJLnGakIo2UEj4obRmpMeaskgN3l hl7upM135o4mr8aeWrtlpN2LW351sevC59YG+ygRBQh0/IyXmJmY1HQqm rrLtxXTNEUljzCmxAjNVcFYFM4neXknEs8Uqnt0UcmMTVvNR64tb9hlwY KvvzVM+xbg7ajCIUD/e4v7l5+mT5NGGKlECuayoyhTPTY2jOQ1nqKaOK7 rKVKYXlm29UCgL/CtAKIy13SHdVL7dNv/F3i4EpcYqpbpn4Zl5ew0Z/1O A==; X-IronPort-AV: E=McAfee;i="6500,9779,10494"; a="301632404" X-IronPort-AV: E=Sophos;i="5.95,170,1661842800"; d="scan'208";a="301632404" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2022 23:03:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10494"; a="768040983" X-IronPort-AV: E=Sophos;i="5.95,170,1661842800"; d="scan'208";a="768040983" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 08 Oct 2022 23:03:36 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 8 Oct 2022 23:03:35 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 8 Oct 2022 23:03:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sat, 8 Oct 2022 23:03:35 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sat, 8 Oct 2022 23:03:35 -0700 Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB6556.namprd11.prod.outlook.com (2603:10b6:510:1aa::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Sun, 9 Oct 2022 06:03:31 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546%3]) with mapi id 15.20.5709.015; Sun, 9 Oct 2022 06:03:31 +0000 From: "Zhang, Qi Z" To: "Zhou, YidingX" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "Zhou, YidingX" , "stable@dpdk.org" Subject: RE: [PATCH v3] net/iavf: fix error of virtchnl command Thread-Topic: [PATCH v3] net/iavf: fix error of virtchnl command Thread-Index: AQHY2vJ7ecH9b42czEGJ3XjjcGmISq4FkGwQ Date: Sun, 9 Oct 2022 06:03:31 +0000 Message-ID: References: <20220919060654.1092715-1-yidingx.zhou@intel.com> <20221008084852.397649-1-yidingx.zhou@intel.com> In-Reply-To: <20221008084852.397649-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH7PR11MB6556:EE_ x-ms-office365-filtering-correlation-id: 299c7735-87e5-43f2-efc3-08daa9bbfdff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V52dv1+G3q7URKRHANWNcy+OVowsjybCbGN75mloHuPYk8ekbWCJ5r+C6o/VUGFPqGzPUYKQD2qTxAawUllw6ExJ3ct2lCBEKlo55ZGyt88VgdUHhbMT6H1D6KEIBYXQFTrFeeLiDMYMtiArK5uZB533ay8OBdwGn6kxs7ZWr1PrMOKCgjuDk8Y2+outm9ZJSglV+k5sTbDKTb9Z1GnIq8+JWDGrIl6PRVLiERzlfHjGxGSzZNUxYjPL3qIxsxDlbxxudxR3sKk8lH7BKvPou+hGxpPvszrYKR9m/+j3fqcC6+/dWnVXzmJAx8FhvDBe7fAbAPIvlv+x48/ngHOv7+0vxr9+g6/kJwO45aFXKkIgi6d5TCpmL1HiXvqBs436RFvDKaGAjbfZlAVdkF9zsOQ9+rW4pJU0OB+44hpE0DWrCgiSkjAVpIn6Rkwpho/j2OpaugkO/bPaioN4w2heccUj4A7FB4fSqLF/1k3SGYa6ev4X+h/vU3etJWrw94OUQISUIqko8eSxEmSRWLSD/FgdEz/Sw6FtTrl6IGfcNz68GqxHn3uWYfPVGUl5xUcSxaKMvcm47sL1N9EI4aQk6no2PF3vtykCK409M5wBxUb4v+pBqUo7Mmnp24WTF9+9+bhef0ZBeKZLC6+xaTRGUfSWI6brLWBMlG/Mu2fUjMeTk3ayB9gjJvqmVdaYsojeovlbMhq8SsnG+swq6lmAyjVldFGo/GIRt9yt00T694Dpv2WVioU3o3WPAeueM26zPUYrhGRPw6URQiVhfxam8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(2906002)(122000001)(26005)(4326008)(316002)(450100002)(110136005)(41300700001)(71200400001)(55016003)(66946007)(66476007)(8676002)(76116006)(52536014)(66446008)(64756008)(54906003)(5660300002)(66556008)(38070700005)(82960400001)(7696005)(9686003)(83380400001)(478600001)(53546011)(33656002)(38100700002)(6506007)(86362001)(8936002)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r4ni0zbeqJLvH6uS0k9Jub41MC14PAQ8cApbnVqJsFKAxwLyhm3KSJMjXN4M?= =?us-ascii?Q?NNZ8MI3bHqziIC9IPbSz995+tVtRYFAHQhmHPN9VS554lKKL2n8tJ0NOJyD1?= =?us-ascii?Q?elwd74qEfcPOPXbt39t7WPpm4CeRHKrR50Yn9fM9twB3OObYLAsYvBbCAsQj?= =?us-ascii?Q?LgnhLoBd/fMwHRLuwU54XxhjWnfv6Nni7F0orgV83o/VwebA2KrslEEmSYpZ?= =?us-ascii?Q?6x7B13ugTYnSqOTQF5T4PlT+dufFKVcwCaud5w11pWiGYcXT7siMnkdtQPc7?= =?us-ascii?Q?N5oHYVSlNaOT0dRfbtzwEGXYZWCe+Nzx+rBA0IIxJieAy5vgo/MsSFPFx9mN?= =?us-ascii?Q?jsZKU1mgb+ixc6v90VMNNwfDeefn+ZzEGYeNu5HzpxCCSNBe7JPKwDed4S0j?= =?us-ascii?Q?k3gdixYDzxpm2KiAbEmvsP9CQHA02hIhIoYJw6JocTm/nSMizDk4gIx4d9rg?= =?us-ascii?Q?iRqQeMraIoSQWCjlpkCLTZhLyZ0OI7n/fgewwXuDRqroGEH1DKqaAZVBP07m?= =?us-ascii?Q?N2I3CzFUUXYxxnG2YmvHow5UnIFyhWgGGjyL7OUVeclnA12CFIm6vDgSOxRi?= =?us-ascii?Q?sY4q8iqeSsBEkgMVbNMPKcRJssF1VI2ZpTG5vuoTfUpcfGvBjybcw3BrBt4K?= =?us-ascii?Q?mimxkP3UwteZ2NyM6wJAAhozyOrVDSvQY2cQicEZPzxTAAz8T0bjr5PhIG/W?= =?us-ascii?Q?uCqelVh6Waf/cV6b8hxxZshKOQalGDlx5hb5sK7Ns9edf9egPpC1rzAkQaUP?= =?us-ascii?Q?+9SYpIGCnIUTWfSrQI3pPseGC78sjPpYhBBcwbTD422+7/Lx+9CpGq7hmXip?= =?us-ascii?Q?7LTNnmpOGgucKk/nQltldKpZB+3k4R1Lx0PbIgnmJ6hBKRy5xRY4lxgoH2nO?= =?us-ascii?Q?2d9G6SjgL+A2c46B8+o6n5GsX5aC4b+OUUzoacmJM37YYOaa3pSevUOHc7VO?= =?us-ascii?Q?h+TxXmZKuHLFj3kL1s9PMUQQfLJfvlwqMWsUdnY6L8+JdiToqEqqPAKoz/Y+?= =?us-ascii?Q?X0dUb0KWOLtlmW8V3HjDwwj23NRUGr8Kz8/f3q6UccqKljrIuyY0wT1nQTQs?= =?us-ascii?Q?6dN/Sjhnsowoz3PJ2CzY/wXI3SRl01+B+Afu4yzjhFqbss5z3Lq7bXwYtwk1?= =?us-ascii?Q?PPdrB2prM2kTVK1l+h297W/ySx2HZuMOnU8Yo4I8YTebfNNJK/XW+8K0iGe9?= =?us-ascii?Q?vbrU1+R3K+vt5X3saKfrLhcZqNF1vUvCriLvKEfeZOx2wkDQLfZZANSRS/0n?= =?us-ascii?Q?wnveJLvEm1IhFvYFjdJUYtKgQRShiL3eSj1tmW2f2DvlsmETKQfbVodTSRmn?= =?us-ascii?Q?6kHGKRvJpb9fcRz9728T12PWjhlMLQFvsT1k8cGVgViXrwzYcbqyEXiovfoQ?= =?us-ascii?Q?8oAcc/nPHjU3ypYcQgb/WcCZkktRgc6PUzevtH8OYkeuqMYIt56djUSv98X0?= =?us-ascii?Q?DsVT6LDwO7l3Pdt/DloHUnzZzmm0z4Gyn1wvO7tED3iLWzR+Jb5MUu++okEK?= =?us-ascii?Q?v8zHdhvWKy5vqjYo4gVa3B4iuA3MxXtwGQ/EXv7y93SxPu6BS17FtSu7dcz2?= =?us-ascii?Q?lfwBS3h8wvRo4JCtcITh1OQuppxYgTlQamFW8I1s?= arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k/aD5ojvOrO6Il8eCXugr7aZ9oFiHWYbMw1RgAxXVvW59t0t6MGPFCvDO/gcAgyj7L0IKfXE5//YD90nHnMHQwghzzsWzx7OgUOZctdvaT2ZDh+iSdgAsG540JczwDroBC+lFfi2mBi31arFr/b6Zw1SW8/PUsLpTIIsNRWiPyoUvVr6N0wiPBjIv5ZVsIIf3nxx6ahMW9Vbc9jCJCWDGJlLZ7jOSB/EfJMT8ivJOoyBH6aVeosCEqJ2it/oE01EfaWuNksZprRebYjLXaAu2KWhLXx4O1fk90xXShJCevrH8+6BDA60lDFpejx5BkSQazvIzDMPQuHOycoE8OKbWw== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6C71CCu2F26yZ5SAinSPlN7rvxpahaecbXtGMHyi8Mc=; b=Xqm6KrakNKP6sWis8sd8h+AtSj53xHMZ7PsY88GksbeO6cXb50YcrNFTfYdNaR8EnYgn3wfvhOKzA+u0N1KaquzM5Fo/gYMmBLyckES4DynA3Ar+LGcRp/er0lQihBikl95EQTa2bzVybqjWaGH+2gOOmksnaZe13IJUVqjw12ZmheDJIKjytVwKtjiFOzcv3QD3str5DIFKKVbDlV9QNSXBSZ+4WaEmhaqPcAIaoSgaWJVKzaUVividGHniFGUOsjpNZxTs8X16wwj19m+LxSelHczkjTrTNTfobZX6USmEiq97IrI9P0bianx07NQhYQIufRZ5bfVvgcnyblLUFQ== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: DM4PR11MB5994.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 299c7735-87e5-43f2-efc3-08daa9bbfdff x-ms-exchange-crosstenant-originalarrivaltime: 09 Oct 2022 06:03:31.1421 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: 5dPmALR2an7mznWfp9GCQbJdRc2FlCx9GpshBK7UoT2Zf0xjDnUQRFkZnPJCiNBwaJ25I0rjinBr5YDZ0XamYg== x-ms-exchange-transport-crosstenantheadersstamped: PH7PR11MB6556 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yiding Zhou > Sent: Saturday, October 8, 2022 4:49 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; Zhou, YidingX ; > stable@dpdk.org > Subject: [PATCH v3] net/iavf: fix error of virtchnl command ... > When the device is bonded, bond pmd will register callback for LSC event. > This callback will execute some virtchnl commands in eal-intr-thread to > reinitialize the device with interrupts disabled. In this case, responses= to all > commands not be received. > > This commit starts a thread to handle all events to fix this issue. > > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > CC: stable@dpdk.org > > Signed-off-by: Yiding Zhou > --- > + > static uint32_t > iavf_convert_link_speed(enum virtchnl_link_speed virt_link_speed) { @@ = - > 293,7 +427,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev, > uint8_t *msg, > vf->link_speed =3D iavf_convert_link_speed(speed); > } > iavf_dev_link_update(dev, 0); > - rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_LSC, NULL); > + iavf_dev_event_post(dev, RTE_ETH_EVENT_INTR_LSC, NULL); If we decide to raise an etherdev event from a separate thread, is it bette= r to do this for all events ?