From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7077A42D7C for ; Wed, 28 Jun 2023 08:48:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AA4642C4D; Wed, 28 Jun 2023 08:48:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id BC46940151; Wed, 28 Jun 2023 08:48:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687934934; x=1719470934; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hafndLALR0pidEZ7RP1hGFO0uqMBjw+dw86VAwc9hik=; b=D2oV4nkoUZBZpbHa2DvHuzdkxIVUXpCFW4ogwUyK+tiBqSTdConiEy5M ZVvYOQoDzEUfnAjossttYzNfxlPP3q5IhkNdHz1n05DNOcigyh5mwwDsg k4Pr4zGwdxWz1g8/u2HcG3pgI3ft8rkqnfqLfWdnnU++mSx+3pmPWV+6L 8fGqAbTcSIMEYHSnPlJYENsKpEPI/KOtl9j7d65Vv0kShr2/KeBkG05pD Ne+tBmxbfTiWATl04M9pPak1y/smKIyc40odrMuaIQ/+lvfDH51S9kgv3 LTAFOfP2kIz4QNyLKwcTA96QxhwKRM9WkRZl3sJUVX6JoPO/qqHdp7PFW g==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="361809325" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="361809325" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 23:48:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="786954154" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="786954154" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 27 Jun 2023 23:48:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 23:48:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 23:48:36 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 27 Jun 2023 23:48:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 27 Jun 2023 23:48:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aKgnzP0CErUFfxFquWIFX770Cy3t2PcXTvpC31YOSXaUpreZ0YMTxLNcHYMsQ/p1lgT6PB9hOH6NgoRatNFaMJIJl1eVWqmWSL9o5MDAMzijG9fm4DrS2HLt8tXHCfoc6HrJOV1XrSpfJC059z61srduo4vfV/TG3gRSjEhsdNC7qMWiD+L1prapoHat9HIjEyBJRTChXpNwokeMXcx+uJweXnukeqfohTOdH/xcbmk4bhgEvqUBN4RmSoGBKmMep/E2rk0SAk9QMpBA3YCtXgT0R/TQINwMDUocMAJ1n8mO3DC9ZjWy591oteoD9jgbdpim1lJOPuIq8uG1TZ+wgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i2W/zcSCebj26q9jASac3wmElCREPQ9TP5sWeZwRsfw=; b=S3vrJ9TDyBcH2Rl73poP+jKSe3DG0/6sKAMICtpIdehC3fZdbw3kTSWrn6/wxfMAVu3GnBdyhWr86czYmRHWWhXmB9GNaJKvbhJyo/QGdGw8BBVUBr5sUdyRTpb0VDyxvdv1ZYgP1hHixRmSyIi8irEdwSVXbKT3F+52boUjk7fCXxijo11wcr6Q1RAjUAgXKCQ4XbyLRsRvtmFAz5cZt883IKOHNqMXxc6Gn4H/FTC+tSpiX5eP3OAYwktQRzmqpnOJIBcTdoAUcQx9B6OtNBQLiPrqMnqwGnSl16x6LQ4h2dlloRdarhz2iLZ5fBQHLGWIvJmwCJ4w0wBRQdoFxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by LV3PR11MB8553.namprd11.prod.outlook.com (2603:10b6:408:1b8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.15; Wed, 28 Jun 2023 06:48:34 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6521.024; Wed, 28 Jun 2023 06:48:33 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH] net/ice: fix VLAN mode parser Thread-Topic: [PATCH] net/ice: fix VLAN mode parser Thread-Index: AQHZp0C/bdWZlYWo7UyAnAF/Gp382K+fymyQ Date: Wed, 28 Jun 2023 06:48:33 +0000 Message-ID: References: <20230625082308.2674971-1-qiming.yang@intel.com> In-Reply-To: <20230625082308.2674971-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|LV3PR11MB8553:EE_ x-ms-office365-filtering-correlation-id: d81ffe06-6e80-405e-d2e2-08db77a3b11b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lSI2MqG1MYP63lhnjPcXU8Qw45Wcmc0xCP0q4MYYAWs4WO5nDgEX3GKZJdTmDScMIJ6fCrRMfQpOX0ZNUmK8dgsU9BhP5XCoQu5fVA+8t8YujYc0tiKPxxqhWp0rQQy5cWnBNYnHHIUmKgGug6lt6KvUvl+mQyMT75wi3WiicCVsqxixMxKZGX7yDjXlLoc+3cDYyUpdIXBCj1p9IHecKeQoyxJTv2Nxw6VK3fGhi6HaPJ3PsD7wUgW1oXVepPTueHGtE1VUABbZNxbjRFhcF/SzggOryQylHRvDyPL+fB/7k8WOGZ5KS2DiJLFlkGHBJ399Ln1aZc5C+E213rtlTpL4vQiMSd2lDa1QNjeHaeOTtk7E2VHHBxv7S6i54jo+t9SpaLimvamjUYIYTwCQ8EXmX9vjizMQ8drI/IXIA5f5OCByAnQhoPIvadXzVZIbJPEOW/8Wk6Zx9Ma4jwyjcDuGzOzL51a38QdORJ16gHu+FILkRDcP6cX5FtgfR2UcoG0Yp+sfzSyr8vUujjltSi2wTXRYVXl90Rf5p+i3j38NawQLgxmQTkSXYBEOExFyE5r8GkGk0QR5nTka139tQgsUSp7bj/5LDQAqMGc5GvHivJhOOjsSui9inDj7u5b2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199021)(55016003)(83380400001)(2906002)(186003)(7696005)(66446008)(64756008)(450100002)(4326008)(76116006)(66946007)(316002)(71200400001)(66476007)(66556008)(110136005)(478600001)(5660300002)(26005)(9686003)(8936002)(53546011)(6506007)(41300700001)(8676002)(52536014)(38100700002)(122000001)(82960400001)(33656002)(86362001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EUci2ZjJw+DvMks+gz3YNXjn4lAGZH3pYGXJU3+t9TH/SdDtWM5p0Vdo31Lh?= =?us-ascii?Q?bSftdR5TTcrUJ8I/0Gn1w/YeA+Yzna7xL0TyxAbL2kS1AnJk/ydQOCTd3Uni?= =?us-ascii?Q?92CPQIPyji2tke789ff94uvTZD3hF0evjQ1fyfhZi5aPluLnllNffcXKpKH8?= =?us-ascii?Q?39MNpipyTaBuwVv29qkjhF/7mivdih13orhnDqhcvG55W7kfIm18npLkNPCu?= =?us-ascii?Q?ohbOTLM+aZMhKC33AzxBmNTDs6LXrApQW57xFLhofdDdVSynB5/bie3YF0oa?= =?us-ascii?Q?mtu9rpI8meIX+BLOp+AoLqyOF4r8qT5LHI+bt98w7K/hoR1inbw6dKD7wBOz?= =?us-ascii?Q?NU2T0W23FzkaJKu6dMFn6F4v4lVVmKFG20e2sd7cKNCg+TW/OXujfyuc3gty?= =?us-ascii?Q?radibK1swdDDdDjrXjr1cJcS6ibb7YPnQgQnzWYfGBk+2U1GVAhab9ZRM9Zb?= =?us-ascii?Q?78z1iMfRRmVFLTW/oMHNCf2uILvS8OP02Ubql2RQzI5keFxYm0towePRl34s?= =?us-ascii?Q?KglCvte0RjY45BZ71wFXHIxV06zl10r61fXCBhio922d2ZNoiGWBMLPUdws1?= =?us-ascii?Q?Qmw1doBpoYte2U5z2rWpVe/39w0uNUUkfJWqV5yRvKRQEnvWVBHMFx+ajA7N?= =?us-ascii?Q?pVHzmRSKN5ITFBEJ77Yp1eoeTDrkxws9zBzBMjEZyuscOYQrAFLVOZ1hAdUK?= =?us-ascii?Q?6umoZQ5br1nEGCRyabvsybU2hGV5i4OHTwDnGITPsAPqzeL6LdeYz0cVvk/b?= =?us-ascii?Q?/65TOVIBi3a+0mhIzVjNm1uYDNM0PAZJErVUMR1lqERsiCIKa4H8A54JlHC2?= =?us-ascii?Q?qlODOkjvKpk4cbTA65XPp2Ki9zPWGU4HnDGPhMdqAiJTaiq7Iz/fJ7HTGAJJ?= =?us-ascii?Q?wodYvNDA9PEYD9Uf6Nn/31X2JRNgAgLHI4n4HS3k8CVD4ih9eOXrp5xtXTGr?= =?us-ascii?Q?YDTwJVO0IXrjyZ4Sy9mxKgJjmEf7g9dmzFECf+KcKsQ6yAyrZ03QabXq9yOo?= =?us-ascii?Q?OHnUakzL1kYPlEnHJax8p5bA5z5JCnBjSPLxiJ9Tc5vf2fsqSa8xBEv4UmmN?= =?us-ascii?Q?gG0pDl7tFR4s41ysLnT3H8Pg2Kw7tBIp6MXMMunEkzkD+xV2qERUqGDi4Swz?= =?us-ascii?Q?EvUtSBCuqtiSuMAJO33gEtfkLJaRywZ+96cW/ZuAWU00/f6UMQ8DY8jz+VXi?= =?us-ascii?Q?EL8Qoc+Wxw/8Q4VHTCKSTS3mZM1+EW5SNC5SjKbvJEFPbmQE7Z/jduK0Rfm5?= =?us-ascii?Q?ZMN56iVG/jLQGLpds42A3tfekMEq79AwX5R40K5MlT43GPxxbNqYn3jNnCX6?= =?us-ascii?Q?cCZawt862P7ZBd75jxvdOP3A9NzeMxQiBXfVTuYo5QvMq89lOJv6or6cRLma?= =?us-ascii?Q?EX2Yq+HlIrIxlPtEJ79+Wtf+gdRf/c2YoarocOpYRmL6ewpnwPRl9zABRQqT?= =?us-ascii?Q?xJRi6ujFDfA+ATMpsoVPQ52+mYP+paOtZYWgZC3zVtcOU9c8M8sD3LOEGtEO?= =?us-ascii?Q?3NcoTx1g77VFMYfGXbqgDvAb/1Fxrd8FkgP5AEWxREpIk+btld20Zk4F56Q4?= =?us-ascii?Q?mnUdSr5jWRvq8h21teMAtyFOpbYYSymPRo2DRjnX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d81ffe06-6e80-405e-d2e2-08db77a3b11b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 06:48:33.7743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yLYIDcRkaCBwzdUhLolZ58xaTDx9sI7vlyaMMIxRwGSeDOcojKQqIcuhk7T6y3b/b8lCh7ZrCcUWHYZY+6Gtow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8553 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Sunday, June 25, 2023 4:23 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org > Subject: [PATCH] net/ice: fix VLAN mode parser >=20 > Parser will not be ctreated if raw packet filter is not support. > This patch add NULL pointer check for parser structure when VLAN mode > configure. >=20 > Fixes: 6e753d777ffc ("net/ice: initialize parser for double VLAN") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Yang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi > --- > drivers/net/ice/ice_generic_flow.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_generic_flow.c > b/drivers/net/ice/ice_generic_flow.c > index ed3075d555..91bf1d6fcb 100644 > --- a/drivers/net/ice/ice_generic_flow.c > +++ b/drivers/net/ice/ice_generic_flow.c > @@ -1836,10 +1836,12 @@ ice_flow_init(struct ice_adapter *ad) > if (ice_parser_create(&ad->hw, &ad->psr) !=3D ICE_SUCCESS) > PMD_INIT_LOG(WARNING, "Failed to initialize DDP parser, raw > packet filter will not be supported"); >=20 > - if (ice_is_dvm_ena(&ad->hw)) > - ice_parser_dvm_set(ad->psr, true); > - else > - ice_parser_dvm_set(ad->psr, false); > + if (ad->psr) { > + if (ice_is_dvm_ena(&ad->hw)) > + ice_parser_dvm_set(ad->psr, true); > + else > + ice_parser_dvm_set(ad->psr, false); > + } >=20 > RTE_TAILQ_FOREACH_SAFE(engine, &engine_list, node, temp) { > if (engine->init =3D=3D NULL) { > -- > 2.25.1