From: Raslan Darawsheh <rasland@nvidia.com>
To: Lior Margalit <lmargalit@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>
Cc: Lior Margalit <lmargalit@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings
Date: Thu, 15 Jul 2021 08:28:17 +0000 [thread overview]
Message-ID: <DM4PR12MB50543A47C1458D83EC309AEBCF129@DM4PR12MB5054.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210713125442.1366424-1-lmargalit@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lior Margalit
> Sent: Tuesday, July 13, 2021 3:55 PM
> To: dev@dpdk.org; Matan Azrad <matan@nvidia.com>
> Cc: Lior Margalit <lmargalit@nvidia.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings
>
> The L3 protocol of the RSS type may be different than the one
> defined in the flow.
> If the RSS type also includes L4 protocol type, the selection
> flags for the RX hash will be set with SPORT/DPORT without
> setting SRC/DST IP, but this combination is not supported by
> the rte API.
>
> When using indirect RSS action, the flow creation fails,
> because it does not match any of the pre-created TIRs.
>
> The fix is to prevent setting the hash flags with SPORT/DPORT
> without setting SRC/DST IP. The hash flags will remain 0,
> meaning non-RSS processing of the received packets.
> In case of indirect rss action, it will match the MLX5_RSS_HASH_NONE
> pre-created TIR.
> In addition, the queue_num is set to 1 when the hash flags are 0,
> but it was implemented only when creating a new TIR. Applied the same
> to the RSS desc before checking if it matches a cached TIR object.
>
> Fixes: b1d63d829378 ("net/mlx5: support RSS on src or dst fields only")
> Fixes: 5a959cbfa68c ("net/mlx5: share Rx hash queue code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lior Margalit <lmargalit@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2021-07-15 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 12:54 [dpdk-stable] " Lior Margalit
2021-07-15 8:28 ` Raslan Darawsheh [this message]
[not found] ` <20210727064620.880417-1-lmargalit@nvidia.com>
2021-07-27 6:46 ` [dpdk-stable] [PATCH v2 1/2] net/mlx5: fix RSS L4 proto " Lior Margalit
2021-07-27 6:46 ` [dpdk-stable] [PATCH v2 2/2] net/mlx5: fix queue num in RSS desc Lior Margalit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB50543A47C1458D83EC309AEBCF129@DM4PR12MB5054.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).