From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59E98A0C47 for ; Thu, 15 Jul 2021 10:28:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A4DB40143; Thu, 15 Jul 2021 10:28:21 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2078.outbound.protection.outlook.com [40.107.220.78]) by mails.dpdk.org (Postfix) with ESMTP id 5943C40143 for ; Thu, 15 Jul 2021 10:28:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUKE3H52DcYRYULbOELb/Z5B30wSBquwtG7QPOpzTb5NEyEOyGrFgT4LPNgBgcYRsixlclBMuSxLBFRf1ErTC7EMHIHKydmhOEkkQKsfJYTfPih+1lyJEUovtEmzAHPbgC20hpr+QvoYFi3xce8D3gpFqGrqA2YjZ9R0TElvGcmjrDeLgr6l/GmpI1M9NUVZkWqc9sVFbCmcqU50LRWoIi6obOc7wez1sFWubV2+/qGH02U3nb/yDf+beHGN0PDkEuQD9PU5huRTkTrHLW0U1xKKlQEc4rLwFSJ+BWoVEe7wg15XuL5LHi0bZ0LziRQez11lLxUWaAcwziPhm2G66Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2+p85udqCXyaj7e95Q4nyh2c58tz7j2PfjC2s83bSRo=; b=W9a+e5NM2zu9ZYhuUjRp8R/Y1aWjXhU6No0/3HUjbRvW9UUQJ7AghnYHqQ476uFm6cElb/KA11wMgsFZVDKz/LzH0Vb8y+VNWcQifnKfF4r1ixpJBeuuZ3AO7uKoffw92nKkwrHtxhp2Kn+Jmd2TmsXdoJFTrNTmxGLAMHo8s8TmeNRVxH3a8iO+dT7sf/LkhTuyiEc6Tb0wlM+JUMzgJBmlZnZV34xaVa181/SeWNIgWYFn1zSy4HHjjOu5cNP361Z8OUNBzUkPTMBjwKrH/MYTYh6OUtTYpbGrfVtD1AdE+e/0XzCD+j7T80Xwcd/zVBS+SoAe6yjvSxJ06S39yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2+p85udqCXyaj7e95Q4nyh2c58tz7j2PfjC2s83bSRo=; b=SXjiCz1xXzjYStEdqK9SalyQB4Jh1SUh7maH/8dcdGTSHdn7YueDKSShkpbdOo1ZqY4ExsZh5MtBpcvkaBWHpaXwaQrgu7JgnmHG32OTa7CxWiynlhp3wzxLgJc+RhOMZl8TY8KoAiHOM+lqIuFPqgbjed7IBdZDRo13P+HRpQdg310Sed4iWLIBTdk7V3UzyBwWkcjyjBSuC00dcMeTWGc4SdiS2JenZk5SznwvAaAdksMMCnJJWZ2FDauSxgFov2VlOP5p3rfc00ltqPcRGyYnfaSjbs+J2qcQ/b9Nw4Ou78kTaaNnrhSFyuxEm8Bz+pV5tlFpdgjQPw+s9wASXg== Received: from DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) by DM6PR12MB5551.namprd12.prod.outlook.com (2603:10b6:5:1bc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Thu, 15 Jul 2021 08:28:18 +0000 Received: from DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a]) by DM4PR12MB5054.namprd12.prod.outlook.com ([fe80::584f:2720:1100:666a%4]) with mapi id 15.20.4331.023; Thu, 15 Jul 2021 08:28:18 +0000 From: Raslan Darawsheh To: Lior Margalit , "dev@dpdk.org" , Matan Azrad CC: Lior Margalit , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings Thread-Index: AQHXd+ZSLslGhBv9B0Keu0tALYnP66tDttQQ Date: Thu, 15 Jul 2021 08:28:17 +0000 Message-ID: References: <20210713125442.1366424-1-lmargalit@nvidia.com> In-Reply-To: <20210713125442.1366424-1-lmargalit@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 463dd5d3-7cc2-4706-4087-08d9476a7f79 x-ms-traffictypediagnostic: DM6PR12MB5551: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7N8yugXkkGuLRqOExPt7k+pwssXqX+z415qqvIOItK4qWRetcB2mpzHPNgVBy8hDmGZUyDBsmDxTW9xdH/RUAnCGDcKA/bADKHyh472jUPPcuiWVmnWXpNgYJaP+5RhGEw/aEGqwqB05x+2O0KnY73z/TBLgDwTCijFp9/3zLlX2zZ12eyrkkwQJd0ynoRnaPaHctSMJ3liTzWrMxBr+z0fz6mBxSRTxnlrmt/UKmqkfBYaiOrACGeqLZeRhx1bnnxUKja/eTrfq2NRBoQZVDOSxCt1JGREGd3k+vE3Sh6BH381paVNUqLScLtZDXyhGub8ti0AADqFgS2+qd0SHsVosACkR6Chk1y5VhGcob5AfB15IfeGWnYf1n8eBueXKRDAJpz4S2c7APAPFZR6CAIGfHOn96XVeQ9WRjSQe0skdutpJVqSeAwBVgor/9W/P/3cwJjWQxS2qPNz7hWMyr0nb2oLQ3if5tmHX/uia5QigYGUHz3fRXSSW9L96pEwQV21Fb1B5U+dsa7J0lIdrC6IlvzX7RFs5A7tn62h+MCb3CXZnoURdn9KiTuf65TS2jTxO87F/OfdFmkO3f684eLnflmGxbquz/1gcg0gAfua9G7Z4VrKMp/Ah4XX5+dPACjnpnxccWj9hb71+JSQxhdN/oMVvSfIubHDCsYgEoHpOOaV6r+cvqPJa1xTKOzK1JYbR5PDRNFpbMWoq6f6Nxg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5054.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(316002)(38100700002)(8936002)(71200400001)(9686003)(8676002)(6636002)(122000001)(55016002)(2906002)(53546011)(4326008)(66556008)(186003)(26005)(6506007)(7696005)(33656002)(86362001)(450100002)(83380400001)(5660300002)(52536014)(76116006)(66946007)(478600001)(54906003)(110136005)(66476007)(64756008)(66446008)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ri5CHBbPR+tdhjArCYzHyt8JCZLNyvaAdfiHo7Bo2yCF5lzxkmg0AzHQErrC?= =?us-ascii?Q?kWlzmGLASieyaOy+2/19UZ2Bd0FMYHPmiScibCqK6JsTGw5tDOhR+1nEQWh2?= =?us-ascii?Q?D8S4cvs8shUbAT0jPKn6y9cQypfY4q+MPxykcv5l2zf1hLEmVYz6lxw1VqlF?= =?us-ascii?Q?ddEELt+WXRSFhgqCfFpxFKJDDUCP94MgQLzYW5FY1Hmwgunx1nbyKp7H9COR?= =?us-ascii?Q?2Q9+PYwWzkfIMUg2++zzp9WTUPcUIIM5GVdq2zPK98oXwx0n+L2z1lqHJKVM?= =?us-ascii?Q?X/9ThIoQW3o/bRzPhNHhAIETSVG5irM+ihzaOCOmnEOIYo8LLG+E2mYc14AU?= =?us-ascii?Q?Aa/L8z775Llk5Ck5n/VVh+4LF7ETwLVjW4sVfcFFXuxYZzrRrqE+6vNuq60w?= =?us-ascii?Q?uzRE3Mi30u3yq/bStP470gbHraTrTAnu6WtmTe0RF4MWPKS9lylgGx0DsnxO?= =?us-ascii?Q?NpDRPz4m1V318FpEeeWNtOXjNRRg9l1kmTL8CyziQaTR8Mwe0oSW5NsxBJgJ?= =?us-ascii?Q?TvuHfT8beW3BApfA9UW6fieSuEBExMvWj4QlBrh/lanhRomRhZfcdn3W12zT?= =?us-ascii?Q?yKqhrlpEbfoQ+6S9tBH9IGe00ZTtd/kKHdUfWT23jwfwYl+y3k3OvtiHI0VG?= =?us-ascii?Q?a8qotbo3PlK7Q+5ebJLzd7clnA0mfJBNdHtihzt5EGYQte96dQM/skeVBbUF?= =?us-ascii?Q?Ujnhy0kM7Bk9KYwLADRYTaeU2dbMSBy6WRVtZ3K4lR3OjXA7CC4r8pjB5CDa?= =?us-ascii?Q?DMvWj9syas/4ImqaRi4DqiVQ2GpZX/iJlqQcSuwwi/F4wQNttJkdjm5tSnSI?= =?us-ascii?Q?WIYKs1YqFAJylkEvT1T2BpYOGQ97h0apVHzCWWSCCfFObKNmTLfxLE9U70LZ?= =?us-ascii?Q?UdVRhvL7/n22ZqRqiyjeWTlmh8Bj7YA18Mgf2iqDfiztx+lLQMyxm+gPio0S?= =?us-ascii?Q?h9gVu1hzlg8V6Htu0KxNuaNQvucYeenGzd7CUwV9lt0vm1G4yQTq1Dbd19ta?= =?us-ascii?Q?wWNAWMvtgnSZ/w7uHo5BlhcOu/qNtXv/SY1q5E4IoeIZeVSI91XO25LphXxs?= =?us-ascii?Q?n0E7NbH8zUEI4Uijw5U/0UiNQfYRyCnWxkYsnb4mkFdj1LLW6e1cSqTvhODV?= =?us-ascii?Q?tvKfHL2LlsNg+VuQ8mpEYowf8CkXxWFCHu26oEEaV5zPFlsPWXwuqzZg38do?= =?us-ascii?Q?xRiZJv+cy/MmVRTatHO8JtcZC4IVyDymkqgO5LywJoQYZHCK4KyCSfrCQobd?= =?us-ascii?Q?FcDJPR4t1sVycdLY+5eijYonIZJ/Ts3mcX1FCR8l2ff8FbOHjg93jYLuLSjq?= =?us-ascii?Q?C5LojzO3WcKr5hrXGzr9GHwz?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5054.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463dd5d3-7cc2-4706-4087-08d9476a7f79 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2021 08:28:17.9418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 86Zs7vIV7S14I1omtjhTuXJxsQu7sQp7braN6NLxkVOHJJEz53CwmlrtQz2AC3iLl88yAhCvsAl3zbTGrgJPtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5551 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Lior Margalit > Sent: Tuesday, July 13, 2021 3:55 PM > To: dev@dpdk.org; Matan Azrad > Cc: Lior Margalit ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings >=20 > The L3 protocol of the RSS type may be different than the one > defined in the flow. > If the RSS type also includes L4 protocol type, the selection > flags for the RX hash will be set with SPORT/DPORT without > setting SRC/DST IP, but this combination is not supported by > the rte API. >=20 > When using indirect RSS action, the flow creation fails, > because it does not match any of the pre-created TIRs. >=20 > The fix is to prevent setting the hash flags with SPORT/DPORT > without setting SRC/DST IP. The hash flags will remain 0, > meaning non-RSS processing of the received packets. > In case of indirect rss action, it will match the MLX5_RSS_HASH_NONE > pre-created TIR. > In addition, the queue_num is set to 1 when the hash flags are 0, > but it was implemented only when creating a new TIR. Applied the same > to the RSS desc before checking if it matches a cached TIR object. >=20 > Fixes: b1d63d829378 ("net/mlx5: support RSS on src or dst fields only") > Fixes: 5a959cbfa68c ("net/mlx5: share Rx hash queue code") > Cc: stable@dpdk.org >=20 > Signed-off-by: Lior Margalit > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh