patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Sebastian, Selwin" <Selwin.Sebastian@amd.com>
To: "Ande, Venkat Kumar" <VenkatKumar.Ande@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] net/axgbe: fix the build warning for GCC-16
Date: Tue, 18 Nov 2025 09:54:39 +0000	[thread overview]
Message-ID: <DM4PR12MB5055E8380CF0830CE015BA8F8DD6A@DM4PR12MB5055.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20251113164109.522-1-VenkatKumar.Ande@amd.com>

[AMD Official Use Only - AMD Internal Distribution Only]

Acked-by: Selwin Sebastian<selwin.sebastian@amd.com>

-----Original Message-----
From: Ande, Venkat Kumar <VenkatKumar.Ande@amd.com>
Sent: Thursday, November 13, 2025 10:11 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin <Selwin.Sebastian@amd.com>; Ande, Venkat Kumar <VenkatKumar.Ande@amd.com>; stable@dpdk.org
Subject: [PATCH v2] net/axgbe: fix the build warning for GCC-16

Build warning reported for local variable set and not used on GCC-16.
Fix the issue by using the variable for missed register write operation.

../drivers/net/axgbe/axgbe_ethdev.c: In function ‘axgbe_timesync_disable’:
../drivers/net/axgbe/axgbe_ethdev.c:1744:22: warning:
variable ‘mac_tscr’ set but not used [-Wunused-but-set-variable=]
 1744 |         unsigned int mac_tscr = 0;
      |                      ^~~~~~~~

Bugzilla ID: 1819
Fixes: e04449488fdb ("net/axgbe: support IEEE 1588 PTP")
Cc: stable@dpdk.org

Signed-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
---
 drivers/net/axgbe/axgbe_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index 31d35ff182..cf3b0d9ef5 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -1742,6 +1742,7 @@ axgbe_timesync_disable(struct rte_eth_dev *dev)  {
        struct axgbe_port *pdata = dev->data->dev_private;
        unsigned int mac_tscr = 0;
+       unsigned int value = 0;

        /*disable timestamp for all pkts*/
        AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSENALL, 0); @@ -1751,6 +1752,11 @@ axgbe_timesync_disable(struct rte_eth_dev *dev)
        AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSCFUPDT, 0);
        /*disable time stamp*/
        AXGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSENA, 0);
+
+       value = AXGMAC_IOREAD(pdata, MAC_TSCR);
+       value |= mac_tscr;
+       AXGMAC_IOWRITE(pdata, MAC_TSCR, value);
+
        return 0;
 }

--
2.40.1.windows.1


      parent reply	other threads:[~2025-11-18  9:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 11:30 [PATCH v1] net/axgbe: fix the build warninig " Venkat Kumar Ande
2025-11-13 16:41 ` [PATCH v2] net/axgbe: fix the build warning " Venkat Kumar Ande
2025-11-13 17:33   ` Stephen Hemminger
2025-11-14 18:25   ` Stephen Hemminger
2025-11-18  9:54   ` Sebastian, Selwin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5055E8380CF0830CE015BA8F8DD6A@DM4PR12MB5055.namprd12.prod.outlook.com \
    --to=selwin.sebastian@amd.com \
    --cc=VenkatKumar.Ande@amd.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).