patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Mingjin Ye <mingjinx.ye@intel.com>
Subject: RE: [PATCH] buildtools: fix build with clang 17
Date: Thu, 27 Jun 2024 16:50:45 +0000	[thread overview]
Message-ID: <DM4PR12MB5167549BD1AD50040D8F2D72DAD72@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8w-BWkRDmixGyXdt0XRUwPpjmpax7iNF6Yq4rZN9Q9kLg@mail.gmail.com>

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, June 27, 2024 3:37 PM
> To: Ali Alnubani <alialnu@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; stable@dpdk.org; Bruce Richardson
> <bruce.richardson@intel.com>; Mingjin Ye <mingjinx.ye@intel.com>
> Subject: Re: [PATCH] buildtools: fix build with clang 17
> 
> On Wed, Mar 20, 2024 at 5:30 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Hello Ali, Thomas,
> >
> > On Wed, Mar 20, 2024 at 5:01 PM Ali Alnubani <alialnu@nvidia.com> wrote:
> > >
> > > On Fedora 39 with Clang 17.0.3 and ASan enabled,
> > > RTE_PMD_EXPORT_NAME seems to be done twice for a single
> > > lib, which results in load_drivers() returning a list
> > > consisting of 2 drivers (e.g., ['mlx5_common_pci', '']).
> > > image.find_by_prefix("this_pmd_name") returns 2 symbols in this case,
> > > "mlx5_common_pci" and an empty string ''. This didn't reproduce
> > > with clang version 16.0.6.
> > >
> > > This patch ensures that a symbol with an empty string_value doesn't
> > > cause an addition to the list of drivers.
> >
> > I suppose this comes from ASan instrumenting the code:
> > # nm /root/dpdk/build-clang/drivers/libtmp_rte_common_mlx5.a | grep
> this_pmd
> > 0000000000000000 r this_pmd_name3
> > 0000000000000000 n this_pmd_name3.e5676185d74e2e1a9de646deebca963f
> > 0000000000000000 r this_pmd_name3
> > 0000000000000000 n this_pmd_name3.a2533baf7a46959f41383725087d4086
> >
> > The name of the symbols this script should look for has a clear
> > format, which is this_pmd_name[0-9]+.
> > Filtering with this pattern, there would be no need to go and
> > interpret a symbol content.
> 
> Ali, can you send a v2?
> 

Hi David,

Apologies for the delay, will continue working on this as soon as possible.

Regards,
Ali

      reply	other threads:[~2024-06-27 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 15:58 Ali Alnubani
2024-03-20 16:30 ` David Marchand
2024-06-27 12:36   ` David Marchand
2024-06-27 16:50     ` Ali Alnubani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5167549BD1AD50040D8F2D72DAD72@DM4PR12MB5167.namprd12.prod.outlook.com \
    --to=alialnu@nvidia.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mingjinx.ye@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).