* Re:
[not found] <20211130165631.2467343-1-christian.ehrhardt@canonical.com>
@ 2021-12-01 1:12 ` Huichao Cai
2021-12-01 10:27 ` Re: Christian Ehrhardt
2021-12-01 1:59 ` Wang, Haiyue
` (3 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Huichao Cai @ 2021-12-01 1:12 UTC (permalink / raw)
To: dpdk stable
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
567473433b Huichao Cai ip_frag: fix fragmenting IPv4 fragment
013bb504c8 Huichao Cai ip_frag: revert fix fragmenting IPv4 fragment
These two patches do not require backport.
Huichao Cai
[-- Attachment #2: Type: text/html, Size: 418 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re:
2021-12-01 1:12 ` Huichao Cai
@ 2021-12-01 10:27 ` Christian Ehrhardt
0 siblings, 0 replies; 13+ messages in thread
From: Christian Ehrhardt @ 2021-12-01 10:27 UTC (permalink / raw)
To: Huichao Cai; +Cc: dpdk stable
On Wed, Dec 1, 2021 at 2:13 AM Huichao Cai <chcchc88@163.com> wrote:
>
> 567473433b Huichao Cai ip_frag: fix fragmenting IPv4 fragment
> 013bb504c8 Huichao Cai ip_frag: revert fix fragmenting IPv4 fragment
>
> These two patches do not require backport.
Yeah they cancel out each other anyway :-)
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE:
[not found] <20211130165631.2467343-1-christian.ehrhardt@canonical.com>
2021-12-01 1:12 ` Huichao Cai
@ 2021-12-01 1:59 ` Wang, Haiyue
2021-12-01 10:25 ` Christian Ehrhardt
2021-12-02 14:12 ` Re: David Marchand
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Wang, Haiyue @ 2021-12-01 1:59 UTC (permalink / raw)
To: christian.ehrhardt; +Cc: dpdk stable, Yunjian Wang
Hi Christian,
Applying but breaking the build:
96b25c496a Haiyue Wang net/ice: fix memzone leak after device init failure
The build error is caused by calling new function 'rte_eth_dma_zone_free' which is not
defined in 19.11.
But I think it may be fixed by
1. Keep the patch for file "drivers/net/ice/ice_ethdev.c"
2. Drop the patch for file "drivers/net/ice/ice_fdir_filter.c", then apply
(which is not in stable queue):
https://git.dpdk.org/dpdk/commit/?id=d3778bf39a1dd36181b11459ad3936501ca17f4d
What do you think ?
BR,
Haiyue
> -----Original Message-----
> From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> Sent: Wednesday, December 1, 2021 00:57
> Cc: Aaron Conole <aconole@redhat.com>; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Ajit
> Khaparde <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Ali Alnubani <alialnu@nvidia.com>; Zhang, AlvinX <alvinx.zhang@intel.com>;
> Singh, Aman Deep <aman.deep.singh@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>; Andrew
> Boyer <aboyer@pensando.io>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Andy Moreton
> <amoreton@xilinx.com>; Anoob Joseph <anoobj@marvell.com>; Apeksha Gupta <apeksha.gupta@nxp.com>;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Ashish Gupta <ashish.gupta@marvell.com>; Baruch
> Siach <baruch@tkos.co.il>; Xing, Beilei <beilei.xing@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; Chandubabu Namburu
> <chandu@amd.com>; Chas Williams <chas3@att.com>; Xia, Chenbo <chenbo.xia@intel.com>; Chengchang Tang
> <tangchengchang@huawei.com>; Chengwen Feng <fengchengwen@huawei.com>; Loftus, Ciara
> <ciara.loftus@intel.com>; Power, Ciara <ciara.power@intel.com>; Conor Fogarty
> <conor.fogarty@intel.com>; Walsh, Conor <conor.walsh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Nowlin, Dan <dan.nowlin@intel.com>; Yu, DapengX
> <dapengx.yu@intel.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hunt, David <david.hunt@intel.com>; David Marchand
> <david.marchand@redhat.com>; Doherty, Declan <declan.doherty@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; Devendra Singh Rawat <dsinghrawat@marvell.com>; Dmitry Kozlyuk
> <dkozlyuk@nvidia.com>; Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Dmitry Malloy
> <dmitrym@microsoft.com>; Eli Britstein <elibr@nvidia.com>; Evgeny Schemeilin <evgenys@amazon.com>;
> Zhang, Roy Fan <roy.fan.zhang@intel.com>; Feifei Wang <feifei.wang2@arm.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Gagandeep Singh <g.singh@nxp.com>;
> Gaoxiang Liu <liugaoxiang@huawei.com>; Gregory Etelson <getelson@nvidia.com>; Guoyang Zhou
> <zhouguoyang@huawei.com>; Wang, Haiyue <haiyue.wang@intel.com>; Harman Kalra <hkalra@marvell.com>; Van
> Haaren, Harry <harry.van.haaren@intel.com>; Heinrich Kuhn <heinrich.kuhn@corigine.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Huichao Cai
> <chcchc88@163.com>; Huisong Li <lihuisong@huawei.com>; Hyong Youb Kim <hyonkim@cisco.com>; Idan
> Hackmon <idanhac@nvidia.com>; Igor Chauskin <igorch@amazon.com>; Igor Romanov
> <igor.romanov@oktetlabs.ru>; Igor Russkikh <irusskikh@marvell.com>; Igor Ryzhov <iryzhov@nfware.com>;
> Ilyes Ben Hamouda <ilyes.ben_hamouda@6wind.com>; Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>; Ivan
> Malov <ivan.malov@oktetlabs.ru>; Jakub Grajciar <jgrajcia@cisco.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jay Zhou
> <jianjay.zhou@huawei.com>; Jerin Jacob <jerinj@marvell.com>; Jian Wang <jianwang@trustnetic.com>;
> Jiawen Wu <jiawenwu@trustnetic.com>; Wang, Jie1X <jie1x.wang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Daley, John <johndale@cisco.com>; Griffin, John <john.griffin@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; John W. Linville <linville@tuxdriver.com>; Joyce Kong
> <joyce.kong@arm.com>
> Subject:
>
> Subject: please help backporting some patches to stable release 19.11.11
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
> I didn't apply following commits from DPDK main to 19.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
> - Backport your patches to the 19.11 branch, or
> - Indicate that the patch should not be backported
>
> Please do either of the above by December the 14th 2021 (More time than
> usual as backports get harder).
>
> You can find the a temporary work-in-progress branch of the coming 19.11.11
> release at:
> https://github.com/cpaelzer/dpdk-stable-queue
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
> [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
> https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
> [PATCH 19.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
> --subject-prefix='PATCH 19.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 19.11 is located at tree:
> https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> ---
>
> Applying but breaking the build:
>
> 858a152ab5 Junxiao Shi net/memif: allow stopping and closing device
> c4d3e8fbe4 Ruifeng Wang net/i40e: fix risk in descriptor read in scalar Rx
> 7dc627426e Olivier Matz test/mbuf: fix access to freed memory
> 86e361cdeb David Marchand test/cmdline: fix memory leak
> 04bcc80204 Xuan Ding net/virtio: fix indirect descriptor reconnection
> 9de76dfb92 Ivan Ilchenko net/virtio: fix Tx completed mbuf leak on device stop
> 5d903aee8a Gaoxiang Liu net/virtio: fix repeated freeing of virtqueue
> 9c8c806487 Thomas Monjalon test/crypto: fix minsize build
> 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init failure
>
> ---
>
> Not Applying
>
> ed0ae3502f Ajit Khaparde net/bnxt: update ring group after ring stop start
> 94421842de Alexander Kozyrev net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> 9e61533df2 Alexander Kozyrev net/mlx5: fix GRE flow item matching
> 02220e5305 Alvin Zhang app/testpmd: fix txonly forwarding
> a78040c990 Alvin Zhang app/testpmd: update forward engine beginning
> c1c99d3421 Alvin Zhang net/ice: fix pointer of meta data
> 4fd15c6af0 Anatoly Burakov vfio: set errno on unsupported OS
> febc855b35 Andrew Rybchenko ethdev: forbid closing started device
> 0015b149bc Anoob Joseph test/crypto: fix missing return checks
> 156eee2177 Arek Kusztal common/qat: fix queue pair config overrun
> 0f2ffb49ce Baruch Siach net/af_xdp: fix zero-copy Tx queue drain
> 897e55c8d2 Bruce Richardson doc: fix Doxygen examples build on FreeBSD
> 2fc3e696a7 Chengchang Tang net/hns3: add runtime config for mailbox limit time
> 3fb0df3138 Chengchang Tang net/hns3: fix taskqueue pair reset command
> 0b77e8f3d3 Chengwen Feng net/hns3: optimize Tx performance
> 3cc817c195 Chengwen Feng net/hns3: optimize Tx performance by mbuf fast free
> c0daf3bd4b Ciara Power test/crypto: remove unnecessary stats retrieval
> 9465a5d5a0 Conor Walsh net/nfp: remove unused message length
> ccf0f002d2 Dapeng Yu net/bonding: fix memory leak on closing device
> 7775172c04 Dariusz Sosnowski net/mlx5: fix partial inline of fine grain packets
> fe629897de David Marchand app/testpmd: remove double dependency on bitrate lib
> b72099be7f David Marchand net/virtio-user: fix init when using existing tap
> 4a985f4e84 David Marchand test/service: fix race in attr check
> 9790fc2149 Dmitry Kozlyuk eal/freebsd: fix IOVA mode selection
> bc5bee028e Dmitry Kozlyuk net/mlx5: create drop queue using DevX
> c5042f93a4 Dmitry Kozlyuk net/mlx5: discover max flow priority using DevX
> 6a8b64fd5e Eli Britstein app/testpmd: fix packet burst spreading stats
> 5139502783 Ferruh Yigit ethdev: fix typos
> a1b2558cdb Ferruh Yigit kni: restrict bifurcated device support
> 451dc0fad8 Gaoxiang Liu vhost: fix crash on port deletion
> 9f151fd8df Gregory Etelson net/mlx5: add Ethernet header to GENEVE RSS expansion
> 690391dd0e Gregory Etelson net/mlx5: fix GENEVE protocol type translation
> be26e81bfc Gregory Etelson net/mlx5: fix GRE protocol type translation
> 861fa3796f Gregory Etelson net/mlx5: fix VXLAN-GPE next protocol translation
> 567473433b Huichao Cai ip_frag: fix fragmenting IPv4 fragment
> 013bb504c8 Huichao Cai ip_frag: revert fix fragmenting IPv4 fragment
> 841f869353 Huisong Li net/hns3: fix multi-process action register and unregister
> 19e67d8ebc Huisong Li net/hns3: fix residual MAC after setting default MAC
> 3232637177 Huisong Li net/hns3: fix secondary process reference count
> 443242212b Huisong Li net/hns3: unregister MP action on close for secondary
> 770d41bf33 Ilyes Ben Hamouda malloc: fix allocation with unknown socket ID
> 580f3af31c Ivan Ilchenko net/virtio: fix device configure without jumbo Rx offload
> c97e73779c Ivan Ilchenko net/virtio: fix split queue vectorized Rx
> e2ca43a35e Ivan Ilchenko net/virtio: fix Tx cleanup functions to have same signature
> 6474b59448 Ivan Malov net/virtio: fix Tx checksum for tunnel packets
> cbe70fded8 Jie Wang app/testpmd: fix DCB in VT configuration
> 655eae01f9 Jie Wang app/testpmd: fix RSS hash offload display
> 8cc79a1636 Jie Wang net/i40e: fix forward outer IPv6 VXLAN
> d5559ac589 Joyce Kong test/func_reentrancy: free memzones after test
> baedf29794 Kalesh AP net/bnxt: check FW capability for VLAN offloads
> 620e0290d1 Kalesh AP net/bnxt: fix VLAN indication in Rx mbuf
> 6c16a05c8c Kefu Chai doc: fix a typo in EAL guide
> 0c3fa68396 Lior Margalit net/mlx5: fix RSS expansion for L2/L3 VXLAN
> aa52e5f0f9 Lior Margalit net/mlx5: fix RSS expansion traversal over next nodes
> 76b5bdf828 Matan Azrad common/mlx5: create wrapped MR
> 8594e2a64f Matan Azrad common/mlx5: fix build for zero-length headroom array
> b6e9c33c82 Michael Baum net/mlx5: remove duplicated reference of Tx doorbell
> 8451e165b8 Michael Baum net/mlx5: workaround MR creation for flow counter
> e2a6d08bef Michal Krawczyk net/ena: advertise scattered Rx capability
> e8c838fde9 Michal Krawczyk net/ena: fix offload capabilities verification
> 3a822d79c5 Michal Krawczyk net/ena: fix per-queue offload capabilities
> 599ef84add Min Hu (Connor) net/hns3: fix mailbox communication with HW
> 818ce1132a Mohsin Kazmi net: fix checksum offload for outer IPv4
> efc6f9104c Olivier Matz mbuf: fix reset on mbuf free
> de5bef335e Qiming Chen net/iavf: fix high CPU usage on frequent command
> 3affa0ef2d Qi Zhang net/ice/base: calculate logical PF ID
> 778602fe57 Ruifeng Wang net/i40e: fix risk in descriptor read in NEON Rx
> 35bd0a5c58 Sean Morrissey doc: capitalise PMD
> f8dbaebbf1 Sean Morrissey fix PMD wording
> a7e21843f0 Somnath Kotur net/bnxt: fix Rx next consumer index in mbuf alloc fail
> accf3cfce4 Tal Shnaiderman net/mlx5: fix software parsing support query
> c1a320bf89 Tal Shnaiderman net/mlx5: fix tunneling support query
> f86d553cc1 Tudor Cornea net/af_packet: fix ignoring full ring on Tx
> 2108930be1 Tudor Cornea net/ixgbe: fix port initialization if MTU config fails
> e30ef3a3a0 Vladimir Medvedkin test/hash: fix buffer overflow with jhash
> ad6f01945a Xuan Ding net/virtio: fix avail descriptor ID
> 68fa62924d Xueming Li net/mlx5: fix Altivec Rx
> 84cc857b5d Zhihong Peng net/virtio: fix check scatter on all Rx queues
^ permalink raw reply [flat|nested] 13+ messages in thread* Re:
2021-12-01 1:59 ` Wang, Haiyue
@ 2021-12-01 10:25 ` Christian Ehrhardt
0 siblings, 0 replies; 13+ messages in thread
From: Christian Ehrhardt @ 2021-12-01 10:25 UTC (permalink / raw)
To: Wang, Haiyue; +Cc: dpdk stable, Yunjian Wang
.
T
On Wed, Dec 1, 2021 at 2:59 AM Wang, Haiyue <haiyue.wang@intel.com> wrote:
>
> Hi Christian,
>
> Applying but breaking the build:
> 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init failure
>
> The build error is caused by calling new function 'rte_eth_dma_zone_free' which is not
> defined in 19.11.
>
> But I think it may be fixed by
> 1. Keep the patch for file "drivers/net/ice/ice_ethdev.c"
> 2. Drop the patch for file "drivers/net/ice/ice_fdir_filter.c", then apply
> (which is not in stable queue):
> https://git.dpdk.org/dpdk/commit/?id=d3778bf39a1dd36181b11459ad3936501ca17f4d
I'm tried combining 96b25c496a with d3778bf39 as the latter removes
the reference to rte_eth_dma_zone_free
The result LGTM at first - builds works fine now with both applied.
It was filtered out by the tooling as it fixed an issue only present
in a later release.
Thanks for making me aware of it!
> What do you think ?
>
> BR,
> Haiyue
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> > Sent: Wednesday, December 1, 2021 00:57
> > Cc: Aaron Conole <aconole@redhat.com>; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Ajit
> > Khaparde <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>; Alexander Kozyrev
> > <akozyrev@nvidia.com>; Ali Alnubani <alialnu@nvidia.com>; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > Singh, Aman Deep <aman.deep.singh@intel.com>; Burakov, Anatoly <anatoly.burakov@intel.com>; Andrew
> > Boyer <aboyer@pensando.io>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Andy Moreton
> > <amoreton@xilinx.com>; Anoob Joseph <anoobj@marvell.com>; Apeksha Gupta <apeksha.gupta@nxp.com>;
> > Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Ashish Gupta <ashish.gupta@marvell.com>; Baruch
> > Siach <baruch@tkos.co.il>; Xing, Beilei <beilei.xing@intel.com>; Iremonger, Bernard
> > <bernard.iremonger@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; Chandubabu Namburu
> > <chandu@amd.com>; Chas Williams <chas3@att.com>; Xia, Chenbo <chenbo.xia@intel.com>; Chengchang Tang
> > <tangchengchang@huawei.com>; Chengwen Feng <fengchengwen@huawei.com>; Loftus, Ciara
> > <ciara.loftus@intel.com>; Power, Ciara <ciara.power@intel.com>; Conor Fogarty
> > <conor.fogarty@intel.com>; Walsh, Conor <conor.walsh@intel.com>; Dumitrescu, Cristian
> > <cristian.dumitrescu@intel.com>; Nowlin, Dan <dan.nowlin@intel.com>; Yu, DapengX
> > <dapengx.yu@intel.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Hunt, David <david.hunt@intel.com>; David Marchand
> > <david.marchand@redhat.com>; Doherty, Declan <declan.doherty@intel.com>; Jain, Deepak K
> > <deepak.k.jain@intel.com>; Devendra Singh Rawat <dsinghrawat@marvell.com>; Dmitry Kozlyuk
> > <dkozlyuk@nvidia.com>; Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Dmitry Malloy
> > <dmitrym@microsoft.com>; Eli Britstein <elibr@nvidia.com>; Evgeny Schemeilin <evgenys@amazon.com>;
> > Zhang, Roy Fan <roy.fan.zhang@intel.com>; Feifei Wang <feifei.wang2@arm.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Gagandeep Singh <g.singh@nxp.com>;
> > Gaoxiang Liu <liugaoxiang@huawei.com>; Gregory Etelson <getelson@nvidia.com>; Guoyang Zhou
> > <zhouguoyang@huawei.com>; Wang, Haiyue <haiyue.wang@intel.com>; Harman Kalra <hkalra@marvell.com>; Van
> > Haaren, Harry <harry.van.haaren@intel.com>; Heinrich Kuhn <heinrich.kuhn@corigine.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Huichao Cai
> > <chcchc88@163.com>; Huisong Li <lihuisong@huawei.com>; Hyong Youb Kim <hyonkim@cisco.com>; Idan
> > Hackmon <idanhac@nvidia.com>; Igor Chauskin <igorch@amazon.com>; Igor Romanov
> > <igor.romanov@oktetlabs.ru>; Igor Russkikh <irusskikh@marvell.com>; Igor Ryzhov <iryzhov@nfware.com>;
> > Ilyes Ben Hamouda <ilyes.ben_hamouda@6wind.com>; Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>; Ivan
> > Malov <ivan.malov@oktetlabs.ru>; Jakub Grajciar <jgrajcia@cisco.com>; Singh, Jasvinder
> > <jasvinder.singh@intel.com>; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jay Zhou
> > <jianjay.zhou@huawei.com>; Jerin Jacob <jerinj@marvell.com>; Jian Wang <jianwang@trustnetic.com>;
> > Jiawen Wu <jiawenwu@trustnetic.com>; Wang, Jie1X <jie1x.wang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Daley, John <johndale@cisco.com>; Griffin, John <john.griffin@intel.com>;
> > Mcnamara, John <john.mcnamara@intel.com>; John W. Linville <linville@tuxdriver.com>; Joyce Kong
> > <joyce.kong@arm.com>
> > Subject:
> >
> > Subject: please help backporting some patches to stable release 19.11.11
> >
> > Hi commit authors (and maintainers),
> >
> > Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
> > I didn't apply following commits from DPDK main to 19.11
> > stable branch, as conflicts or build errors occur.
> >
> > Can authors check your patches in the following list and either:
> > - Backport your patches to the 19.11 branch, or
> > - Indicate that the patch should not be backported
> >
> > Please do either of the above by December the 14th 2021 (More time than
> > usual as backports get harder).
> >
> > You can find the a temporary work-in-progress branch of the coming 19.11.11
> > release at:
> > https://github.com/cpaelzer/dpdk-stable-queue
> > It is recommended to backport on top of that to minimize further conflicts or
> > misunderstandings.
> >
> > Some notes on stable backports:
> >
> > A backport should contain a reference to the DPDK main branch commit
> > in it's commit message in the following fashion:
> > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> >
> > For example:
> > https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> >
> > When sending the backported patch, please indicate the target branch in the
> > subject line, as we have multiple branches, for example:
> > [PATCH 19.11] foo/bar: fix baz
> >
> > With git format-patch, this can be achieved by appending the parameter:
> > --subject-prefix='PATCH 19.11'
> >
> > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> >
> > FYI, branch 19.11 is located at tree:
> > https://git.dpdk.org/dpdk-stable
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
> >
> > Applying but breaking the build:
> >
> > 858a152ab5 Junxiao Shi net/memif: allow stopping and closing device
> > c4d3e8fbe4 Ruifeng Wang net/i40e: fix risk in descriptor read in scalar Rx
> > 7dc627426e Olivier Matz test/mbuf: fix access to freed memory
> > 86e361cdeb David Marchand test/cmdline: fix memory leak
> > 04bcc80204 Xuan Ding net/virtio: fix indirect descriptor reconnection
> > 9de76dfb92 Ivan Ilchenko net/virtio: fix Tx completed mbuf leak on device stop
> > 5d903aee8a Gaoxiang Liu net/virtio: fix repeated freeing of virtqueue
> > 9c8c806487 Thomas Monjalon test/crypto: fix minsize build
> > 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init failure
> >
> > ---
> >
> > Not Applying
> >
> > ed0ae3502f Ajit Khaparde net/bnxt: update ring group after ring stop start
> > 94421842de Alexander Kozyrev net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> > 9e61533df2 Alexander Kozyrev net/mlx5: fix GRE flow item matching
> > 02220e5305 Alvin Zhang app/testpmd: fix txonly forwarding
> > a78040c990 Alvin Zhang app/testpmd: update forward engine beginning
> > c1c99d3421 Alvin Zhang net/ice: fix pointer of meta data
> > 4fd15c6af0 Anatoly Burakov vfio: set errno on unsupported OS
> > febc855b35 Andrew Rybchenko ethdev: forbid closing started device
> > 0015b149bc Anoob Joseph test/crypto: fix missing return checks
> > 156eee2177 Arek Kusztal common/qat: fix queue pair config overrun
> > 0f2ffb49ce Baruch Siach net/af_xdp: fix zero-copy Tx queue drain
> > 897e55c8d2 Bruce Richardson doc: fix Doxygen examples build on FreeBSD
> > 2fc3e696a7 Chengchang Tang net/hns3: add runtime config for mailbox limit time
> > 3fb0df3138 Chengchang Tang net/hns3: fix taskqueue pair reset command
> > 0b77e8f3d3 Chengwen Feng net/hns3: optimize Tx performance
> > 3cc817c195 Chengwen Feng net/hns3: optimize Tx performance by mbuf fast free
> > c0daf3bd4b Ciara Power test/crypto: remove unnecessary stats retrieval
> > 9465a5d5a0 Conor Walsh net/nfp: remove unused message length
> > ccf0f002d2 Dapeng Yu net/bonding: fix memory leak on closing device
> > 7775172c04 Dariusz Sosnowski net/mlx5: fix partial inline of fine grain packets
> > fe629897de David Marchand app/testpmd: remove double dependency on bitrate lib
> > b72099be7f David Marchand net/virtio-user: fix init when using existing tap
> > 4a985f4e84 David Marchand test/service: fix race in attr check
> > 9790fc2149 Dmitry Kozlyuk eal/freebsd: fix IOVA mode selection
> > bc5bee028e Dmitry Kozlyuk net/mlx5: create drop queue using DevX
> > c5042f93a4 Dmitry Kozlyuk net/mlx5: discover max flow priority using DevX
> > 6a8b64fd5e Eli Britstein app/testpmd: fix packet burst spreading stats
> > 5139502783 Ferruh Yigit ethdev: fix typos
> > a1b2558cdb Ferruh Yigit kni: restrict bifurcated device support
> > 451dc0fad8 Gaoxiang Liu vhost: fix crash on port deletion
> > 9f151fd8df Gregory Etelson net/mlx5: add Ethernet header to GENEVE RSS expansion
> > 690391dd0e Gregory Etelson net/mlx5: fix GENEVE protocol type translation
> > be26e81bfc Gregory Etelson net/mlx5: fix GRE protocol type translation
> > 861fa3796f Gregory Etelson net/mlx5: fix VXLAN-GPE next protocol translation
> > 567473433b Huichao Cai ip_frag: fix fragmenting IPv4 fragment
> > 013bb504c8 Huichao Cai ip_frag: revert fix fragmenting IPv4 fragment
> > 841f869353 Huisong Li net/hns3: fix multi-process action register and unregister
> > 19e67d8ebc Huisong Li net/hns3: fix residual MAC after setting default MAC
> > 3232637177 Huisong Li net/hns3: fix secondary process reference count
> > 443242212b Huisong Li net/hns3: unregister MP action on close for secondary
> > 770d41bf33 Ilyes Ben Hamouda malloc: fix allocation with unknown socket ID
> > 580f3af31c Ivan Ilchenko net/virtio: fix device configure without jumbo Rx offload
> > c97e73779c Ivan Ilchenko net/virtio: fix split queue vectorized Rx
> > e2ca43a35e Ivan Ilchenko net/virtio: fix Tx cleanup functions to have same signature
> > 6474b59448 Ivan Malov net/virtio: fix Tx checksum for tunnel packets
> > cbe70fded8 Jie Wang app/testpmd: fix DCB in VT configuration
> > 655eae01f9 Jie Wang app/testpmd: fix RSS hash offload display
> > 8cc79a1636 Jie Wang net/i40e: fix forward outer IPv6 VXLAN
> > d5559ac589 Joyce Kong test/func_reentrancy: free memzones after test
> > baedf29794 Kalesh AP net/bnxt: check FW capability for VLAN offloads
> > 620e0290d1 Kalesh AP net/bnxt: fix VLAN indication in Rx mbuf
> > 6c16a05c8c Kefu Chai doc: fix a typo in EAL guide
> > 0c3fa68396 Lior Margalit net/mlx5: fix RSS expansion for L2/L3 VXLAN
> > aa52e5f0f9 Lior Margalit net/mlx5: fix RSS expansion traversal over next nodes
> > 76b5bdf828 Matan Azrad common/mlx5: create wrapped MR
> > 8594e2a64f Matan Azrad common/mlx5: fix build for zero-length headroom array
> > b6e9c33c82 Michael Baum net/mlx5: remove duplicated reference of Tx doorbell
> > 8451e165b8 Michael Baum net/mlx5: workaround MR creation for flow counter
> > e2a6d08bef Michal Krawczyk net/ena: advertise scattered Rx capability
> > e8c838fde9 Michal Krawczyk net/ena: fix offload capabilities verification
> > 3a822d79c5 Michal Krawczyk net/ena: fix per-queue offload capabilities
> > 599ef84add Min Hu (Connor) net/hns3: fix mailbox communication with HW
> > 818ce1132a Mohsin Kazmi net: fix checksum offload for outer IPv4
> > efc6f9104c Olivier Matz mbuf: fix reset on mbuf free
> > de5bef335e Qiming Chen net/iavf: fix high CPU usage on frequent command
> > 3affa0ef2d Qi Zhang net/ice/base: calculate logical PF ID
> > 778602fe57 Ruifeng Wang net/i40e: fix risk in descriptor read in NEON Rx
> > 35bd0a5c58 Sean Morrissey doc: capitalise PMD
> > f8dbaebbf1 Sean Morrissey fix PMD wording
> > a7e21843f0 Somnath Kotur net/bnxt: fix Rx next consumer index in mbuf alloc fail
> > accf3cfce4 Tal Shnaiderman net/mlx5: fix software parsing support query
> > c1a320bf89 Tal Shnaiderman net/mlx5: fix tunneling support query
> > f86d553cc1 Tudor Cornea net/af_packet: fix ignoring full ring on Tx
> > 2108930be1 Tudor Cornea net/ixgbe: fix port initialization if MTU config fails
> > e30ef3a3a0 Vladimir Medvedkin test/hash: fix buffer overflow with jhash
> > ad6f01945a Xuan Ding net/virtio: fix avail descriptor ID
> > 68fa62924d Xueming Li net/mlx5: fix Altivec Rx
> > 84cc857b5d Zhihong Peng net/virtio: fix check scatter on all Rx queues
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re:
[not found] <20211130165631.2467343-1-christian.ehrhardt@canonical.com>
2021-12-01 1:12 ` Huichao Cai
2021-12-01 1:59 ` Wang, Haiyue
@ 2021-12-02 14:12 ` David Marchand
2021-12-03 6:12 ` Re: Christian Ehrhardt
2021-12-02 14:29 ` Re: Ferruh Yigit
2021-12-12 14:20 ` Ali Alnubani
4 siblings, 1 reply; 13+ messages in thread
From: David Marchand @ 2021-12-02 14:12 UTC (permalink / raw)
To: dpdk stable
Cc: Aaron Conole, Abhinandan Gujjar, Ajit Khaparde, Akhil Goyal,
Alexander Kozyrev, Ali Alnubani, Alvin Zhang, Aman Singh,
Anatoly Burakov, Andrew Boyer, Andrew Rybchenko, Andy Moreton,
Anoob Joseph, Apeksha Gupta, Arek Kusztal, Ashish Gupta,
Baruch Siach, Beilei Xing, Bernard Iremonger, Bruce Richardson,
Chandubabu Namburu, Chas Williams, Chenbo Xia, Chengchang Tang,
Chengwen Feng, Ciara Loftus, Ciara Power, Conor Fogarty,
Conor Walsh, Cristian Dumitrescu, Dan Nowlin, Dapeng Yu,
Dariusz Sosnowski, David Christensen, David Hunt, Declan Doherty,
Deepak Kumar Jain, Devendra Singh Rawat, Dmitry Kozlyuk,
Dmitry Kozlyuk, Dmitry Malloy, Eli Britstein, Evgeny Schemeilin,
Fan Zhang, Feifei Wang, Ferruh Yigit, Fiona Trahe,
Gagandeep Singh, Gaoxiang Liu, Gregory Etelson, Guoyang Zhou,
Haiyue Wang, Harman Kalra, Harry van Haaren, Heinrich Kuhn,
Hemant Agrawal, Honnappa Nagarahalli, Huichao Cai, Huisong Li,
Hyong Youb Kim, Idan Hackmon, Igor Chauskin, Igor Romanov,
Igor Russkikh, Igor Ryzhov, Ilyes Ben Hamouda, Ivan Ilchenko,
Ivan Malov, Jakub Grajciar, Jasvinder Singh, Jay Jayatheerthan,
Jay Zhou, Jerin Jacob, Jian Wang, Jiawen Wu, Jie Wang,
Jingjing Wu, John Daley, John Griffin, John McNamara,
John W. Linville, Joyce Kong
Hello,
On Tue, Nov 30, 2021 at 5:56 PM <christian.ehrhardt@canonical.com> wrote:
> Applying but breaking the build:
>
> 86e361cdeb David Marchand test/cmdline: fix memory leak
It is not marked for backport: it fixes 6ad06203a587 ("cmdline: free
on exit") that introduced an API change (making it itself not
backportable).
Why did you consider this patch?
> ---
>
> Not Applying
>
> fe629897de David Marchand app/testpmd: remove double dependency on bitrate lib
Looking at 19.11 branch, this backport is not needed as Luca already
dropped double reference in a 19.11 only patch:
a7a21ffad191 ("Revert "app/testpmd: fix name of bitrate library in
meson build"")
> b72099be7f David Marchand net/virtio-user: fix init when using existing tap
This was not supported before, and it is not marked for backport, on purpose.
> 4a985f4e84 David Marchand test/service: fix race in attr check
It fixes another fix which is not in 19.11:
52bb6be259ff ("test/service: fix race condition on stopping lcore")
You can skip it.
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 13+ messages in thread* Re:
2021-12-02 14:12 ` Re: David Marchand
@ 2021-12-03 6:12 ` Christian Ehrhardt
0 siblings, 0 replies; 13+ messages in thread
From: Christian Ehrhardt @ 2021-12-03 6:12 UTC (permalink / raw)
To: David Marchand
Cc: dpdk stable, Aaron Conole, Abhinandan Gujjar, Ajit Khaparde,
Akhil Goyal, Alexander Kozyrev, Ali Alnubani, Alvin Zhang,
Aman Singh, Anatoly Burakov, Andrew Boyer, Andrew Rybchenko,
Andy Moreton, Anoob Joseph, Apeksha Gupta, Arek Kusztal,
Ashish Gupta, Baruch Siach, Beilei Xing, Bernard Iremonger,
Bruce Richardson, Chandubabu Namburu, Chas Williams, Chenbo Xia,
Chengchang Tang, Chengwen Feng, Ciara Loftus, Ciara Power,
Conor Fogarty, Conor Walsh, Cristian Dumitrescu, Dan Nowlin,
Dapeng Yu, Dariusz Sosnowski, David Christensen, David Hunt,
Declan Doherty, Deepak Kumar Jain, Devendra Singh Rawat,
Dmitry Kozlyuk, Dmitry Kozlyuk, Dmitry Malloy, Eli Britstein,
Evgeny Schemeilin, Fan Zhang, Feifei Wang, Ferruh Yigit,
Fiona Trahe, Gagandeep Singh, Gaoxiang Liu, Gregory Etelson,
Guoyang Zhou, Haiyue Wang, Harman Kalra, Harry van Haaren,
Heinrich Kuhn, Hemant Agrawal, Honnappa Nagarahalli, Huichao Cai,
Huisong Li, Hyong Youb Kim, Idan Hackmon, Igor Chauskin,
Igor Romanov, Igor Russkikh, Igor Ryzhov, Ilyes Ben Hamouda,
Ivan Ilchenko, Ivan Malov, Jakub Grajciar, Jasvinder Singh,
Jay Jayatheerthan, Jay Zhou, Jerin Jacob, Jian Wang, Jiawen Wu,
Jie Wang, Jingjing Wu, John Daley, John Griffin, John McNamara,
John W. Linville, Joyce Kong
On Thu, Dec 2, 2021 at 3:12 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Hello,
>
> On Tue, Nov 30, 2021 at 5:56 PM <christian.ehrhardt@canonical.com> wrote:
> > Applying but breaking the build:
> >
> > 86e361cdeb David Marchand test/cmdline: fix memory leak
>
> It is not marked for backport: it fixes 6ad06203a587 ("cmdline: free
> on exit") that introduced an API change (making it itself not
> backportable).
> Why did you consider this patch?
Hi David,
the tooling selects initially any patch that fulfils either condition
1. marked for stable@dpdk
2. has a Fixes: entry
3. has "fix" in the subject
We (the stable maintainers) then do some filtering for patches that we
find non-needed or ABI affecting.
This time for example I cut down an initial 516 to 274.
But we might miss one and hence the requests to the Authors (as they
know best) and the further testing from there.
> > ---
> >
> > Not Applying
> >
> > fe629897de David Marchand app/testpmd: remove double dependency on bitrate lib
>
> Looking at 19.11 branch, this backport is not needed as Luca already
> dropped double reference in a 19.11 only patch:
> a7a21ffad191 ("Revert "app/testpmd: fix name of bitrate library in
> meson build"")
Ok
> > b72099be7f David Marchand net/virtio-user: fix init when using existing tap
>
> This was not supported before, and it is not marked for backport, on purpose.
>
>
> > 4a985f4e84 David Marchand test/service: fix race in attr check
>
> It fixes another fix which is not in 19.11:
> 52bb6be259ff ("test/service: fix race condition on stopping lcore")
>
> You can skip it.
Ok
Thanks for your expertise on your changes!
> Thanks.
>
> --
> David Marchand
>
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re:
[not found] <20211130165631.2467343-1-christian.ehrhardt@canonical.com>
` (2 preceding siblings ...)
2021-12-02 14:12 ` Re: David Marchand
@ 2021-12-02 14:29 ` Ferruh Yigit
2021-12-03 6:18 ` Re: Christian Ehrhardt
2021-12-12 14:20 ` Ali Alnubani
4 siblings, 1 reply; 13+ messages in thread
From: Ferruh Yigit @ 2021-12-02 14:29 UTC (permalink / raw)
To: dpdk stable
Cc: Aaron Conole, Abhinandan Gujjar, Ajit Khaparde, Akhil Goyal,
Alexander Kozyrev, Ali Alnubani, Alvin Zhang, Aman Singh,
Anatoly Burakov, Andrew Boyer, Andrew Rybchenko, Andy Moreton,
Anoob Joseph, Apeksha Gupta, Arek Kusztal, Ashish Gupta,
Baruch Siach, Beilei Xing, Bernard Iremonger, Bruce Richardson,
Chandubabu Namburu, Chas Williams, Chenbo Xia, Chengchang Tang,
Chengwen Feng, Ciara Loftus, Ciara Power, Conor Fogarty,
Conor Walsh, Cristian Dumitrescu, Dan Nowlin, Dapeng Yu,
Dariusz Sosnowski, David Christensen, David Hunt, David Marchand,
Declan Doherty, Deepak Kumar Jain, Devendra Singh Rawat,
Dmitry Kozlyuk, Dmitry Kozlyuk, Dmitry Malloy, Eli Britstein,
Evgeny Schemeilin, Fan Zhang, Feifei Wang, Fiona Trahe,
Gagandeep Singh, Gaoxiang Liu, Gregory Etelson, Guoyang Zhou,
Haiyue Wang, Harman Kalra, Harry van Haaren, Heinrich Kuhn,
Hemant Agrawal, Honnappa Nagarahalli, Huichao Cai, Huisong Li,
Hyong Youb Kim, Idan Hackmon, Igor Chauskin, Igor Romanov,
Igor Russkikh, Igor Ryzhov, Ilyes Ben Hamouda, Ivan Ilchenko,
Ivan Malov, Jakub Grajciar, Jasvinder Singh, Jay Jayatheerthan,
Jay Zhou, Jerin Jacob, Jian Wang, Jiawen Wu, Jie Wang,
Jingjing Wu, John Daley, John Griffin, John McNamara,
John W. Linville, Joyce Kong
On 11/30/2021 4:56 PM, christian.ehrhardt@canonical.com wrote:
> 5139502783 Ferruh Yigit ethdev: fix typos
These are simple 4 typo fixes, I think we can skip it. But if you think
we should get it, I can send a backport patch.
One of the commit that this patch fixes is after 19.11, that should be
reason why apply fails.
> a1b2558cdb Ferruh Yigit kni: restrict bifurcated device support
This doesn't apply to 19.11, OK to skip it.
Asking just to understand, the patch has fixes tag as:
Fixes: 631217c76135 ("kni: fix kernel deadlock with bifurcated device")
The '631217c76135' is not exist in 19.11, isn't the script check
for this?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re:
2021-12-02 14:29 ` Re: Ferruh Yigit
@ 2021-12-03 6:18 ` Christian Ehrhardt
2021-12-03 9:38 ` Re: Ferruh Yigit
0 siblings, 1 reply; 13+ messages in thread
From: Christian Ehrhardt @ 2021-12-03 6:18 UTC (permalink / raw)
To: Ferruh Yigit
Cc: dpdk stable, Aaron Conole, Abhinandan Gujjar, Ajit Khaparde,
Akhil Goyal, Alexander Kozyrev, Ali Alnubani, Alvin Zhang,
Aman Singh, Anatoly Burakov, Andrew Boyer, Andrew Rybchenko,
Andy Moreton, Anoob Joseph, Apeksha Gupta, Arek Kusztal,
Ashish Gupta, Baruch Siach, Beilei Xing, Bernard Iremonger,
Bruce Richardson, Chandubabu Namburu, Chas Williams, Chenbo Xia,
Chengchang Tang, Chengwen Feng, Ciara Loftus, Ciara Power,
Conor Fogarty, Conor Walsh, Cristian Dumitrescu, Dan Nowlin,
Dapeng Yu, Dariusz Sosnowski, David Christensen, David Hunt,
David Marchand, Declan Doherty, Deepak Kumar Jain,
Devendra Singh Rawat, Dmitry Kozlyuk, Dmitry Kozlyuk,
Dmitry Malloy, Eli Britstein, Evgeny Schemeilin, Fan Zhang,
Feifei Wang, Fiona Trahe, Gagandeep Singh, Gaoxiang Liu,
Gregory Etelson, Guoyang Zhou, Haiyue Wang, Harman Kalra,
Harry van Haaren, Heinrich Kuhn, Hemant Agrawal,
Honnappa Nagarahalli, Huichao Cai, Huisong Li, Hyong Youb Kim,
Idan Hackmon, Igor Chauskin, Igor Romanov, Igor Russkikh,
Igor Ryzhov, Ilyes Ben Hamouda, Ivan Ilchenko, Ivan Malov,
Jakub Grajciar, Jasvinder Singh, Jay Jayatheerthan, Jay Zhou,
Jerin Jacob, Jian Wang, Jiawen Wu, Jie Wang, Jingjing Wu,
John Daley, John Griffin, John McNamara, John W. Linville,
Joyce Kong
On Thu, Dec 2, 2021 at 3:30 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 11/30/2021 4:56 PM, christian.ehrhardt@canonical.com wrote:
> > 5139502783 Ferruh Yigit ethdev: fix typos
>
> These are simple 4 typo fixes, I think we can skip it. But if you think
> we should get it, I can send a backport patch.
We clearly do not have any "hard need" for typo fixes.
But if we do not apply too many of them sooner or later nothing will
apply easily anymore.
So if it isn't feeling like a burden a backport would be appreciated
to help the further lifetime of 19.11.x
> One of the commit that this patch fixes is after 19.11, that should be
> reason why apply fails.
>
> > a1b2558cdb Ferruh Yigit kni: restrict bifurcated device support
>
> This doesn't apply to 19.11, OK to skip it.
ok
> Asking just to understand, the patch has fixes tag as:
> Fixes: 631217c76135 ("kni: fix kernel deadlock with bifurcated device")
>
> The '631217c76135' is not exist in 19.11, isn't the script check
> for this?
Not really, it is going the full chain of fixes, and if that is in the
target release it is considered.
So in this case it is:
21.11 a1b2558cdb S F kni: restrict bifurcated device support (1.3.0r0
(partially fixed in 21.05))
Which is saying
1. this is a1b2558cdb which fixes 631217c7
2. 631217c7 fixed something in 1.3.0r0
3. since you are >>19.11 you might want this
It does not (but probably could and sort out some false positives)
check in #2 if that one is really applied on the stable branch.
I think we could check the [ upstream commit ... ] for that and
exclude or at least mark them in this case.
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 13+ messages in thread* Re:
2021-12-03 6:18 ` Re: Christian Ehrhardt
@ 2021-12-03 9:38 ` Ferruh Yigit
0 siblings, 0 replies; 13+ messages in thread
From: Ferruh Yigit @ 2021-12-03 9:38 UTC (permalink / raw)
To: Christian Ehrhardt
Cc: dpdk stable, Aaron Conole, Abhinandan Gujjar, Ajit Khaparde,
Akhil Goyal, Alexander Kozyrev, Ali Alnubani, Alvin Zhang,
Aman Singh, Anatoly Burakov, Andrew Boyer, Andrew Rybchenko,
Andy Moreton, Anoob Joseph, Apeksha Gupta, Arek Kusztal,
Ashish Gupta, Baruch Siach, Beilei Xing, Bernard Iremonger,
Bruce Richardson, Chandubabu Namburu, Chas Williams, Chenbo Xia,
Chengchang Tang, Chengwen Feng, Ciara Loftus, Ciara Power,
Conor Fogarty, Conor Walsh, Cristian Dumitrescu, Dan Nowlin,
Dapeng Yu, Dariusz Sosnowski, David Christensen, David Hunt,
David Marchand, Declan Doherty, Deepak Kumar Jain,
Devendra Singh Rawat, Dmitry Kozlyuk, Dmitry Kozlyuk,
Dmitry Malloy, Eli Britstein, Evgeny Schemeilin, Fan Zhang,
Feifei Wang, Fiona Trahe, Gagandeep Singh, Gaoxiang Liu,
Gregory Etelson, Guoyang Zhou, Haiyue Wang, Harman Kalra,
Harry van Haaren, Heinrich Kuhn, Hemant Agrawal,
Honnappa Nagarahalli, Huichao Cai, Huisong Li, Hyong Youb Kim,
Idan Hackmon, Igor Chauskin, Igor Romanov, Igor Russkikh,
Igor Ryzhov, Ilyes Ben Hamouda, Ivan Ilchenko, Ivan Malov,
Jakub Grajciar, Jasvinder Singh, Jay Jayatheerthan, Jay Zhou,
Jerin Jacob, Jian Wang, Jiawen Wu, Jie Wang, Jingjing Wu,
John Daley, John Griffin, John McNamara, John W. Linville,
Joyce Kong
On 12/3/2021 6:18 AM, Christian Ehrhardt wrote:
> On Thu, Dec 2, 2021 at 3:30 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 11/30/2021 4:56 PM, christian.ehrhardt@canonical.com wrote:
>>> 5139502783 Ferruh Yigit ethdev: fix typos
>>
>> These are simple 4 typo fixes, I think we can skip it. But if you think
>> we should get it, I can send a backport patch.
>
> We clearly do not have any "hard need" for typo fixes.
> But if we do not apply too many of them sooner or later nothing will
> apply easily anymore.
>
> So if it isn't feeling like a burden a backport would be appreciated
> to help the further lifetime of 19.11.x
>
Sure, if it helps.
>> One of the commit that this patch fixes is after 19.11, that should be
>> reason why apply fails.
>>
>>> a1b2558cdb Ferruh Yigit kni: restrict bifurcated device support
>>
>> This doesn't apply to 19.11, OK to skip it.
>
> ok
>
>> Asking just to understand, the patch has fixes tag as:
>> Fixes: 631217c76135 ("kni: fix kernel deadlock with bifurcated device")
>>
>> The '631217c76135' is not exist in 19.11, isn't the script check
>> for this?
>
> Not really, it is going the full chain of fixes, and if that is in the
> target release it is considered.
> So in this case it is:
>
> 21.11 a1b2558cdb S F kni: restrict bifurcated device support (1.3.0r0
> (partially fixed in 21.05))
>
> Which is saying
> 1. this is a1b2558cdb which fixes 631217c7
> 2. 631217c7 fixed something in 1.3.0r0
> 3. since you are >>19.11 you might want this
>
> It does not (but probably could and sort out some false positives)
> check in #2 if that one is really applied on the stable branch.
> I think we could check the [ upstream commit ... ] for that and
> exclude or at least mark them in this case.
>
ack, check is #2 can save some false positive
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE:
[not found] <20211130165631.2467343-1-christian.ehrhardt@canonical.com>
` (3 preceding siblings ...)
2021-12-02 14:29 ` Re: Ferruh Yigit
@ 2021-12-12 14:20 ` Ali Alnubani
2021-12-13 12:22 ` Christian Ehrhardt
4 siblings, 1 reply; 13+ messages in thread
From: Ali Alnubani @ 2021-12-12 14:20 UTC (permalink / raw)
To: dpdk stable, christian.ehrhardt, conor.walsh
Cc: Aaron Conole, Abhinandan Gujjar, Ajit Khaparde, Akhil Goyal,
Alexander Kozyrev, Alvin Zhang, Aman Singh, Anatoly Burakov,
Andrew Boyer, Andrew Rybchenko, Andy Moreton, Anoob Joseph,
Apeksha Gupta, Arek Kusztal, Ashish Gupta, Baruch Siach,
Beilei Xing, Bernard Iremonger, Bruce Richardson,
Chandubabu Namburu, Chas Williams, Chenbo Xia, Chengchang Tang,
Chengwen Feng, Ciara Loftus, Ciara Power, Conor Fogarty,
Conor Walsh, Cristian Dumitrescu, Dan Nowlin, Dapeng Yu,
Dariusz Sosnowski, David Christensen, David Hunt, David Marchand,
Declan Doherty, Deepak Kumar Jain, Devendra Singh Rawat,
Dmitry Kozlyuk, Dmitry Kozlyuk, Dmitry Malloy, Eli Britstein,
Evgeny Schemeilin, Fan Zhang, Feifei Wang, Ferruh Yigit,
Fiona Trahe, Gagandeep Singh, Gaoxiang Liu, Gregory Etelson,
Guoyang Zhou, Haiyue Wang, Harman Kalra, Harry van Haaren,
Heinrich Kuhn, Hemant Agrawal, Honnappa Nagarahalli, Huichao Cai,
Huisong Li, Hyong Youb Kim, Idan Hackmon, Igor Chauskin,
Igor Romanov, Igor Russkikh, Igor Ryzhov, Ilyes Ben Hamouda,
Ivan Ilchenko, Ivan Malov, Jakub Grajciar, Jasvinder Singh,
Jay Jayatheerthan, Jay Zhou, Jerin Jacob, Jian Wang, Jiawen Wu,
Jie Wang, Jingjing Wu, John Daley, John Griffin, John McNamara,
John W. Linville, Joyce Kong
Hello,
> -----Original Message-----
> From: christian.ehrhardt@canonical.com
> <christian.ehrhardt@canonical.com>
> Sent: Tuesday, November 30, 2021 6:57 PM
> Cc: Aaron Conole <aconole@redhat.com>; Abhinandan Gujjar
> <abhinandan.gujjar@intel.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>;
> Alexander Kozyrev <akozyrev@nvidia.com>; Ali Alnubani
> <alialnu@nvidia.com>; Alvin Zhang <alvinx.zhang@intel.com>; Aman Singh
> <aman.deep.singh@intel.com>; Anatoly Burakov
> <anatoly.burakov@intel.com>; Andrew Boyer <aboyer@pensando.io>;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Andy Moreton
> <amoreton@xilinx.com>; Anoob Joseph <anoobj@marvell.com>; Apeksha
> Gupta <apeksha.gupta@nxp.com>; Arek Kusztal
> <arkadiuszx.kusztal@intel.com>; Ashish Gupta
> <ashish.gupta@marvell.com>; Baruch Siach <baruch@tkos.co.il>; Beilei Xing
> <beilei.xing@intel.com>; Bernard Iremonger
> <bernard.iremonger@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Chandubabu Namburu
> <chandu@amd.com>; Chas Williams <chas3@att.com>; Chenbo Xia
> <chenbo.xia@intel.com>; Chengchang Tang
> <tangchengchang@huawei.com>; Chengwen Feng
> <fengchengwen@huawei.com>; Ciara Loftus <ciara.loftus@intel.com>; Ciara
> Power <ciara.power@intel.com>; Conor Fogarty <conor.fogarty@intel.com>;
> Conor Walsh <conor.walsh@intel.com>; Cristian Dumitrescu
> <cristian.dumitrescu@intel.com>; Dan Nowlin <dan.nowlin@intel.com>;
> Dapeng Yu <dapengx.yu@intel.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>;
> David Hunt <david.hunt@intel.com>; David Marchand
> <david.marchand@redhat.com>; Declan Doherty
> <declan.doherty@intel.com>; Deepak Kumar Jain
> <deepak.k.jain@intel.com>; Devendra Singh Rawat
> <dsinghrawat@marvell.com>; Dmitry Kozlyuk <dkozlyuk@nvidia.com>;
> Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Dmitry Malloy
> <dmitrym@microsoft.com>; Eli Britstein <elibr@nvidia.com>; Evgeny
> Schemeilin <evgenys@amazon.com>; Fan Zhang
> <roy.fan.zhang@intel.com>; Feifei Wang <feifei.wang2@arm.com>; Ferruh
> Yigit <ferruh.yigit@intel.com>; Fiona Trahe <fiona.trahe@intel.com>;
> Gagandeep Singh <g.singh@nxp.com>; Gaoxiang Liu
> <liugaoxiang@huawei.com>; Gregory Etelson <getelson@nvidia.com>;
> Guoyang Zhou <zhouguoyang@huawei.com>; Haiyue Wang
> <haiyue.wang@intel.com>; Harman Kalra <hkalra@marvell.com>; Harry van
> Haaren <harry.van.haaren@intel.com>; Heinrich Kuhn
> <heinrich.kuhn@corigine.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Honnappa Nagarahalli
> <honnappa.nagarahalli@arm.com>; Huichao Cai <chcchc88@163.com>;
> Huisong Li <lihuisong@huawei.com>; Hyong Youb Kim
> <hyonkim@cisco.com>; Idan Hackmon <idanhac@nvidia.com>; Igor Chauskin
> <igorch@amazon.com>; Igor Romanov <igor.romanov@oktetlabs.ru>; Igor
> Russkikh <irusskikh@marvell.com>; Igor Ryzhov <iryzhov@nfware.com>;
> Ilyes Ben Hamouda <ilyes.ben_hamouda@6wind.com>; Ivan Ilchenko
> <ivan.ilchenko@oktetlabs.ru>; Ivan Malov <ivan.malov@oktetlabs.ru>;
> Jakub Grajciar <jgrajcia@cisco.com>; Jasvinder Singh
> <jasvinder.singh@intel.com>; Jay Jayatheerthan
> <jay.jayatheerthan@intel.com>; Jay Zhou <jianjay.zhou@huawei.com>;
> Jerin Jacob <jerinj@marvell.com>; Jian Wang <jianwang@trustnetic.com>;
> Jiawen Wu <jiawenwu@trustnetic.com>; Jie Wang <jie1x.wang@intel.com>;
> Jingjing Wu <jingjing.wu@intel.com>; John Daley <johndale@cisco.com>;
> John Griffin <john.griffin@intel.com>; John McNamara
> <john.mcnamara@intel.com>; John W. Linville <linville@tuxdriver.com>;
> Joyce Kong <joyce.kong@arm.com>
> Subject:
>
> Subject: please help backporting some patches to stable release 19.11.11
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh
> I didn't apply following commits from DPDK main to 19.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
> - Backport your patches to the 19.11 branch, or
> - Indicate that the patch should not be backported
>
> Please do either of the above by December the 14th 2021 (More time than
> usual as backports get harder).
>
> You can find the a temporary work-in-progress branch of the coming 19.11.11
> release at:
> https://github.com/cpaelzer/dpdk-stable-queue
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
> [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
> https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
> [PATCH 19.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
> --subject-prefix='PATCH 19.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 19.11 is located at tree:
> https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> ---
>
> Applying but breaking the build:
>
> 858a152ab5 Junxiao Shi net/memif: allow stopping and closing device
> c4d3e8fbe4 Ruifeng Wang net/i40e: fix risk in descriptor read in scalar Rx
> 7dc627426e Olivier Matz test/mbuf: fix access to freed memory
> 86e361cdeb David Marchand test/cmdline: fix memory leak
> 04bcc80204 Xuan Ding net/virtio: fix indirect descriptor reconnection
> 9de76dfb92 Ivan Ilchenko net/virtio: fix Tx completed mbuf leak on device
> stop
> 5d903aee8a Gaoxiang Liu net/virtio: fix repeated freeing of virtqueue
> 9c8c806487 Thomas Monjalon test/crypto: fix minsize build
> 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init
> failure
>
> ---
>
> Not Applying
>
[..]
> 9465a5d5a0 Conor Walsh net/nfp: remove unused message length
I can reproduce a build failure (https://bugs.dpdk.org/show_bug.cgi?id=900) with Clang 13, and it's fixed by this patch.
Let me know if you need help with backporting it.
Thanks,
Ali
^ permalink raw reply [flat|nested] 13+ messages in thread* Re:
2021-12-12 14:20 ` Ali Alnubani
@ 2021-12-13 12:22 ` Christian Ehrhardt
0 siblings, 0 replies; 13+ messages in thread
From: Christian Ehrhardt @ 2021-12-13 12:22 UTC (permalink / raw)
To: Ali Alnubani
Cc: dpdk stable, conor.walsh, Aaron Conole, Abhinandan Gujjar,
Ajit Khaparde, Akhil Goyal, Alexander Kozyrev, Alvin Zhang,
Aman Singh, Anatoly Burakov, Andrew Boyer, Andrew Rybchenko,
Andy Moreton, Anoob Joseph, Apeksha Gupta, Arek Kusztal,
Ashish Gupta, Baruch Siach, Beilei Xing, Bernard Iremonger,
Bruce Richardson, Chandubabu Namburu, Chas Williams, Chenbo Xia,
Chengchang Tang, Chengwen Feng, Ciara Loftus, Ciara Power,
Conor Fogarty, Cristian Dumitrescu, Dan Nowlin, Dapeng Yu,
Dariusz Sosnowski, David Christensen, David Hunt, David Marchand,
Declan Doherty, Deepak Kumar Jain, Devendra Singh Rawat,
Dmitry Kozlyuk, Dmitry Kozlyuk, Dmitry Malloy, Eli Britstein,
Evgeny Schemeilin, Fan Zhang, Feifei Wang, Ferruh Yigit,
Fiona Trahe, Gagandeep Singh, Gaoxiang Liu, Gregory Etelson,
Guoyang Zhou, Haiyue Wang, Harman Kalra, Harry van Haaren,
Heinrich Kuhn, Hemant Agrawal, Honnappa Nagarahalli, Huichao Cai,
Huisong Li, Hyong Youb Kim, Idan Hackmon, Igor Chauskin,
Igor Romanov, Igor Russkikh, Igor Ryzhov, Ilyes Ben Hamouda,
Ivan Ilchenko, Ivan Malov, Jakub Grajciar, Jasvinder Singh,
Jay Jayatheerthan, Jay Zhou, Jerin Jacob, Jian Wang, Jiawen Wu,
Jie Wang, Jingjing Wu, John Daley, John Griffin, John McNamara,
John W. Linville, Joyce Kong
On Sun, Dec 12, 2021 at 3:20 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> Hello,
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com
> > <christian.ehrhardt@canonical.com>
> > Sent: Tuesday, November 30, 2021 6:57 PM
> > Cc: Aaron Conole <aconole@redhat.com>; Abhinandan Gujjar
> > <abhinandan.gujjar@intel.com>; Ajit Khaparde
> > <ajit.khaparde@broadcom.com>; Akhil Goyal <gakhil@marvell.com>;
> > Alexander Kozyrev <akozyrev@nvidia.com>; Ali Alnubani
> > <alialnu@nvidia.com>; Alvin Zhang <alvinx.zhang@intel.com>; Aman Singh
> > <aman.deep.singh@intel.com>; Anatoly Burakov
> > <anatoly.burakov@intel.com>; Andrew Boyer <aboyer@pensando.io>;
> > Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Andy Moreton
> > <amoreton@xilinx.com>; Anoob Joseph <anoobj@marvell.com>; Apeksha
> > Gupta <apeksha.gupta@nxp.com>; Arek Kusztal
> > <arkadiuszx.kusztal@intel.com>; Ashish Gupta
> > <ashish.gupta@marvell.com>; Baruch Siach <baruch@tkos.co.il>; Beilei Xing
> > <beilei.xing@intel.com>; Bernard Iremonger
> > <bernard.iremonger@intel.com>; Bruce Richardson
> > <bruce.richardson@intel.com>; Chandubabu Namburu
> > <chandu@amd.com>; Chas Williams <chas3@att.com>; Chenbo Xia
> > <chenbo.xia@intel.com>; Chengchang Tang
> > <tangchengchang@huawei.com>; Chengwen Feng
> > <fengchengwen@huawei.com>; Ciara Loftus <ciara.loftus@intel.com>; Ciara
> > Power <ciara.power@intel.com>; Conor Fogarty <conor.fogarty@intel.com>;
> > Conor Walsh <conor.walsh@intel.com>; Cristian Dumitrescu
> > <cristian.dumitrescu@intel.com>; Dan Nowlin <dan.nowlin@intel.com>;
> > Dapeng Yu <dapengx.yu@intel.com>; Dariusz Sosnowski
> > <dsosnowski@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>;
> > David Hunt <david.hunt@intel.com>; David Marchand
> > <david.marchand@redhat.com>; Declan Doherty
> > <declan.doherty@intel.com>; Deepak Kumar Jain
> > <deepak.k.jain@intel.com>; Devendra Singh Rawat
> > <dsinghrawat@marvell.com>; Dmitry Kozlyuk <dkozlyuk@nvidia.com>;
> > Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Dmitry Malloy
> > <dmitrym@microsoft.com>; Eli Britstein <elibr@nvidia.com>; Evgeny
> > Schemeilin <evgenys@amazon.com>; Fan Zhang
> > <roy.fan.zhang@intel.com>; Feifei Wang <feifei.wang2@arm.com>; Ferruh
> > Yigit <ferruh.yigit@intel.com>; Fiona Trahe <fiona.trahe@intel.com>;
> > Gagandeep Singh <g.singh@nxp.com>; Gaoxiang Liu
> > <liugaoxiang@huawei.com>; Gregory Etelson <getelson@nvidia.com>;
> > Guoyang Zhou <zhouguoyang@huawei.com>; Haiyue Wang
> > <haiyue.wang@intel.com>; Harman Kalra <hkalra@marvell.com>; Harry van
> > Haaren <harry.van.haaren@intel.com>; Heinrich Kuhn
> > <heinrich.kuhn@corigine.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Honnappa Nagarahalli
> > <honnappa.nagarahalli@arm.com>; Huichao Cai <chcchc88@163.com>;
> > Huisong Li <lihuisong@huawei.com>; Hyong Youb Kim
> > <hyonkim@cisco.com>; Idan Hackmon <idanhac@nvidia.com>; Igor Chauskin
> > <igorch@amazon.com>; Igor Romanov <igor.romanov@oktetlabs.ru>; Igor
> > Russkikh <irusskikh@marvell.com>; Igor Ryzhov <iryzhov@nfware.com>;
> > Ilyes Ben Hamouda <ilyes.ben_hamouda@6wind.com>; Ivan Ilchenko
> > <ivan.ilchenko@oktetlabs.ru>; Ivan Malov <ivan.malov@oktetlabs.ru>;
> > Jakub Grajciar <jgrajcia@cisco.com>; Jasvinder Singh
> > <jasvinder.singh@intel.com>; Jay Jayatheerthan
> > <jay.jayatheerthan@intel.com>; Jay Zhou <jianjay.zhou@huawei.com>;
> > Jerin Jacob <jerinj@marvell.com>; Jian Wang <jianwang@trustnetic.com>;
> > Jiawen Wu <jiawenwu@trustnetic.com>; Jie Wang <jie1x.wang@intel.com>;
> > Jingjing Wu <jingjing.wu@intel.com>; John Daley <johndale@cisco.com>;
> > John Griffin <john.griffin@intel.com>; John McNamara
> > <john.mcnamara@intel.com>; John W. Linville <linville@tuxdriver.com>;
> > Joyce Kong <joyce.kong@arm.com>
> > Subject:
> >
> > Subject: please help backporting some patches to stable release 19.11.11
> >
> > Hi commit authors (and maintainers),
> >
> > Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> > fixes.sh
> > I didn't apply following commits from DPDK main to 19.11
> > stable branch, as conflicts or build errors occur.
> >
> > Can authors check your patches in the following list and either:
> > - Backport your patches to the 19.11 branch, or
> > - Indicate that the patch should not be backported
> >
> > Please do either of the above by December the 14th 2021 (More time than
> > usual as backports get harder).
> >
> > You can find the a temporary work-in-progress branch of the coming 19.11.11
> > release at:
> > https://github.com/cpaelzer/dpdk-stable-queue
> > It is recommended to backport on top of that to minimize further conflicts or
> > misunderstandings.
> >
> > Some notes on stable backports:
> >
> > A backport should contain a reference to the DPDK main branch commit
> > in it's commit message in the following fashion:
> > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> >
> > For example:
> > https://git.dpdk.org/dpdk-
> > stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> >
> > When sending the backported patch, please indicate the target branch in the
> > subject line, as we have multiple branches, for example:
> > [PATCH 19.11] foo/bar: fix baz
> >
> > With git format-patch, this can be achieved by appending the parameter:
> > --subject-prefix='PATCH 19.11'
> >
> > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> >
> > FYI, branch 19.11 is located at tree:
> > https://git.dpdk.org/dpdk-stable
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
> >
> > Applying but breaking the build:
> >
> > 858a152ab5 Junxiao Shi net/memif: allow stopping and closing device
> > c4d3e8fbe4 Ruifeng Wang net/i40e: fix risk in descriptor read in scalar Rx
> > 7dc627426e Olivier Matz test/mbuf: fix access to freed memory
> > 86e361cdeb David Marchand test/cmdline: fix memory leak
> > 04bcc80204 Xuan Ding net/virtio: fix indirect descriptor reconnection
> > 9de76dfb92 Ivan Ilchenko net/virtio: fix Tx completed mbuf leak on device
> > stop
> > 5d903aee8a Gaoxiang Liu net/virtio: fix repeated freeing of virtqueue
> > 9c8c806487 Thomas Monjalon test/crypto: fix minsize build
> > 96b25c496a Haiyue Wang net/ice: fix memzone leak after device init
> > failure
> >
> > ---
> >
> > Not Applying
> >
> [..]
> > 9465a5d5a0 Conor Walsh net/nfp: remove unused message length
>
> I can reproduce a build failure (https://bugs.dpdk.org/show_bug.cgi?id=900) with Clang 13, and it's fixed by this patch.
> Let me know if you need help with backporting it.
Thanks, the backport was trivial (same change to another filename) and
works fine.
Also since it isn't really a functional change I do not think we need
to re-start another -rc for this one.
Applied.
> Thanks,
> Ali
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 13+ messages in thread